Re: CVS commit: src

2013-07-04 Thread Taylor R Campbell
Date: Thu, 04 Jul 2013 08:51:09 +0100 From: Nick Hudson On 06/23/13 03:35, Taylor R Campbell wrote: > + * rndsink_request takes a spin lock at IPL_VM, so we can be no > + * higher than that. > + */ > + KASSERT(ipl <= IPL_VM); This isn't always the case as some plat

Re: CVS commit: src/sys/rump

2013-07-04 Thread Antti Kantee
On 4.7.2013 15:05, Valery Ushakov wrote: Ah, I was confused because just before that I was staring at FreeBSD bsd.sys.mk which does use CWARNFLAGS for -W* and then looked at -Werror in ours. History says: revision 1.26 date: 1998-08-25 18:57:21 +0400; author: tv; state: Exp; lines: +3 -2; In

Re: CVS commit: src/sys/rump

2013-07-04 Thread Valery Ushakov
On Thu, Jul 04, 2013 at 14:56:17 +0300, Antti Kantee wrote: > On 4.7.2013 14:53, Valery Ushakov wrote: > >On Thu, Jul 04, 2013 at 10:14:04 +, Antti Kantee wrote: > > > >>Module Name:src > >>Committed By: pooka > >>Date: Thu Jul 4 10:14:04 UTC 2013 > >> > >>Modified

Re: CVS commit: src/sys/rump

2013-07-04 Thread Antti Kantee
On 4.7.2013 14:53, Valery Ushakov wrote: On Thu, Jul 04, 2013 at 10:14:04 +, Antti Kantee wrote: Module Name:src Committed By: pooka Date: Thu Jul 4 10:14:04 UTC 2013 Modified Files: src/sys/rump: Makefile.rump Log Message: Apparently warning flags are not kept in

Re: CVS commit: src/sys/rump

2013-07-04 Thread Valery Ushakov
On Thu, Jul 04, 2013 at 10:14:04 +, Antti Kantee wrote: > Module Name: src > Committed By: pooka > Date: Thu Jul 4 10:14:04 UTC 2013 > > Modified Files: > src/sys/rump: Makefile.rump > > Log Message: > Apparently warning flags are not kept in CWARNFLAGS. Compensate. Would y

Re: CVS commit: src

2013-07-04 Thread Manuel Bouyer
On Thu, Jul 04, 2013 at 08:51:09AM +0100, Nick Hudson wrote: > On 06/23/13 03:35, Taylor R Campbell wrote: > >+ * rndsink_request takes a spin lock at IPL_VM, so we can be no > >+ * higher than that. > >+ */ > >+KASSERT(ipl <= IPL_VM); > > Hi, > > This isn't always the case as som

Re: CVS commit: src

2013-07-04 Thread Nick Hudson
On 06/23/13 03:35, Taylor R Campbell wrote: +* rndsink_request takes a spin lock at IPL_VM, so we can be no +* higher than that. +*/ + KASSERT(ipl <= IPL_VM); Hi, This isn't always the case as some platforms have a different ordering for IPL levels. How about