Re: CVS commit: src/tests/lib/libc/gen (address alignment)

2012-04-20 Thread Paul Goyette
On Fri, 20 Apr 2012, Paul Goyette wrote: The machine did not drop into ddb, it simply rebooted. Unfortunately it did not leave a core dump behind, so I don't have much to look at just yet. When I get home later today, I will try to get more info. BTW, this occurred while running the ATF tes

Re: CVS commit: src/tests/lib/libc/gen (address alignment)

2012-04-20 Thread Paul Goyette
On Fri, 20 Apr 2012, Paul Goyette wrote: XXX I would appreciate if someone could test it under a real amd64 host with an up-to-date kernel, so I can reasonably assume that the culprit is Virtual Box and not our amd64 port (my test machine being off line I cannot do it myself). Results from oth

Re: CVS commit: src/tests/lib/libc/gen (address alignment)

2012-04-20 Thread Paul Goyette
XXX I would appreciate if someone could test it under a real amd64 host with an up-to-date kernel, so I can reasonably assume that the culprit is Virtual Box and not our amd64 port (my test machine being off line I cannot do it myself). Results from other arches would be a plus too. I just up

Re: CVS commit: src/usr.sbin/makefs/ffs

2012-04-20 Thread Christos Zoulas
In article <20120419194815.b1dfd17...@cvs.netbsd.org>, David A. Holland wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: dholland >Date: Thu Apr 19 19:48:15 UTC 2012 > >Modified Files: > src/usr.sbin/makefs/ffs: mkfs.c > >Log Message: >Fix build failure reported by bracket.

Re: CVS commit: src/sys/dev/scsipi

2012-04-20 Thread Manuel Bouyer
On Fri, Apr 20, 2012 at 06:06:35PM +1000, matthew green wrote: > > > > we've never had autoconfig run with the kernel lock AFAICT, so this > > > assumption has never been true. > > > > So this is a bug. The contract was really that spl-locked drivers would > > continue to work as is when fine-gra

re: CVS commit: src/sys/dev/scsipi

2012-04-20 Thread matthew green
> > we've never had autoconfig run with the kernel lock AFAICT, so this > > assumption has never been true. > > So this is a bug. The contract was really that spl-locked drivers would > continue to work as is when fine-grained locking was introduced. there are no actual bugs or races here. this

Re: CVS commit: src/sys/dev/scsipi

2012-04-20 Thread Manuel Bouyer
On Fri, Apr 20, 2012 at 07:46:35AM +, David Holland wrote: > On Fri, Apr 20, 2012 at 09:37:00AM +0200, Manuel Bouyer wrote: > > > we've never had autoconfig run with the kernel lock AFAICT, so this > > > assumption has never been true. > > > > So this is a bug. The contract was really that

Re: CVS commit: src/sys/dev/scsipi

2012-04-20 Thread David Holland
On Fri, Apr 20, 2012 at 09:37:00AM +0200, Manuel Bouyer wrote: > > we've never had autoconfig run with the kernel lock AFAICT, so this > > assumption has never been true. > > So this is a bug. The contract was really that spl-locked drivers would > continue to work as is when fine-grained loc

Re: CVS commit: src/sys/dev/scsipi

2012-04-20 Thread Manuel Bouyer
On Thu, Apr 19, 2012 at 06:39:29PM -0600, Warner Losh wrote: > FreeBSD started out with MPSAFE and then went to NEEDS_GIANT as flags for the > drivers. I'm with Matthew: patch the drivers that are broken (or not known > to be safe) and then you have a convenient thing to grep for when you want t

Re: CVS commit: src/sys/dev/scsipi

2012-04-20 Thread Manuel Bouyer
On Fri, Apr 20, 2012 at 10:03:09AM +1000, matthew green wrote: > > > > scsipi depends upon kernel lock. thus, callers should arrange for it > > > to be held. since these are drivers calling, it is upto each driver > > > to do this currently. this is what we've done with other problems we > > >