On Apr 19, 2012, at 6:03 PM, matthew green wrote:
>> But that's a problem with autoconf not dealing with non-MPSAFE drivers,
>> not the driver themselve (they were working before the MP changes, they
>> should continue to work as-is). If you want autoconf to not run
>> under the KERNEL_LOCK when n
> > scsipi depends upon kernel lock. thus, callers should arrange for it
> > to be held. since these are drivers calling, it is upto each driver
> > to do this currently. this is what we've done with other problems we
> > have hit as they've arrived.
>
> if the caller is MPSAFE, I agree. Non-M
On Thu, Apr 19, 2012 at 07:00:56PM +1000, matthew green wrote:
>
> > > > If the driver's attach is called after cold (e.g. after a detach/rescan
> > > > of the pci bus), the driver's attach should be called with KERNEL_LOCK
> > > > held, or bad things may happen when interrupts are enabled for thi
> > > If the driver's attach is called after cold (e.g. after a detach/rescan
> > > of the pci bus), the driver's attach should be called with KERNEL_LOCK
> > > held, or bad things may happen when interrupts are enabled for this
> > > driver.
> >
> > there should be no reliance on "cold" being s
On Thu, Apr 19, 2012 at 06:25:54PM +1000, matthew green wrote:
> [...]
>
> > If the driver's attach is called after cold (e.g. after a detach/rescan
> > of the pci bus), the driver's attach should be called with KERNEL_LOCK
> > held, or bad things may happen when interrupts are enabled for this dr
> > > Module Name: src
> > > Committed By: bouyer
> > > Date: Wed Apr 18 20:37:49 UTC 2012
> > >
> > > Modified Files:
> > > src/sys/dev/scsipi: scsipi_base.c
> > >
> > > Log Message:
> > > Fix KASSERT(): autoconf doesn't run under the KERNEL_LOCK
> >
> > this is true, bu
On Thu, Apr 19, 2012 at 04:41:04PM +1000, matthew green wrote:
>
> > Module Name:src
> > Committed By: bouyer
> > Date: Wed Apr 18 20:37:49 UTC 2012
> >
> > Modified Files:
> > src/sys/dev/scsipi: scsipi_base.c
> >
> > Log Message:
> > Fix KASSERT(): autoconf does
