Re: CVS commit: src/lib/libarch/alpha

2012-03-22 Thread Martin Husemann
On Thu, Mar 22, 2012 at 09:35:48AM -0600, Warner Losh wrote: > When was the last time that NetBSD could be compiled with a K&R compiler? > 1995? Dunno, but we killed supported ports because we have no working C99 compiler for them (playstation2). Martin

Re: CVS commit: src/lib/libarch/alpha

2012-03-22 Thread Warner Losh
On Mar 22, 2012, at 8:43 AM, Joerg Sonnenberger wrote: > On Thu, Mar 22, 2012 at 02:51:08PM +0100, Havard Eidnes wrote: >> IMHO, as long as lint is capable of helping us spot actual >> problems, adding a few of these sorts of constrcucts seems like a >> small price to pay. > > It doesn't. From w

Re: CVS commit: src/lib/libarch/alpha

2012-03-22 Thread Joerg Sonnenberger
On Thu, Mar 22, 2012 at 02:51:08PM +0100, Havard Eidnes wrote: > IMHO, as long as lint is capable of helping us spot actual > problems, adding a few of these sorts of constrcucts seems like a > small price to pay. It doesn't. From what I see, the signal to noise ratio of lint is completely inaccep

Re: CVS commit: src/lib/libarch/alpha

2012-03-22 Thread Christos Zoulas
In article <20120322100642.ga1...@apb-laptoy.apb.alt.za>, Alan Barrett wrote: >I don't know what "balancing" means, but this seems bogus to >me. The type of the right hand operand of the << operator is >irrelevant; only its value is important. (See sectiopn 6.5.7 of >the C99 standard.) Bal

Re: CVS commit: src/lib/libc/gen

2012-03-22 Thread Alan Barrett
On Thu, 22 Mar 2012, Havard Eidnes wrote: Module Name:src Committed By: he Date: Thu Mar 22 13:42:36 UTC 2012 Modified Files: src/lib/libc/gen: nlist_coff.c Log Message: Make this lint-free (only built for real for the __sh__ ports): * Mark some code after goto as /* NOT

Re: CVS commit: src/lib/libarch/alpha

2012-03-22 Thread Havard Eidnes
> On Thu, Mar 22, 2012 at 08:54:49AM +, Havard Eidnes wrote: >> Module Name: src >> Committed By:he >> Date:Thu Mar 22 08:54:48 UTC 2012 >> >> Modified Files: >> src/lib/libarch/alpha: alpha_pci_io.c >> >> Log Message: >> Add a cast of the shift count to int32_t, so

Re: CVS commit: src/lib/libc/gen

2012-03-22 Thread Alan Barrett
On Thu, 22 Mar 2012, Havard Eidnes wrote: Modified Files: src/lib/libc/gen: modf_ieee754.c Log Message: Add a pair of casts to silence lint about conversion possibly losing bits. - v.dblu_dbl.dbl_fracl = frac & 0x; - v.dblu_dbl.dbl_frach = frac >> 32; + v.dbl

Re: CVS commit: src/lib/libc/arch/alpha/gen

2012-03-22 Thread Valeriy E. Ushakov
On Thu, Mar 22, 2012 at 07:27:18 +, David Laight wrote: > On Wed, Mar 21, 2012 at 11:57:25PM +0100, Nicolas Joly wrote: > > On Wed, Mar 21, 2012 at 10:42:58PM +0200, Alan Barrett wrote: > > > On Wed, 21 Mar 2012, Havard Eidnes wrote: > > > >Modified Files: > > > > src/lib/libc/arch/alpha/gen:

Re: CVS commit: src/lib/libarch/alpha

2012-03-22 Thread Alan Barrett
On Thu, 22 Mar 2012, Havard Eidnes wrote: Modified Files: src/lib/libarch/alpha: alpha_pci_io.c Log Message: Add a cast of the shift count to int32_t, so that we don't try to do int32_t << long, since ANSI C doesn't perform "balancing" before the shift operation according to lint. Shoul

Re: CVS commit: src/lib/libarch/alpha

2012-03-22 Thread Joerg Sonnenberger
On Thu, Mar 22, 2012 at 08:54:49AM +, Havard Eidnes wrote: > Module Name: src > Committed By: he > Date: Thu Mar 22 08:54:48 UTC 2012 > > Modified Files: > src/lib/libarch/alpha: alpha_pci_io.c > > Log Message: > Add a cast of the shift count to int32_t, so that we don't try >

Re: CVS commit: src/lib/libc/arch/alpha/gen

2012-03-22 Thread David Laight
On Wed, Mar 21, 2012 at 11:57:25PM +0100, Nicolas Joly wrote: > On Wed, Mar 21, 2012 at 10:42:58PM +0200, Alan Barrett wrote: > > On Wed, 21 Mar 2012, Havard Eidnes wrote: > > >Modified Files: > > > src/lib/libc/arch/alpha/gen: fpgetround.c fpsetround.c > > > > > >Log Message: > > >Add some casts