Re: CVS commit: src

2011-09-28 Thread Jukka Ruohonen
On Wed, Sep 28, 2011 at 07:50:43PM +0100, Alexander Nasonov wrote: > You probably need to assign to a temporary variable here > > > + > > + if (cf_backend == NULL) > > + return ENOMEM; > > + > > + mutex_enter(&cpufreq_lock); > > and do cf_backend != NULL check one more time here bef

Re: CVS commit: src

2011-09-28 Thread Alexander Nasonov
Hi Jukka, you wrote: > +int > +cpufreq_register(struct cpufreq *cf) > +{ > + mutex_enter(&cpufreq_lock); > + > + if (cf_backend != NULL) { > + mutex_exit(&cpufreq_lock); > + return EALREADY; > + } > + > + mutex_exit(&cpufreq_lock); > + cf_backend =

Re: CVS commit: src/external/mit/xorg/lib/xkeyboard-config/rules

2011-09-28 Thread Izumi Tsutsui
> > Modified Files: > > src/external/mit/xorg/lib/xkeyboard-config/rules: base base.lst evdev > > evdev.lst : > > XXX1: can't we generate these files during build? : > sounds like a wonderful idea.. can you do it? :) Well, it turns out the dist/Makefile.in calls perl and intltools...