Re: CVS commit: src/sys/fs/puffs

2011-09-22 Thread Emmanuel Dreyfus
YAMAMOTO Takashi wrote: > > This avoids deadlocks in the following situations: > > 1) when memory is low: ioflush waits the fileystem, the fielsystem waits > >for memory > can you explain how it is a problem? As I understand, one way to free memory is to flush vnode backed pages to the back

Re: CVS commit: src/sys

2011-09-22 Thread YAMAMOTO Takashi
hi, > Module Name: src > Committed By: manu > Date: Fri Sep 23 01:57:32 UTC 2011 > > Modified Files: > src/sys/fs/puffs: puffs_vnops.c > src/sys/miscfs/syncfs: sync_subr.c > > Log Message: > Fix the build that was broken by struct lwp *updateproc reference in > RUMP-visible

Re: CVS commit: src/sys/fs/puffs

2011-09-22 Thread YAMAMOTO Takashi
hi, > Module Name: src > Committed By: manu > Date: Wed Sep 21 15:36:33 UTC 2011 > > Modified Files: > src/sys/fs/puffs: puffs_vfsops.c puffs_vnops.c > > Log Message: > Make sure ioflush does not sleep in PUFFS code path, waiting for a mutex, > a memory allocation, or a response f

Re: CVS commit: src/usr.bin/audio/record

2011-09-22 Thread David Laight
On Thu, Sep 22, 2011 at 09:28:56PM +0200, Marc Balmer wrote: > > Am 22.09.2011 um 19:34 schrieb Christos Zoulas: > > > In article , > > Marc Balmer wrote: > >>> if (outfd == STDOUT_FILENO) > >>> return; > >>> > >>> - if (lseek(outfd, SEEK_SET, 0) < 0) > >>> + if (lseek(outfd, (off_

Re: CVS commit: src/usr.bin/audio/record

2011-09-22 Thread Marc Balmer
Am 22.09.2011 um 19:34 schrieb Christos Zoulas: > In article , > Marc Balmer wrote: >>> if (outfd == STDOUT_FILENO) >>> return; >>> >>> - if (lseek(outfd, SEEK_SET, 0) < 0) >>> + if (lseek(outfd, (off_t)0, SEEK_SET) == (off_t)-1) >>> err(1, "could not seek to st

Re: CVS commit: src/usr.bin/audio/record

2011-09-22 Thread Christos Zoulas
In article , Marc Balmer wrote: >> if (outfd == STDOUT_FILENO) >> return; >> >> -if (lseek(outfd, SEEK_SET, 0) < 0) >> +if (lseek(outfd, (off_t)0, SEEK_SET) == (off_t)-1) >> err(1, "could not seek to start of file for header rewrite"); > >Fwiw, this never c