Re: CVS commit: src/sys/dev/wscons

2011-06-28 Thread Michael
Hello, On Wed, 29 Jun 2011 04:23:00 + (UTC) chris...@astron.com (Christos Zoulas) wrote: > In article <20110629030617.0d3dc17...@cvs.netbsd.org>, > Michael Lorenz wrote: > >-=-=-=-=-=- > > > >+struct wsdisplayio_edid_info { > >+int buffer_size; > >+int data_size; > >+uint8_t *edi

Re: CVS commit: src/sys/dev/wscons

2011-06-28 Thread Christos Zoulas
In article <20110629030617.0d3dc17...@cvs.netbsd.org>, Michael Lorenz wrote: >-=-=-=-=-=- > >+struct wsdisplayio_edid_info { >+ int buffer_size; >+ int data_size; >+ uint8_t *edid_data; >+}; Shouldn't the sizes be size_t or uintXX_t? Signed sizes lead to bugs. Shouldn't edit_data b

Re: CVS commit: src/lib/libperfuse

2011-06-28 Thread Christos Zoulas
In article <20110628161917.8fcca17...@cvs.netbsd.org>, Emmanuel Dreyfus wrote: > LIB=perfuse >-LIBDPLIBS+= puffs ${.CURDIR}/../libpuffs >+LIBDPLIBS+= puffs /usr/src/lib/libpuffs Looks wrong. > >-.ifdef DEBUG > PERFUSE_OPT_DEBUG_FLAGS= -g -DPERFUSE_DEBUG >-.endif christos

Re: CVS commit: src/sys/arch/mips/rmi

2011-06-28 Thread Jukka Ruohonen
On Tue, Jun 28, 2011 at 07:17:31AM +, Adam Hoka wrote: > Module Name: src > Committed By: ahoka > Date: Tue Jun 28 07:17:31 UTC 2011 > > Modified Files: > src/sys/arch/mips/rmi: rmixl_nand.c > > Log Message: > follow nand api changes Some of these changes broke the build. - J