Re: CVS commit: src/lib/csu

2011-01-31 Thread Joerg Sonnenberger
On Mon, Jan 31, 2011 at 04:07:43PM -0800, Simon J. Gerraty wrote: > I didn't follow the conversation, how is this patch relevant to BUILDID? Some of the redefinition magic involved with BUILDID results in .PARSEDIR as ".", not a full path. This only happens if none of the usual MAKEOBJDIR* variabl

Re: CVS commit: src/lib/csu

2011-01-31 Thread Simon J. Gerraty
>> I can comment out the MAKEOBJDIR assignment in nbmake-amd64 and it still >> works fine. BSDOBJDIR doesn't seem to do anything. BUILDID breaks this. >> I have no idea why those variables even exist, the code in bsd.own.mk is >> messy at best and I don't think it justifies the changes to the >> Ma

Re: CVS commit: src/sys/fs/sysvbfs

2011-01-31 Thread David Holland
On Mon, Jan 31, 2011 at 06:48:51PM +, Nicolas Joly wrote: > Log Message: > In sysvbfs_lookup(), deny last component write operation on a > read-only mount. > Fix PR/44302: sysvbfs allows unlink on fs mounted MNT_RDONLY. Is there any reason these checks can't be done above the FS? -- Davi

Re: CVS commit: src/lib/csu

2011-01-31 Thread David Holland
On Mon, Jan 31, 2011 at 10:34:25PM +, David Holland wrote: >> -static char curdir[MAXPATHLEN + 1];/* startup directory */ >> +char curdir[MAXPATHLEN + 1]; /* startup directory */ >> [...] >> - Var_Set(".PARSEDIR", ".", VAR_GLOBAL, 0); >> + extern char curdir[]; >> +

Re: CVS commit: src/lib/csu

2011-01-31 Thread David Holland
On Mon, Jan 31, 2011 at 11:05:23PM +0100, Joerg Sonnenberger wrote: > -static char curdir[MAXPATHLEN + 1]; /* startup directory */ > +char curdir[MAXPATHLEN + 1];/* startup directory */ > [...] > -Var_Set(".PARSEDIR", ".", VAR_GLOBAL, 0); > +extern char curdir[]; > +Var_

Re: CVS commit: src/lib/csu

2011-01-31 Thread Joerg Sonnenberger
On Mon, Jan 31, 2011 at 09:54:03PM +0100, Joerg Sonnenberger wrote: > On Mon, Jan 31, 2011 at 08:42:59PM +0100, Matthias Drochner wrote: > > > > jo...@britannica.bec.de said: > > > $ ~/work/NetBSD/obj/clang-base/tools/bin/nbmake-amd64 -V .OBJDIR > > > /home/joerg/work/NetBSD/obj/clang-base/amd64/l

Re: CVS commit: src/lib/csu

2011-01-31 Thread Matthias Drochner
jo...@britannica.bec.de said: > BSDOBJDIR doesn't seem to do anything. BUILDID breaks this. I have no > idea why those variables even exist, the code in bsd.own.mk is messy > at best I agree that the code is messy, but at least BUILDID serves a useful purpose: I can use the same source tree from

Re: CVS commit: src/lib/csu

2011-01-31 Thread Joerg Sonnenberger
On Mon, Jan 31, 2011 at 08:42:59PM +0100, Matthias Drochner wrote: > > jo...@britannica.bec.de said: > > $ ~/work/NetBSD/obj/clang-base/tools/bin/nbmake-amd64 -V .OBJDIR > > /home/joerg/work/NetBSD/obj/clang-base/amd64/lib/csu > > This shows that you are not using an .OBJDIR, in the sense that it

Re: CVS commit: src/lib/csu

2011-01-31 Thread Matthias Drochner
jo...@britannica.bec.de said: > $ ~/work/NetBSD/obj/clang-base/tools/bin/nbmake-amd64 -V .OBJDIR > /home/joerg/work/NetBSD/obj/clang-base/amd64/lib/csu This shows that you are not using an .OBJDIR, in the sense that it is different from .CURDIR. See the make(1) manpage. There are various rules w

Re: CVS commit: src/lib/csu

2011-01-31 Thread Joerg Sonnenberger
On Mon, Jan 31, 2011 at 07:32:50PM +0100, Matthias Drochner wrote: > > m.droch...@fz-juelich.de said: > > $ make -V .OBJDIR > > [...]/src/lib/csu/obj.zelz27 > > And as a data point, to show what's going wrong: > $ make -V COMMON_DIR > ./common > > That should be ../common, or better an absolute

Re: CVS commit: src/lib/csu

2011-01-31 Thread Matthias Drochner
m.droch...@fz-juelich.de said: > $ make -V .OBJDIR > [...]/src/lib/csu/obj.zelz27 And as a data point, to show what's going wrong: $ make -V COMMON_DIR ./common That should be ../common, or better an absolute path. best regards Matthias ---

Re: CVS commit: src/lib/csu

2011-01-31 Thread Matthias Drochner
jo...@britannica.bec.de said: > Please explain. .PARSEDIR should be completely independent of .OBJDIR > and I would strongly prefer to keep it because it is a hell lot more > predictable... As said, it just doesn't work: $ pwd [...]/src/lib/csu $ make -V .OBJDIR [...]/src/lib/csu/obj.zelz27 $ mak

Re: CVS commit: src/lib/csu

2011-01-31 Thread Joerg Sonnenberger
On Mon, Jan 31, 2011 at 05:54:20PM +, Matthias Drochner wrote: > Module Name: src > Committed By: drochner > Date: Mon Jan 31 17:54:20 UTC 2011 > > Modified Files: > src/lib/csu: Makefile > src/lib/csu/common: Makefile.inc > > Log Message: > use of .PARSEDIR just doesn't

Re: CVS commit: src

2011-01-31 Thread David Young
On Mon, Jan 31, 2011 at 03:24:25PM +1100, matthew green wrote: > > > disklabel.h should export nothing to userland and values userland > > needs should be obtained via sysctl. > > > > I've been asking this question of various developers for a while. > > >>> > > >>> how do i c

Re: CVS commit: src/compat

2011-01-31 Thread Alan Barrett
On Mon, 31 Jan 2011, Matt Thomas wrote: > +MAKEDIRTARGETENV= > +.if defined(MAKEOBJDIRPREFIX) > +MAKEDIRTARGETENV+= unset MAKEOBJDIRPREFIX && > +.endif > +MAKEDIRTARGETENV+= MAKEOBJDIR='$${.CURDIR:C,^${NETBSDSRCDIR},${.OBJDIR},}' > +MAKEDIRTARGETENV+= MKOBJDIRS=yes MKSHARE=no > +MAKEDIRTARGET