Re: CVS commit: src/lib/libc/stdlib

2010-09-30 Thread Christos Zoulas
In article <20100930134213.ga18...@colwyn.zhadum.org.uk>, Matthias Scheler wrote: >On Thu, Sep 30, 2010 at 03:35:41PM +0200, Nicolas Joly wrote: >> That may be part of the problem (at least for zsh 4.2). >> >> http://www.opengroup.org/onlinepubs/009695399/functions/putenv.html >> >> >From the O

Re: CVS commit: src

2010-09-30 Thread Christos Zoulas
In article <20100930133211.gc25...@britannica.bec.de>, Joerg Sonnenberger wrote: >For the record, I objected this alternative to my earlier patch because >it once again buries the Alpha madness deeply inside MD headers. This is >just asking to recreate the problem the next time someone wants to d

Re: CVS commit: src/lib/libc/stdlib

2010-09-30 Thread Nicolas Joly
On Thu, Sep 30, 2010 at 12:41:34PM +, Matthias Scheler wrote: > Module Name: src > Committed By: tron > Date: Thu Sep 30 12:41:33 UTC 2010 > > Modified Files: > src/lib/libc/stdlib: setenv.c unsetenv.c > > Log Message: > Be slightly more careful about freeing memory allocated f

Re: CVS commit: src/lib/libc/stdlib

2010-09-30 Thread Matthias Scheler
On Thu, Sep 30, 2010 at 03:35:41PM +0200, Nicolas Joly wrote: > That may be part of the problem (at least for zsh 4.2). > > http://www.opengroup.org/onlinepubs/009695399/functions/putenv.html > > >From the OpenGroup function description; this function does not copy > the provided string, but use

Re: CVS commit: src/lib/libc/stdlib

2010-09-30 Thread Nicolas Joly
On Thu, Sep 30, 2010 at 02:11:19PM +0100, Matthias Scheler wrote: > On Thu, Sep 30, 2010 at 03:05:26PM +0200, Nicolas Joly wrote: > > One possibility could be to not free memory at all in setenv, but only > > with unsetenv. > > I'm not convinced about that. > > > IMHO, it's a programmer error to

Re: CVS commit: src

2010-09-30 Thread Joerg Sonnenberger
For the record, I objected this alternative to my earlier patch because it once again buries the Alpha madness deeply inside MD headers. This is just asking to recreate the problem the next time someone wants to deal with the symbol table hash and there is still no real indication of Alpha being th

Re: CVS commit: src/lib/libc/stdlib

2010-09-30 Thread Matthias Scheler
On Thu, Sep 30, 2010 at 03:05:26PM +0200, Nicolas Joly wrote: > One possibility could be to not free memory at all in setenv, but only > with unsetenv. I'm not convinced about that. > IMHO, it's a programmer error to call setenv more than once on the > same variable without a corresponding unsete