Re: CVS commit: src/sys/dev/pci

2009-09-05 Thread David Young
On Sun, Sep 06, 2009 at 09:42:08AM +0900, Izumi Tsutsui wrote: > > > XXX: should these pmf(9) calls be moved into MI attach functions > > > XXX: using function pointers for suspend and resume passed via softc? > > > > I think that we would add callbacks to many, many softc's, like we did > > with

Re: CVS commit: src/sys/dev/pci

2009-09-05 Thread Izumi Tsutsui
> > XXX: should these pmf(9) calls be moved into MI attach functions > > XXX: using function pointers for suspend and resume passed via softc? > > I think that we would add callbacks to many, many softc's, like we did > with the enable/disable routines. Lots of code would be duplicated. I > am g

Re: CVS commit: src/sys/dev/pci

2009-09-05 Thread David Young
On Sat, Sep 05, 2009 at 02:13:50PM +, Izumi Tsutsui wrote: > Module Name: src > Committed By: tsutsui > Date: Sat Sep 5 14:13:50 UTC 2009 > > Modified Files: > src/sys/dev/pci: if_an_pci.c if_ath_pci.c if_fxp_pci.c if_gem_pci.c > if_rtk_pci.c if_rtw_pci.c if_wi_pci.c

Re: CVS commit: [matt-nb5-mips64] src/sys/conf

2009-09-05 Thread David Laight
On Sat, Sep 05, 2009 at 07:01:51PM +1000, Simon Burge wrote: > matthew green wrote: > > >> I see no reason to make it fatal. > > > >Otherwise we cannot detect errors on release build, > >i.e. no ksym(4) supports. > > > >> It means that when I build a kernel > >> with

Re: CVS commit: [matt-nb5-mips64] src/sys/conf

2009-09-05 Thread Simon Burge
matthew green wrote: >> I see no reason to make it fatal. > >Otherwise we cannot detect errors on release build, >i.e. no ksym(4) supports. > >> It means that when I build a kernel >> with >> DEBUG, my kernel build will fail. That's stupid. > >Then disabl

re: CVS commit: [matt-nb5-mips64] src/sys/conf

2009-09-05 Thread matthew green
> I see no reason to make it fatal. Otherwise we cannot detect errors on release build, i.e. no ksym(4) supports. > It means that when I build a kernel > with > DEBUG, my kernel build will fail. That's stupid. Then disable it only if DEBUG, or keep it only in yo