Re: CVS commit: src/sys/kern

2009-07-27 Thread Andrew Doran
On Mon, Jul 27, 2009 at 06:34:47PM +0200, Marc Balmer wrote: > Am 27.07.2009 um 18:08 schrieb Matthias Drochner: > > > > >lacom...@gmail.com said: > >>Am I the only one to find that attaching a pseudo-device in main() is > >>not the right way to go ? > > > >No. This looks like a case for "defpseu

Re: CVS commit: src/sys/dev/gpio

2009-07-27 Thread Perry E. Metzger
Arnaud Lacombe writes: > On Mon, Jul 27, 2009 at 1:41 PM, Perry E. Metzger wrote: >> And in addition to being less than 24 hours old, the code was his own >> code. The clear de facto rule is that you can change code you wrote and >> own with a lot less approval, even for a new developer, than oth

Re: CVS commit: src/sys/kern

2009-07-27 Thread Matthias Drochner
m.droch...@fz-juelich.de said: > In that function, you can call config_attach_pseudo(9) to attach > the actual instances. See eg sys/dev/vnd.c for an example. Forgot to mention that you need to call config_cfattach_attach() before. sys/dev/md.c is a better example. best regards Matthias ---

Re: CVS commit: src/sys/dev/gpio

2009-07-27 Thread Arnaud Lacombe
On Mon, Jul 27, 2009 at 2:01 PM, Perry E. Metzger wrote: > Eh, if we make it too hard to commit to code under active development, > people won't actively develop. Marc has also shown that he's willing to > make reasonable changes when improvements are pointed out to him. > That's why I _just_ put m

Re: CVS commit: src/sys/dev/gpio

2009-07-27 Thread Arnaud Lacombe
Hi Perry, On Mon, Jul 27, 2009 at 1:41 PM, Perry E. Metzger wrote: > And in addition to being less than 24 hours old, the code was his own > code. The clear de facto rule is that you can change code you wrote and > own with a lot less approval, even for a new developer, than other stuff > requires

Re: CVS commit: src/sys/dev/gpio

2009-07-27 Thread Perry E. Metzger
Arnaud Lacombe writes: > On Sun, Jul 26, 2009 at 5:26 PM, matthew green wrote: >> incidentially, i actually did object to this change on ICB last night >> but i was off to bed and didn't feel like arguing at the time.  i >> didn't expect to see it commited straight away.  so marc's claim that >>

Re: CVS commit: src/sys/kern

2009-07-27 Thread Marc Balmer
Am 27.07.2009 um 18:57 schrieb Matthias Drochner: m...@msys.ch said: yes, please mail me some hints, I find it gross myself, but did not yet find a better way. It is pretty easy: -in files.gpio, change the declaration to defpseudodev gpiosim: gpiobus and remove the "attach" line -in the ker

Re: CVS commit: src/sys/kern

2009-07-27 Thread Matthias Drochner
lacom...@gmail.com said: > config(9) doesn't seem to know anything about 'defpseudodev' config(5) mentions it. (I've written that part. It anyone has suggestions for better wording please tell me.) best regards Matthias -

Re: CVS commit: src/sys/kern

2009-07-27 Thread Matthias Drochner
m...@msys.ch said: > yes, please mail me some hints, I find it gross myself, but did not > yet find a better way. It is pretty easy: -in files.gpio, change the declaration to defpseudodev gpiosim: gpiobus and remove the "attach" line -in the kernel config, change "gpiosim0 at root" (or what you

Re: CVS commit: src/sys/kern

2009-07-27 Thread Marc Balmer
Am 27.07.2009 um 18:36 schrieb Matthias Drochner: lacom...@gmail.com said: config(9) doesn't seem to know anything about 'defpseudodev' config(5) mentions it. (I've written that part. It anyone has suggestions for better wording please tell me.) I'll take care of this issue. If there is

Re: CVS commit: src/sys/kern

2009-07-27 Thread Marc Balmer
Am 27.07.2009 um 18:08 schrieb Matthias Drochner: lacom...@gmail.com said: Am I the only one to find that attaching a pseudo-device in main() is not the right way to go ? No. This looks like a case for "defpseudodev". You'll find a couple of examples in the tree. (Or I can help if necessary

Re: CVS commit: src/sys/kern

2009-07-27 Thread Arnaud Lacombe
On Mon, Jul 27, 2009 at 12:08 PM, Matthias Drochner wrote: > lacom...@gmail.com said: >> Am I the only one to find that attaching a pseudo-device in main() is >> not the right way to go ? > > No. This looks like a case for "defpseudodev". You'll find a couple > of examples in the tree. (Or I can he

Re: CVS commit: src/sys/kern

2009-07-27 Thread Matthias Drochner
lacom...@gmail.com said: > Am I the only one to find that attaching a pseudo-device in main() is > not the right way to go ? No. This looks like a case for "defpseudodev". You'll find a couple of examples in the tree. (Or I can help if necessary.) best regards Matthias ---

Re: CVS commit: src/sys/kern

2009-07-27 Thread Arnaud Lacombe
Hi all, On Sat, Jul 25, 2009 at 12:23 PM, Marc Balmer wrote: > Module Name:    src > Committed By:   mbalmer > Date:           Sat Jul 25 16:23:39 UTC 2009 > > Modified Files: >        src/sys/kern: init_main.c > > Log Message: > Allow gpiosim(4) to attach if configured in the kernel configuration

Re: CVS commit: src

2009-07-27 Thread KIYOHARA Takashi
Hi! Tom, From: Tom Spindler Date: Mon, 27 Jul 2009 07:54:53 -0700 > Is this missing a change to files.pci? pgoyette et al say this occurs: > > /src/src/sys/arch/i386/conf/GENERIC:801: `mvsata' cannot attach to `pci' Fixed ;-) -- kiyohara

Re: CVS commit: src

2009-07-27 Thread Tom Spindler
Is this missing a change to files.pci? pgoyette et al say this occurs: /src/src/sys/arch/i386/conf/GENERIC:801: `mvsata' cannot attach to `pci'