Module Name:src
Committed By: maxv
Date: Sun Oct 19 17:33:59 UTC 2014
Modified Files:
src/sys/compat/linux/common: linux_uselib.c
Log Message:
Resource leak.
Found by my code scanner.
Tested by njoly@; ok njoly@ rmind@ on tech-kern@.
To generate a diff of this commit:
Module Name:src
Committed By: maxv
Date: Mon Oct 20 06:41:52 UTC 2014
Modified Files:
src/sys/ufs/chfs: chfs_vfsops.c
Log Message:
Memory leak.
Found by my code scanner.
ok christos@
To generate a diff of this commit:
cvs rdiff -u -r1.11 -r1.12 src/sys/ufs/chfs/chfs_vf
Module Name:src
Committed By: maxv
Date: Mon Oct 20 06:56:38 UTC 2014
Modified Files:
src/sys/compat/common: vfs_syscalls_30.c
Log Message:
Memory leak, triggerable from root only.
Found by my code scanner.
ok christos@
To generate a diff of this commit:
cvs rdiff -u -
Module Name:src
Committed By: maxv
Date: Mon Oct 20 08:20:08 UTC 2014
Modified Files:
src/sys/kern: kern_prot.c
Log Message:
The userland namelen is size_t, but the kernel holds it in an int. The
sizeof(login) test implicitly interprets 'namelen' as unsigned, which
means t
Module Name:src
Committed By: maxv
Date: Thu Oct 30 16:45:28 UTC 2014
Modified Files:
src/sys/compat/linux/common: linux_uselib.c
Log Message:
Reject non-regular files.
Patch from njoly@.
To generate a diff of this commit:
cvs rdiff -u -r1.31 -r1.32 src/sys/compat/linux
Module Name:src
Committed By: maxv
Date: Thu Oct 30 17:13:41 UTC 2014
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
Limit the superblock size to SBLOCKSIZE, not MAXBSIZE. Otherwise memcpy
will read beyond the allocated buffer.
Discussed a bit on tech-kern@.
Module Name:src
Committed By: maxv
Date: Tue Nov 4 16:01:58 UTC 2014
Modified Files:
src/sys/secmodel: secmodel.c
Log Message:
Do not release secmodels_lock when it is not held.
Sent on tech-kern@, ok lars@
To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 sr
Module Name:src
Committed By: maxv
Date: Sun Nov 9 17:48:08 UTC 2014
Modified Files:
src/sys/compat/common: compat_util.c if_43.c kern_time_50.c
uipc_syscalls_43.c
src/sys/compat/linux/arch/alpha: linux_machdep.c linux_pipe.c
src/sys/compat/linu
Module Name:src
Committed By: maxv
Date: Sun Nov 9 17:50:02 UTC 2014
Modified Files:
src/sys/kern: kern_exec.c
Log Message:
Do not uselessly include .
To generate a diff of this commit:
cvs rdiff -u -r1.409 -r1.410 src/sys/kern/kern_exec.c
Please note that diffs are no
Module Name:src
Committed By: maxv
Date: Sun Nov 9 18:08:07 UTC 2014
Modified Files:
src/sys/miscfs/fdesc: fdesc_vfsops.c
src/sys/miscfs/genfs: layer_subr.c layer_vfsops.c
src/sys/miscfs/nullfs: null_vfsops.c
src/sys/miscfs/umapfs: umap_subr.c umap_
Module Name:src
Committed By: maxv
Date: Sun Nov 9 18:16:55 UTC 2014
Modified Files:
src/sys/compat/svr4: svr4_exec_elf32.c svr4_exec_elf64.c svr4_fcntl.c
svr4_filio.c svr4_ioctl.c svr4_ipc.c svr4_schedctl.c svr4_signal.c
svr4_sockio.c svr4_termios.
Module Name:src
Committed By: maxv
Date: Sun Nov 9 18:23:28 UTC 2014
Modified Files:
src/sys/ufs/chfs: chfs_vfsops.c chfs_vnode.c
src/sys/ufs/ext2fs: ext2fs_readwrite.c ext2fs_vfsops.c ext2fs_vnops.c
Log Message:
Do not uselessly include .
To generate a diff of
Module Name:src
Committed By: maxv
Date: Sun Nov 9 18:30:39 UTC 2014
Modified Files:
src/sys/compat/freebsd: freebsd_exec_elf32.c freebsd_file.c
freebsd_ipc.c freebsd_misc.c
Log Message:
Do not uselessly include .
To generate a diff of this commit:
cvs rdiff
Module Name:src
Committed By: maxv
Date: Mon Nov 10 18:46:34 UTC 2014
Modified Files:
src/sys/fs/cd9660: cd9660_node.c cd9660_util.c
src/sys/fs/puffs: puffs_compat.c puffs_msgif.c puffs_node.c
puffs_subr.c puffs_vfsops.c
src/sys/fs/udf: udf_renam
Module Name:src
Committed By: maxv
Date: Mon Nov 10 18:52:51 UTC 2014
Modified Files:
src/sys/netinet: if_atm.c in_pcb.c raw_ip.c tcp_output.c tcp_sack.c
tcp_subr.c tcp_timer.c tcp_usrreq.c tcp_vtw.c
Log Message:
Do not uselessly include .
To generate a diff
Module Name:src
Committed By: maxv
Date: Fri Nov 14 17:34:23 UTC 2014
Modified Files:
src/sys/netinet6: dest6.c in6_ifattach.c in6_pcb.c ip6_forward.c
udp6_output.c
Log Message:
Do not uselessly include .
To generate a diff of this commit:
cvs rdiff -u -r1.17
Module Name:src
Committed By: maxv
Date: Fri Dec 5 17:26:21 UTC 2014
Modified Files:
src/sys/compat/netbsd32: netbsd32_compat_30.c
Log Message:
User-triggerable kmem_alloc(0).
Ok martin@ christos@
User
To generate a diff of this commit:
cvs rdiff -u -r1.30 -r1.31 src/
Module Name:src
Committed By: maxv
Date: Sat Dec 27 19:32:57 UTC 2014
Modified Files:
src/share/man/man9: Makefile malloc.9
src/sys/sys: malloc.h mallocvar.h
Log Message:
Cleanup:
- remove struct kmembuckets (dead)
- correctly deadify MALLOC_XX
- remove MALLOC_D
Module Name:src
Committed By: maxv
Date: Sun Dec 28 12:13:22 UTC 2014
Modified Files:
src/sys/fs/ntfs: ntfs_vfsops.c
Log Message:
Make this more readable (KNF).
To generate a diff of this commit:
cvs rdiff -u -r1.97 -r1.98 src/sys/fs/ntfs/ntfs_vfsops.c
Please note that
Module Name:src
Committed By: maxv
Date: Sun Dec 28 12:19:21 UTC 2014
Modified Files:
src/sys/fs/ntfs: ntfs.h
Log Message:
Two typos:
- reserver4 -> reserved4 (in struct bootfile)
- "inducates" -> "indicates" (comment)
To generate a diff of this commit:
cvs rdiff -u -r
Module Name:src
Committed By: maxv
Date: Sun Dec 28 12:57:44 UTC 2014
Modified Files:
src/sys/fs/ntfs: ntfs_vfsops.c
Log Message:
Ensure bps != 0 to prevent a division by zero. Zero byte per sector makes
no sense.
To generate a diff of this commit:
cvs rdiff -u -r1.98 -r
Module Name:src
Committed By: maxv
Date: Sun Dec 28 13:11:52 UTC 2014
Modified Files:
src/sys/fs/ntfs: ntfs_vfsops.c
Log Message:
Prevent another division by zero in ntfs_loadntnode() by ensuring
spc != 0.
To generate a diff of this commit:
cvs rdiff -u -r1.99 -r1.100 sr
Module Name:src
Committed By: maxv
Date: Sun Dec 28 14:42:56 UTC 2014
Modified Files:
src/sys/fs/ntfs: ntfs_subr.c
Log Message:
Make this more readable (KNF).
To generate a diff of this commit:
cvs rdiff -u -r1.54 -r1.55 src/sys/fs/ntfs/ntfs_subr.c
Please note that diff
Module Name:src
Committed By: maxv
Date: Mon Dec 29 16:37:27 UTC 2014
Modified Files:
src/sys/fs/ntfs: ntfs_subr.c
Log Message:
Typos:
- "nessesary" -> "necessary" (comment)
- "UNEXISTED" -> "NON-EXISTENT" (dprintf)
- "NON-EXISTANT" -> "NON-EXISTENT" (dprintf)
- "reach
Module Name:src
Committed By: maxv
Date: Mon Dec 29 17:02:39 UTC 2014
Modified Files:
src/sys/fs/hfs: libhfs.c
Log Message:
I started to KNF this file but quickly ended up figuring out I was not
courageous enough for such ugliness. So I only KNF'ed the first 300
lines.
I'
Module Name:src
Committed By: maxv
Date: Mon Dec 29 17:17:54 UTC 2014
Modified Files:
src/sys/fs/hfs: hfs_vfsops.c
Log Message:
Small cleanup:
- KNF
- malloc + memset -> malloc(|M_ZERO)
- no need to check data == NULL
To generate a diff of this commit:
cvs rdiff -u -r
Module Name:src
Committed By: maxv
Date: Fri Jan 16 17:02:13 UTC 2015
Modified Files:
src/sys/fs/ntfs: ntfs_subr.c
Log Message:
Fix a node leak.
Sent on tech-kern@, tested by martin@
To generate a diff of this commit:
cvs rdiff -u -r1.58 -r1.59 src/sys/fs/ntfs/ntfs_subr
Module Name:src
Committed By: maxv
Date: Fri Feb 6 18:19:22 UTC 2015
Modified Files:
src/sys/kern: kern_malloc.c
src/sys/rump/librump/rumpkern: rump.c
src/sys/uvm: uvm_extern.h uvm_km.c
Log Message:
Kill kmeminit().
To generate a diff of this commit:
cvs
Module Name:src
Committed By: maxv
Date: Fri Feb 6 18:21:29 UTC 2015
Modified Files:
src/sys/kern: kern_malloc.c
Log Message:
Don't include
To generate a diff of this commit:
cvs rdiff -u -r1.144 -r1.145 src/sys/kern/kern_malloc.c
Please note that diffs are not public
Module Name:src
Committed By: maxv
Date: Sat Feb 7 10:40:57 UTC 2015
Modified Files:
src/sys/fs/nilfs: nilfs_vfsops.c
Log Message:
Revert previous, it was a false positive.
In nilfs_mount_device() there's one branch where the node is not released:
when the device is alre
Module Name:src
Committed By: maxv
Date: Fri Feb 13 13:26:50 UTC 2015
Modified Files:
src/sys/kern: kern_pmf.c
Log Message:
Remove this MALLOC_DEFINE (M_PMF unused).
To generate a diff of this commit:
cvs rdiff -u -r1.36 -r1.37 src/sys/kern/kern_pmf.c
Please note that d
Module Name:src
Committed By: maxv
Date: Fri Feb 13 15:28:56 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
Make this a bit more readable. No functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.305 -r1.306 src/sys/ufs/ffs/ffs_vfsop
Module Name:src
Committed By: maxv
Date: Fri Feb 13 15:52:29 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
Add a new function: ffs_superblock_validate(). And add a new check to
ensure fs_size!=0; otherwise the kernel panics with a division by zero.
Module Name:src
Committed By: maxv
Date: Fri Feb 13 16:59:53 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
Add some checks in ffs_superblock_validate():
- fs_bsize < MINBSIZE
- !powerof2(fs_bsize)
- !powerof2(fs->fs_fsize)
- fs_bsize < fs->fs_fsiz
Module Name:src
Committed By: maxv
Date: Fri Feb 13 17:13:20 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
ffs_superblock_validate(): ensure fs->fs_cssize!=0, otherwise the kernel
panics with kmem_alloc(0).
To generate a diff of this commit:
cvs rdi
Module Name:src
Committed By: maxv
Date: Fri Feb 13 17:50:48 UTC 2015
Modified Files:
src/share/man/man9: veriexec.9
src/sys/conf: files
Added Files:
src/sys/kern: kern_veriexec.c
Log Message:
Rename kern_verifiedexec.c to kern_veriexec.c. "Veriexec" is the
Module Name:src
Committed By: maxv
Date: Fri Feb 13 17:55:24 UTC 2015
Removed Files:
src/sys/kern: kern_verifiedexec.c
Log Message:
... and I forgot to actually remove kern_verifiedexec.c.
As I said in the first revision of kern_veriexec.c: rename
kern_verifiedexec.c to k
Module Name:src
Committed By: maxv
Date: Sat Feb 14 07:11:34 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
ffs_reload(): call ffs_superblock_validate() with the new superblock.
To generate a diff of this commit:
cvs rdiff -u -r1.309 -r1.310 src/sys/
Module Name:src
Committed By: maxv
Date: Sat Feb 14 07:20:11 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
Style. No functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.310 -r1.311 src/sys/ufs/ffs/ffs_vfsops.c
Please note that di
Module Name:src
Committed By: maxv
Date: Sat Feb 14 07:41:40 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
Currently, in ffs_reload(), we don't handle the possibility that the
superblock location may have changed. But that implies that we don't
handle
Module Name:src
Committed By: maxv
Date: Sat Feb 14 07:56:31 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_appleufs.c
Log Message:
KNF. No functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.12 -r1.13 src/sys/ufs/ffs/ffs_appleufs.c
Please note that di
Module Name:src
Committed By: maxv
Date: Sat Feb 14 08:07:39 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_appleufs.c
Log Message:
ffs_appleufs_validate():
- remove superfluous printfs
- ensure ul_namelen!=0, otherwise the kernel accesses ul_name[-1] and
overwrites th
Module Name:src
Committed By: maxv
Date: Sat Feb 14 09:00:12 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
ffs_superblock_validate(): sanitize the number of frag blocks.
To generate a diff of this commit:
cvs rdiff -u -r1.312 -r1.313 src/sys/ufs/ffs
Module Name:src
Committed By: maxv
Date: Sat Feb 14 09:06:11 UTC 2015
Modified Files:
src/sys/ufs/ffs: fs.h
Log Message:
Two typos:
- "preferrably" -> "preferably"
- "overriden" -> "overridden"
No functional change.
To generate a diff of this commit:
cvs rdiff -u -r1.6
Module Name:src
Committed By: maxv
Date: Sat Feb 14 09:55:53 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
In fact, we need to sanitize the superblock *after* swapping it. Therefore,
move the swap code inside the loop.
'fs->fs_sbsize' is swapped twic
Module Name:src
Committed By: maxv
Date: Sat Feb 14 10:21:29 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
ffs_superblock_validate(): compute fs_bshift and fs_fshift, and ensure
they are consistent with what is indicated in the superblock. This allows
Module Name:src
Committed By: maxv
Date: Sat Feb 14 13:43:28 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
ffs_superblock_validate(): when checking the number of frag blocks, also
make sure it matches fs->fs_frag. This also prevents an infinite loop i
Module Name:src
Committed By: maxv
Date: Sun Feb 15 11:04:44 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_appleufs.c
Log Message:
Revert a change in my previous commit that broke the checksum calculation.
Noted by dholland@
To generate a diff of this commit:
cvs rdiff -
Module Name:src
Committed By: maxv
Date: Thu Feb 19 21:31:45 UTC 2015
Modified Files:
src/sys/ufs/ext2fs: ext2fs_vfsops.c
Log Message:
e2fs_sbcheck(): add a check to ensure e2fs_bpg!=0. Otherwise the kernel
panics with a division by zero.
While here, remove the #ifdef's.
Module Name:src
Committed By: maxv
Date: Fri Feb 20 17:08:13 UTC 2015
Modified Files:
src/sys/fs/ntfs: ntfs_compr.c ntfs_conv.c ntfs_ihash.c ntfs_subr.c
ntfs_vfsops.c
Log Message:
Cosmetic changes:
- add a ffs-like ntfs_superblock_validate function
- remove u
Module Name:src
Committed By: maxv
Date: Fri Feb 20 17:10:17 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
Style, and fix a DPRINTF
No functional change
To generate a diff of this commit:
cvs rdiff -u -r1.316 -r1.317 src/sys/ufs/ffs/ffs_vfsops.c
P
Module Name:src
Committed By: maxv
Date: Fri Feb 20 17:44:54 UTC 2015
Modified Files:
src/sys/ufs/ext2fs: ext2fs_vfsops.c
Log Message:
Several fixes:
- rename ext2fs_checksb() -> ext2fs_sbcheck(): more consistent
- in ext2fs_sbcheck(), add a check to ensure e2fs_inode_si
Module Name:src
Committed By: maxv
Date: Sun Feb 22 14:12:48 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_quota2.c
Log Message:
KNF, and simplify a bit.
No functional change
To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/sys/ufs/ffs/ffs_quota2.c
Pleas
Module Name:src
Committed By: maxv
Date: Sun Feb 22 14:22:34 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
ffs_superblock_validate(): sanitize fs_fragshift, fs_bmask and fs_fmask.
To generate a diff of this commit:
cvs rdiff -u -r1.317 -r1.318 src/s
Module Name:src
Committed By: maxv
Date: Sun Feb 22 14:55:23 UTC 2015
Modified Files:
src/sys/ufs/ext2fs: ext2fs_vfsops.c
Log Message:
Merge _sbcompute() and _sbcheck() into _sbfill().
In ext2fs_sbfill(), check more fields of the superblock, to prevent
several kernel pani
Module Name:src
Committed By: maxv
Date: Mon Feb 23 13:38:54 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
Small changes:
- instead of always calling DPRINTF with __func__, put __func__ directly
in the macro
- ffs_mountfs(): rename fsblockloc ->
Module Name:src
Committed By: maxv
Date: Mon Feb 23 17:05:59 UTC 2015
Modified Files:
src/sys/ufs/ext2fs: ext2fs_vfsops.c
Log Message:
Hum. Perhaps I missed a bit of the specification. Let's not be that
severe when checking the superblock.
Should fix ATF.
To generate a
Module Name:src
Committed By: maxv
Date: Tue Mar 3 17:46:39 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
ffs_reload(): the current implementation blindly guesses critical fields
of the superblock didn't change. Add checks to ensure they didn't chang
Module Name:src
Committed By: maxv
Date: Tue Mar 3 17:56:51 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
ffs_reload(): release 'bp' earlier
To generate a diff of this commit:
cvs rdiff -u -r1.320 -r1.321 src/sys/ufs/ffs/ffs_vfsops.c
Please note t
Module Name:src
Committed By: maxv
Date: Fri Mar 6 19:03:30 UTC 2015
Modified Files:
src/sys/nfs: krpc_subr.c
Log Message:
Fix uninitialized variable.
Found by The Brainy Code Scanner in FreeBSD.
To generate a diff of this commit:
cvs rdiff -u -r1.37 -r1.38 src/sys/nfs
Module Name:src
Committed By: maxv
Date: Tue Mar 10 12:59:32 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
ffs_superblock_validate(): check the number of inodes per block. Otherwise
a malformed value could panic the system.
To generate a diff of thi
Module Name:src
Committed By: maxv
Date: Sat Mar 14 19:52:54 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
ffs_superblock_validate(): ensure fs_ipg and fs_fpg are != 0. Otherwise
division by zero in several places.
To generate a diff of this commit:
Module Name:src
Committed By: maxv
Date: Sun Mar 15 09:21:01 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
ffs_reload(): fix a bug that prevents Big Endian FSes from being reloaded.
'newfs' should be tagged as FS_SWAPPED, not 'fs'.
Was here before my
Module Name:src
Committed By: maxv
Date: Fri Mar 20 20:36:28 UTC 2015
Modified Files:
src/sys/compat/linux/common: linux_exec_elf32.c
src/sys/compat/linux32/common: linux32_exec_elf32.c
src/sys/compat/netbsd32: netbsd32_exec_elf32.c
src/sys/compat/sv
Module Name:src
Committed By: maxv
Date: Sat Mar 28 16:55:21 UTC 2015
Modified Files:
src/sys/kern: vfs_bio.c
Log Message:
Remove the 'cred' argument from bio_doread().
To generate a diff of this commit:
cvs rdiff -u -r1.252 -r1.253 src/sys/kern/vfs_bio.c
Please note th
Module Name:src
Committed By: maxv
Date: Sat Mar 28 17:23:43 UTC 2015
Modified Files:
src/share/man/man9: buffercache.9
src/sys/fs/cd9660: cd9660_vnops.c
src/sys/kern: vfs_bio.c
src/sys/sys: buf.h
src/sys/ufs/chfs: chfs_vnops.c
src/sy
Module Name:src
Committed By: maxv
Date: Sat Mar 28 19:24:06 UTC 2015
Modified Files:
src/share/man/man9: buffercache.9
src/sys/fs/adosfs: advfsops.c advnops.c
src/sys/fs/cd9660: cd9660_lookup.c cd9660_rrip.c cd9660_vfsops.c
cd9660_vnops.c
Module Name:src
Committed By: maxv
Date: Sat Mar 28 19:29:16 UTC 2015
Modified Files:
src/sys/sys: param.h
Log Message:
7.99.8 (bread, breadn)
To generate a diff of this commit:
cvs rdiff -u -r1.467 -r1.468 src/sys/sys/param.h
Please note that diffs are not public domai
Module Name:src
Committed By: maxv
Date: Sat Apr 4 06:00:12 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
ffs_superblock_validate(): ensure fs_ncg!=0 and fs_maxbpg!=0 to prevent
several divisions by zero.
To generate a diff of this commit:
cvs rdif
Module Name:src
Committed By: maxv
Date: Sun Apr 19 16:14:04 UTC 2015
Modified Files:
src/usr.sbin/sysinst: msg.mbr.fr msg.mi.fr
Log Message:
Several fixes for the French translation. Looks like the '{\n' break the
interface: the "No" buttons sometimes disappear.
Actually
Module Name:src
Committed By: maxv
Date: Mon Apr 20 14:10:31 UTC 2015
Modified Files:
src/usr.sbin/sysinst: msg.mbr.fr msg.mi.fr
Log Message:
Fix the French translation.
To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/usr.sbin/sysinst/msg.mbr.fr
cvs rdiff
Module Name:src
Committed By: maxv
Date: Wed Apr 22 07:27:09 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
Instead of duplicating code, create ffs_is_appleufs(): returns 1 if the
device is an AppleUFS FS, 0 otherwise.
This changes the behavior a bit:
Module Name:src
Committed By: maxv
Date: Sat Apr 25 08:19:06 UTC 2015
Modified Files:
src/sys/kern: kern_veriexec.c
Log Message:
KNF
To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/sys/kern/kern_veriexec.c
Please note that diffs are not public domain; th
Module Name:src
Committed By: maxv
Date: Sat Apr 25 09:08:51 UTC 2015
Modified Files:
src/sys/kern: kern_veriexec.c
Log Message:
Don't mix veriexec lock and file lock in veriexec_file_verify().
Now:
- 'veriexec_op_lock' needs to be held when calling veriexec_file_verify(
Module Name:src
Committed By: maxv
Date: Sat Apr 25 18:43:13 UTC 2015
Modified Files:
src/sys/kern: kern_veriexec.c
Log Message:
Instead of duplicating code, add veriexec_fp_status(). Also reorder a
useless goto.
To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.
Module Name:src
Committed By: maxv
Date: Sat Apr 25 19:10:29 UTC 2015
Modified Files:
src/sys/kern: kern_veriexec.c
Log Message:
Make veriexec_renamechk() more readable. Also add a KASSERT on vte_count.
No real functional change
To generate a diff of this commit:
cvs rd
Module Name:src
Committed By: maxv
Date: Sun Apr 26 06:19:36 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
ffs_superblock_validate(): check the size of cylinder groups.
To generate a diff of this commit:
cvs rdiff -u -r1.329 -r1.330 src/sys/ufs/ffs/
Module Name:src
Committed By: maxv
Date: Sun Apr 26 09:16:06 UTC 2015
Modified Files:
src/sys/kern: kern_veriexec.c
Log Message:
If we already have an entry for the file being loaded, return EEXIST, don't
silently skip it.
To generate a diff of this commit:
cvs rdiff -u
Module Name:src
Committed By: maxv
Date: Sun Apr 26 09:20:10 UTC 2015
Modified Files:
src/sbin/veriexecctl: veriexecctl.c
Log Message:
Be a bit more verbose if the kernel rejects a file
To generate a diff of this commit:
cvs rdiff -u -r1.37 -r1.38 src/sbin/veriexecctl/ve
Module Name:src
Committed By: maxv
Date: Sun Apr 26 09:38:01 UTC 2015
Modified Files:
src/sys/dev: verified_exec.c
Log Message:
KNF
To generate a diff of this commit:
cvs rdiff -u -r1.69 -r1.70 src/sys/dev/verified_exec.c
Please note that diffs are not public domain; th
Module Name:src
Committed By: maxv
Date: Sun Apr 26 09:45:40 UTC 2015
Modified Files:
src/sys/dev: verified_exec.c
Log Message:
Not to add even more confusion in an already overcomplicated subsystem,
remove the FreeBSD code. This code is likely to be outdated, and Veriexec
Module Name:src
Committed By: maxv
Date: Mon Apr 27 09:17:31 UTC 2015
Modified Files:
src/sys/kern: kern_veriexec.c
Log Message:
Remove FreeBSD.
ok elad@
To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/sys/kern/kern_veriexec.c
Please note that diffs are
Module Name:src
Committed By: maxv
Date: Mon Apr 27 09:19:58 UTC 2015
Modified Files:
src/sys/kern: exec_elf.c
Log Message:
Remove #ifdef notyet.
To generate a diff of this commit:
cvs rdiff -u -r1.71 -r1.72 src/sys/kern/exec_elf.c
Please note that diffs are not public
Module Name:src
Committed By: maxv
Date: Thu May 14 07:27:14 UTC 2015
Modified Files:
src/sys/dev/pci: hifn7751.c
Log Message:
Use-after-free. Found by Brainy.
ok christos@
To generate a diff of this commit:
cvs rdiff -u -r1.60 -r1.61 src/sys/dev/pci/hifn7751.c
Please
Module Name:src
Committed By: maxv
Date: Sat May 23 16:59:13 UTC 2015
Modified Files:
src/sys/ufs/ffs: ffs_vfsops.c
Log Message:
Add a missing goto.
(was here before my changes)
ok christos@
To generate a diff of this commit:
cvs rdiff -u -r1.333 -r1.334 src/sys/ufs/ff
Module Name:src
Committed By: maxv
Date: Sat May 23 17:05:03 UTC 2015
Modified Files:
src/share/man/man9: malloc.9
Log Message:
Remove the DIAGNOSTIC section, and two references to MALLOC and FREE.
To generate a diff of this commit:
cvs rdiff -u -r1.51 -r1.52 src/share/m
Module Name:src
Committed By: maxv
Date: Sat May 23 18:13:31 UTC 2015
Modified Files:
src/sys/arch/i386/conf: GENERIC XEN3_DOM0 XEN3_DOMU
Log Message:
Disable COMPAT_FREEBSD. The implementation is poor, not well tested and
almost irrelevant. People who need it (for tw_cli
Module Name:src
Committed By: maxv
Date: Thu Feb 27 09:58:05 UTC 2014
Modified Files:
src/sys/kern: exec_elf.c
Log Message:
We have to ensure the string is NUL-terminated and of the expected
length to avoid copying uninitialized data.
ok christos@
To generate a diff of
Module Name:src
Committed By: maxv
Date: Sat Mar 1 16:46:14 UTC 2014
Modified Files:
src/sys/netinet: tcp_input.c
Log Message:
';;' -> ';'
no functional change
spotted by my code scanner
ok christos@
To generate a diff of this commit:
cvs rdiff -u -r1.330 -r1.331 src
Module Name:src
Committed By: maxv
Date: Sat Mar 1 16:59:42 UTC 2014
Modified Files:
src/sys/dev/acpi: tpm_acpi.c
Log Message:
Some {} are missing. The behavior is thus wrong: the code always jumps to
out1.
Spotted by my code scanner.
ok christos@
To generate a diff o
Module Name:src
Committed By: maxv
Date: Thu Mar 6 19:46:28 UTC 2014
Modified Files:
src/sys/arch/arm/ep93xx: epclk.c
Log Message:
Fix uninitialized variable. Found by my code scanner.
ok christos@
To generate a diff of this commit:
cvs rdiff -u -r1.20 -r1.21 src/sys/a
Module Name:src
Committed By: maxv
Date: Sun Mar 16 07:57:25 UTC 2014
Modified Files:
src/sys/kern: exec_elf.c
Log Message:
Remove the 'prot' argument from elf_load_psection(). It is not used
outside, and can be declared locally. Clearer.
ok christos@
To generate a diff
Module Name:src
Committed By: maxv
Date: Sat Mar 22 07:27:22 UTC 2014
Modified Files:
src/sys/kern: exec_elf.c
Log Message:
Small changes:
- rename elf_load_file() to elf_load_interp()
- use the correct type for 'nused'
- remove useless cases
- reorder a kmem_alloc
ok
Module Name:src
Committed By: maxv
Date: Sat Mar 22 07:46:35 UTC 2014
Modified Files:
src/sys/net: route.c
Log Message:
'newrt' is not supposed to be NULL. Therefore, the NULL-check in the if()
is pointless; and even if 'newrt' were NULL, 'rt' would be dereferenced
later.
Module Name:src
Committed By: maxv
Date: Sat Mar 22 08:15:25 UTC 2014
Modified Files:
src/sys/compat/netbsd32: netbsd32_netbsd.c
src/sys/kern: vfs_syscalls.c
Log Message:
Fix a potential - but very unlikely - NULL pointer dereference.
(it does not introduce a new e
Module Name:src
Committed By: maxv
Date: Sat Mar 29 09:31:12 UTC 2014
Modified Files:
src/sys/kern: exec_subr.c
Log Message:
Style
To generate a diff of this commit:
cvs rdiff -u -r1.70 -r1.71 src/sys/kern/exec_subr.c
Please note that diffs are not public domain; they a
Module Name:src
Committed By: maxv
Date: Fri Apr 4 06:47:02 UTC 2014
Modified Files:
src/sys/kern: vfs_syscalls.c
Log Message:
Limit check for 'data_len'. Otherwise a (un)privileged user can easily
panic the system by passing a huge size.
ok christos@
To generate a dif
Module Name:src
Committed By: maxv
Date: Wed Apr 9 11:40:03 UTC 2014
Modified Files:
src/sys/compat/svr4_32: svr4_32_exec_elf32.c
Log Message:
'error' is not set on failure. Which means that if copyout() fails, 0
will be returned while the stack is not ready. This is a bu
Module Name:src
Committed By: maxv
Date: Tue Apr 15 06:14:55 UTC 2014
Modified Files:
src/sys/kern: kern_verifiedexec.c
Log Message:
There's no need for this NULL-check.
To generate a diff of this commit:
cvs rdiff -u -r1.133 -r1.134 src/sys/kern/kern_verifiedexec.c
Ple
Module Name:src
Committed By: maxv
Date: Tue Apr 15 17:29:00 UTC 2014
Modified Files:
src/sys/compat/linux/common: linux_exec_elf32.c
Log Message:
A specially-crafted binary could easily control a kernel array index.
Add some checks to ensure that nothing will be read outs
1 - 100 of 2527 matches
Mail list logo
