CVS commit: src/sys/kern

2018-05-28 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Mon May 28 11:32:20 UTC 2018 Modified Files: src/sys/kern: kern_exec.c Log Message: Correct reporting SIGTRAP TRAP_EXEC when SIGTRAP is masked Switch from kpsignal(9) to sigswitch() as it allows to bypass signal masking rules of a

CVS commit: src/tests/lib/libc/sys

2018-05-28 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Mon May 28 11:35:50 UTC 2018 Modified Files: src/tests/lib/libc/sys: t_ptrace_wait.c Log Message: Correct the t_ptrace_wait*:signal5 ATF test case This functionality now works. Correct the code path in this test. Add additional sa

CVS commit: src/sys/kern

2018-05-28 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Mon May 28 13:12:54 UTC 2018 Modified Files: src/sys/kern: kern_sig.c Log Message: Enhance the signal routing of a trapsignal under a debugger Stop resetting signal masks for crash signals under a debugger. If we set a trap (eith

CVS commit: src/sys/kern

2018-05-28 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Mon May 28 14:07:37 UTC 2018 Modified Files: src/sys/kern: kern_sig.c Log Message: Revert previous There is a regression not covered by tests. To generate a diff of this commit: cvs rdiff -u -r1.348 -r1.349 src/sys/kern/kern_sig

CVS commit: src/usr.bin/cal

2018-05-28 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue May 29 06:07:26 UTC 2018 Modified Files: src/usr.bin/cal: cal.1 Log Message: After Todd C. Miller[0] - cal(1) first appeared in Version 1 AT&T UNIX[1][2]. [0] http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/cal/cal.1?rev

CVS commit: src/tests/lib/libc/sys

2018-05-29 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue May 29 10:40:54 UTC 2018 Modified Files: src/tests/lib/libc/sys: t_ptrace_wait.c Log Message: Add new ATF ptrace(2) tests verifying crash signal handling Add new tests: - traceme_crash_trap - traceme_crash_segv - traceme_cr

CVS commit: src/sys/modules/examples

2018-05-29 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue May 29 16:53:56 UTC 2018 Modified Files: src/sys/modules/examples: Makefile README Added Files: src/sys/modules/examples/panic_string: Makefile panic_string.c Log Message: Introduce new example kernel module: panic_stri

CVS commit: src/sys/kern

2018-05-29 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue May 29 23:34:18 UTC 2018 Modified Files: src/sys/kern: sys_ptrace_common.c Log Message: Harden PT_ATTACH in ptrace(2) Don't allow to PT_ATTACH from a vfork(2)ed child (before exec(3)/_exit(3)) to its parent. Return error with

CVS commit: src/tests

2018-05-30 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed May 30 17:31:34 UTC 2018 Modified Files: src/tests/kernel: h_segv.c src/tests/lib/libc/sys: t_ptrace_wait.h Log Message: Make the trigger_bus() test compatible with more CPUs (at least ALPHA) If we write a byte charact

CVS commit: src/tests

2018-05-30 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed May 30 17:48:13 UTC 2018 Modified Files: src/tests/kernel: h_segv.c src/tests/lib/libc/sys: t_ptrace_wait.h Log Message: Add a comment for the workaround in trigger_bus() Explain PROT_READ|PROT_WRITE. To generate a d

CVS commit: src/sys/kern

2018-05-30 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed May 30 23:54:03 UTC 2018 Modified Files: src/sys/kern: sys_ptrace_common.c Log Message: Simplify comparison of two processes No need to check p_pid to compare whether two processes are the same. No functional change intended.

CVS commit: src/distrib/sets/lists/man

2018-05-30 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu May 31 00:25:38 UTC 2018 Modified Files: src/distrib/sets/lists/man: mi Log Message: Fix build with MKCATPAGES=yes zpool-features.8 -> zpool-features.0 To generate a diff of this commit: cvs rdiff -u -r1.1592 -r1.1593 src/di

CVS commit: src/external/bsd/top/dist

2018-05-31 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu May 31 09:20:05 UTC 2018 Modified Files: src/external/bsd/top/dist: top.c Log Message: Fix unitialized signal mask passed to sigaction(2) in top(1) Detected with Memory Sanitizer during the integration of sanitizers with the N

CVS commit: src/external/bsd/top/dist/machine

2018-05-31 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu May 31 10:14:21 UTC 2018 Modified Files: src/external/bsd/top/dist/machine: m_netbsd.c Log Message: Fix read of unitialized array elements in top(1) The cp_old array is allocated with malloc(3) and its pointer is passed to per

CVS commit: src/bin/ksh

2018-06-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Jun 3 12:18:29 UTC 2018 Modified Files: src/bin/ksh: c_ksh.c edit.c exec.c proto.h table.c table.h Log Message: ksh: Remove symbol clash with libc Rename local function twalk() to ksh_twak(). This is needed for installing int

CVS commit: src/usr.bin/ktruss

2018-06-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Jun 3 13:41:30 UTC 2018 Modified Files: src/usr.bin/ktruss: dump.c Log Message: ktruss: Remove symbol clash with libc Rename local function wprintf() to xwprintf(). This is needed for installing interceptors in sanitizers. S

CVS commit: src/bin/ksh

2018-06-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Jun 3 16:09:31 UTC 2018 Modified Files: src/bin/ksh: eval.c Log Message: ksh: Remove symbol clash with libc Rename local function glob() to ksh_glob(). This is needed for installing interceptors in sanitizers. Sponsored by

CVS commit: src/external/bsd/libc++/lib

2018-06-06 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 6 12:02:43 UTC 2018 Modified Files: src/external/bsd/libc++/lib: Makefile Log Message: Don't pass -z defs to libc++ with MKSANITIZER=yes Sanitizers are conflicting with this option: When linking shared libraries, the A

CVS commit: src/tests/lib/libc/sys

2018-06-06 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 6 13:16:32 UTC 2018 Modified Files: src/tests/lib/libc/sys: t_ptrace_wait.c Log Message: Mark sigbus ATF tests in t_ptrace_wait as expected failure They are breaking right now on all ports. lib/53343 To generate a diff

CVS commit: src/tests/lib/libc/sys

2018-06-06 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 6 13:18:44 UTC 2018 Modified Files: src/tests/lib/libc/sys: t_ptrace_wait.c Log Message: Fix previous The failing tests are for vfork(2), not fork(2). To generate a diff of this commit: cvs rdiff -u -r1.62 -r1.63 src/te

CVS commit: src/external/cddl/osnet/lib/libdtrace

2018-06-06 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 6 14:18:39 UTC 2018 Modified Files: src/external/cddl/osnet/lib/libdtrace: Makefile Log Message: Make cddl/osnet/lib/libdtrace buildable with MKLLVM=yes Clang/LLVM does not recognize: - -Wno-maybe-uninitialized - -Wno-u

CVS commit: src/external/cddl/osnet/usr.sbin/dtrace

2018-06-06 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 6 14:31:45 UTC 2018 Modified Files: src/external/cddl/osnet/usr.sbin/dtrace: Makefile Log Message: Make cddl/osnet/usr.sbin/dtrace -W compatible with MKLLVM=yes Clang/LLVM does not recognize: - -Wno-discarded-qualifiers

CVS commit: src/external/cddl/osnet/dist/cmd/dtrace

2018-06-06 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 6 14:46:58 UTC 2018 Modified Files: src/external/cddl/osnet/dist/cmd/dtrace: dtrace.c Log Message: Correct compilation of osnet/dist/cmd/dtrace/dtrace.c under Clang Add missing const keywords. This could be done with -W

CVS commit: src/external/cddl/osnet

2018-06-06 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 6 14:47:54 UTC 2018 Modified Files: src/external/cddl/osnet: Makefile.zfs Log Message: Make cddl/osnet/Makefile.zfs compatible with MKLLVM=yes Clang/LLVM does not recognize: - -Wno-discarded-qualifiers This is a step fo

CVS commit: src/sys/modules/dtrace

2018-06-06 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 6 14:57:38 UTC 2018 Modified Files: src/sys/modules/dtrace/dtrace: Makefile src/sys/modules/dtrace/linux32_syscall: Makefile src/sys/modules/dtrace/linux_syscall: Makefile src/sys/modules/dtrace/netb

CVS commit: src

2018-06-06 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 6 15:01:13 UTC 2018 Modified Files: src/external/cddl/osnet: Makefile.zfs src/sys/modules/dtrace/dtrace: Makefile src/sys/modules/dtrace/linux32_syscall: Makefile src/sys/modules/dtrace/linux_syscall

CVS commit: src/sys/modules/dtrace/dtrace

2018-06-06 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 6 15:15:41 UTC 2018 Modified Files: src/sys/modules/dtrace/dtrace: Makefile Log Message: Restrict -Wno-unused-but-set-variable in sys/modules/dtrace/dtrace to GCC Clang/LLVM does not recognize it. This is a step forward

CVS commit: src/external/cddl/osnet/dist/uts/common/dtrace

2018-06-06 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 6 15:24:57 UTC 2018 Modified Files: src/external/cddl/osnet/dist/uts/common/dtrace: dtrace.c Log Message: Correct compilation of osnet/dist/uts/common/dtrace/dtrace.c under Clang Add missing const keywords in dtrace_strnc

CVS commit: src/external/cddl/osnet/dev/dtrace

2018-06-06 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 6 15:54:03 UTC 2018 Modified Files: src/external/cddl/osnet/dev/dtrace: dtrace_hacks.c Log Message: Correct compilation of osnet/dev/dtrace/dtrace_hacks.c under Clang Use __UNCONST() to remove const from an argument. Thi

CVS commit: src/external/cddl/osnet/dev/dtrace/x86

2018-06-06 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 6 17:16:56 UTC 2018 Modified Files: src/external/cddl/osnet/dev/dtrace/x86: dis_tables.c Log Message: Correct compilation of osnet/dev/dtrace/x86/dis_tables.c under Clang Constify dgr_suffix. This could be done with -W f

CVS commit: src/external/cddl/osnet/dev/profile

2018-06-06 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 6 17:19:49 UTC 2018 Modified Files: src/external/cddl/osnet/dev/profile: profile.c Log Message: Correct compilation of osnet/dev/profile/profile.c under Clang Constify char* types when initialized with liternals. This co

CVS commit: src/external/cddl/osnet/dev/systrace

2018-06-06 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 6 17:47:10 UTC 2018 Modified Files: src/external/cddl/osnet/dev/systrace: systrace.c Log Message: Correct compilation of osnet/dev/systrace/systrace.c under Clang Mark arguments to dtrace_probe_lookup() with __UNCONST().

CVS commit: src/sys/modules/dtrace/linux_syscall

2018-06-06 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 6 17:54:33 UTC 2018 Modified Files: src/sys/modules/dtrace/linux_syscall: Makefile Log Message: Really disable unsupported $CC flag for LLVM The build of kernel modules works now: ./build.sh -V MKLLVM=yes -V MKGCC=no -

CVS commit: src/sys/dev/pci/ixgbe

2018-06-06 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 6 20:02:31 UTC 2018 Modified Files: src/sys/dev/pci/ixgbe: ixgbe.c ixv.c Log Message: Comment out unused functions in order to fix Clang build ixv_rearm_queues() and ixgbe_rearm_queues() are unused. Sponsored by To ge

CVS commit: src/sys/dev/pci

2018-06-06 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 6 20:05:36 UTC 2018 Modified Files: src/sys/dev/pci: svwsata.c Log Message: Enhance the syntax in order to be acceptable by Clang Replace "((crv == 0))" with "(crv == 0)", as the intention is to check the value, whether i

CVS commit: src

2018-06-07 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu Jun 7 13:21:44 UTC 2018 Modified Files: src/external/cddl/osnet: Makefile.zfs src/external/cddl/osnet/lib/libdtrace: Makefile src/external/cddl/osnet/usr.sbin/dtrace: Makefile src/sys/modules/dtrace/dtra

CVS commit: src

2018-06-10 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Jun 10 17:17:46 UTC 2018 Modified Files: src/distrib/sets/lists/games: mi src/distrib/sets/lists/misc: mi src/distrib/sets/lists/text: mi src/share: Makefile src/share/mk: bsd.subdir.mk Log Messa

CVS commit: src

2018-06-11 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Mon Jun 11 14:18:17 UTC 2018 Modified Files: src/games/rogue: Makefile src/sbin/fsck_ffs: Makefile src/usr.bin/dc: Makefile src/usr.bin/gprof: Makefile Log Message: Restore the MKGROFF=bo MKCXX=yes build Ma

CVS commit: src/sbin/ifconfig

2018-06-11 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Mon Jun 11 17:45:51 UTC 2018 Modified Files: src/sbin/ifconfig: af_inet.c Log Message: Correct Undefined Behavior in ifconfig(8) Unportable left shift reported with MKSANITIZER=yes USE_SANITIZER=undefined: # ifconfig alc0: flags=

CVS commit: src/lib/libc/citrus/modules

2018-06-11 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Mon Jun 11 18:03:38 UTC 2018 Modified Files: src/lib/libc/citrus/modules: citrus_mapper_std.c Log Message: Correct Undefined Behavior in libc/citrus Unportable left shift reported with MKSANITIZER=yes USE_SANITIZER=undefined: # n

CVS commit: src/usr.bin/gzip

2018-06-11 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue Jun 12 00:42:17 UTC 2018 Modified Files: src/usr.bin/gzip: gzip.c Log Message: Correct Undefined Behavior in gzip(1) Unportable left shift reported with MKSANITIZER=yes USE_SANITIZER=undefined: # progress -zf ./games.tgz tar

CVS commit: src/external/historical/nawk/dist

2018-06-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue Jun 12 13:24:28 UTC 2018 Modified Files: src/external/historical/nawk/dist: lex.c Log Message: Do not use index out of bounds in nawk $ awk '{w=$1}' < /dev/null /public/src.git/external/historical/nawk/bin/../dist/lex.c:476:16

CVS commit: src/bin/ksh

2018-06-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue Jun 12 14:13:55 UTC 2018 Modified Files: src/bin/ksh: eval.c Log Message: Change typ of tilde_ok from int to unsigned int in ksh(1) UBSan can detect that during switching a login to root there is unportable left shift operatio

CVS commit: src/bin/expr

2018-06-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue Jun 12 18:12:18 UTC 2018 Modified Files: src/bin/expr: expr.y Log Message: Rework perform_arith_op() in expr(1) to omit Undefined Behavior The current implementation of operations - + * / % could cause Undefined Behavior and i

CVS commit: src/tests/bin/expr

2018-06-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue Jun 12 18:54:40 UTC 2018 Modified Files: src/tests/bin/expr: t_expr.sh Log Message: Add 2 new expr(1) ATF tests Assert that -9223372036854775808 % -1 and -9223372036854775808 / -1 return message about overflow / underflow dete

CVS commit: src/external/gpl2/grep/dist/src

2018-06-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue Jun 12 21:22:47 UTC 2018 Modified Files: src/external/gpl2/grep/dist/src: dfa.c Log Message: Prevent Undefined Behavior in shift of signed integer in grep(1) There is an interface in grep: dfa.c with functions to test bit, set

CVS commit: src/sys/arch/i386/stand/mbr

2018-06-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue Jun 12 21:35:17 UTC 2018 Modified Files: src/sys/arch/i386/stand/mbr: Makefile.mbr Log Message: Set NOSANITIZER in i386 mbr files This is required to build these files and keep then functional with enabled MKSANITIZER. Sponso

CVS commit: src/lib

2018-06-13 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 13 08:19:36 UTC 2018 Modified Files: src/lib/libm: Makefile src/lib/librt: Makefile Log Message: Disable sanitizers for libm and librt The sanitizers are designed to use pristine OS versions of these libraries, ins

CVS commit: src/external/gpl2/grep/dist/lib

2018-06-13 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 13 17:32:29 UTC 2018 Modified Files: src/external/gpl2/grep/dist/lib: obstack.c Log Message: Avoid Undefind Behavior in DEFAULT_ALIGNMENT in GNU grep(1) Replace homegrown logic of calculating alignment with alignof, a C11

CVS commit: src/bin/expr

2018-06-13 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 13 17:35:15 UTC 2018 Modified Files: src/bin/expr: expr.y Log Message: Detect properly overflow in expr(1) for 0 + INT To generate a diff of this commit: cvs rdiff -u -r1.40 -r1.41 src/bin/expr/expr.y Please note that di

CVS commit: src/external/gpl2/grep/dist/lib

2018-06-14 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu Jun 14 10:14:39 UTC 2018 Modified Files: src/external/gpl2/grep/dist/lib: obstack.c Log Message: Make the alignof() usage more portable in grep(1) Remove NetBSD specific check and replace it with GCC extension __alignof__ that

CVS commit: src/crypto/external/bsd/heimdal/dist/lib/krb5

2018-06-16 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Jun 16 18:51:36 UTC 2018 Modified Files: src/crypto/external/bsd/heimdal/dist/lib/krb5: config_file.c Log Message: Do not reference buffer after the code scope {} rk_getpwuid_r() returns a pointer pwd->pw_dir to a buffer pwbuf

CVS commit: src/external/bsd/nvi/dist/common

2018-06-16 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Jun 16 18:54:52 UTC 2018 Modified Files: src/external/bsd/nvi/dist/common: log.c Log Message: Do not cause Undefined Behavior in vi(1) Replace unportable manual calculation of alignof() that causes UB, with a GCC extension __a

CVS commit: src/lib/csu

2018-06-16 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Jun 16 18:58:00 UTC 2018 Modified Files: src/lib/csu: Makefile Log Message: Disable MKSANITIZER in lib/csu These low-level libraries are expected to be not touched by a sanitizer. Every libc program not using sanitizers cannot

CVS commit: src/external/bsd/nvi/dist/common

2018-06-16 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Jun 16 21:00:12 UTC 2018 Modified Files: src/external/bsd/nvi/dist/common: log.c Log Message: Correct previous change to CHAR_T_OFFSET The intended operation is offsetof(), not alignof(). Noted by To generate a diff of thi

CVS commit: src/usr.bin/ldd

2018-06-21 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu Jun 21 10:41:46 UTC 2018 Modified Files: src/usr.bin/ldd/build: Makefile src/usr.bin/ldd/elf32: Makefile src/usr.bin/ldd/elf32_compat: Makefile src/usr.bin/ldd/elf64: Makefile Log Message: Disable SANITI

CVS commit: src/rescue

2018-06-21 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu Jun 21 10:44:01 UTC 2018 Modified Files: src/rescue: Makefile Log Message: Set NOSANITIZER in rescue/Makefile This is required to stop sanitizing rcmd.o and liboverride.o. These object files will be linked into statically link

CVS commit: src/usr.bin/crunch/crunchgen

2018-06-21 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu Jun 21 10:55:54 UTC 2018 Modified Files: src/usr.bin/crunch/crunchgen: crunchgen.1 crunchgen.c Log Message: Add new option -s to crunchgen(1) -- enable sanitization As of today typical sanitizers require dynamic executables, w

CVS commit: src/external/mpl/dhcp

2018-06-21 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu Jun 21 11:02:48 UTC 2018 Modified Files: src/external/mpl/dhcp: Makefile.inc Log Message: Make building of dhcp compatible with MKSANITIZER Disable LD flags (-Wl,-Bstatic and -Wl,-Bdynamic) with enabled MKSANITIZER. These opti

CVS commit: src/share/mk

2018-06-21 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu Jun 21 11:24:38 UTC 2018 Modified Files: src/share/mk: bsd.lib.mk bsd.prog.mk bsd.sys.mk Log Message: Refactor MKSANITIZER flags in mk rules Introduce a new variable SANITIZERFLAGS that contains all the sanitizer specific flag

CVS commit: src/distrib/amd64/ramdisks/common

2018-06-21 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu Jun 21 11:48:05 UTC 2018 Modified Files: src/distrib/amd64/ramdisks/common: Makefile.ramdisk Log Message: Specify NOSANITIZER in distrib/amd64/ramdisks/common This option cannot be set in distrib/common/Makefile.distrib as it'

CVS commit: src/usr.sbin/sysinst

2018-06-21 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu Jun 21 23:05:28 UTC 2018 Modified Files: src/usr.sbin/sysinst: util.c Log Message: Fix invalid free(3) in sysinst(8) The path variable is assigned with an allocation on the heap with strdup(3). Later this pointer is changed wi

CVS commit: src/usr.sbin/installboot/arch

2018-06-23 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Jun 23 14:15:57 UTC 2018 Modified Files: src/usr.sbin/installboot/arch: i386.c Log Message: Fix integer overflow in installboot(8) Add a sanity check of the disk_buf first three bytes. The original code on a disk with nul byte

CVS commit: src/external/gpl2/gettext/lib/libnlspr

2018-06-23 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Jun 23 20:15:23 UTC 2018 Modified Files: src/external/gpl2/gettext/lib/libnlspr: Makefile Log Message: Specify -Wno-format-extra-args for Clang/LLVM in gpl2/gettext This is needed with Clang v. 7svn (HEAD) 2018-06-23 snapshot.

CVS commit: src/usr.sbin/sysinst

2018-06-23 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Jun 23 22:35:29 UTC 2018 Modified Files: src/usr.sbin/sysinst: util.c Log Message: Enlarge the set_status[] array by a single element In the get_and_unpack_sets() function there is accessed the set_status[SET_GROUP_END] elemen

CVS commit: src/lib/libutil

2018-06-23 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Jun 24 01:53:14 UTC 2018 Modified Files: src/lib/libutil: passwd.c Log Message: Prevent underflow buffer read in trim_whitespace() in libutil/passwd.c If a string is empty or contains only white characters, the algorithm of re

CVS commit: src/lib/libutil

2018-06-24 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Jun 24 09:30:26 UTC 2018 Modified Files: src/lib/libutil: pty.c Log Message: Fix stack use after scope in libutil/pty The pt variable's elements are used after the end of the pt scope. A move of pt to outer scope fixes this.

CVS commit: src/sys/sys

2018-06-24 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Jun 24 12:05:41 UTC 2018 Modified Files: src/sys/sys: fd_set.h Log Message: Prevent signed integer left shift UB in FD_SET(), FD_CLR(), FD_ISSET() Set the type of shifted integer 1 to unsigned int. Detected with MKSANITIZER/U

CVS commit: src/external/gpl2/gettext/lib/libnlspr

2018-06-24 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Jun 24 19:27:26 UTC 2018 Modified Files: src/external/gpl2/gettext/lib/libnlspr: Makefile Log Message: Fix typo in previous The -Wno-format-extra-args argument to Clang/LLVM needs trailing 's'. Noted by To generate a diff

CVS commit: src/share/mk

2018-06-24 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Jun 24 19:35:12 UTC 2018 Modified Files: src/share/mk: bsd.sys.mk Log Message: Reset SANITIZERFLAGS when specified NOSANITIZER / MKSANITIZER=no This allows passing additional sanitizer specifig flags from the ./build.sh level,

CVS commit: src/share/mk

2018-06-24 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Jun 24 20:40:58 UTC 2018 Modified Files: src/share/mk: bsd.README Log Message: Enhance the documentation of MKSANITIZER in bsd.README Note that the list of sanitizer features is just a selection, not a complete list. Include t

CVS commit: src/share/mk

2018-06-25 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Mon Jun 25 09:38:46 UTC 2018 Modified Files: src/share/mk: bsd.README Log Message: Rephrase the documentation of MKSANITIZER Based on the feedback from and . To generate a diff of this commit: cvs rdiff -u -r1.376 -r1.377 src/s

CVS commit: src/external/bsd/nvi/dist/common

2018-06-25 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Mon Jun 25 17:42:34 UTC 2018 Modified Files: src/external/bsd/nvi/dist/common: log1.c Log Message: Avoid unportable offsetof(3) calculation in nvi in log1.c Detected with MKSANITIZER/UBSan. To generate a diff of this commit: cvs

CVS commit: src/share/mk

2018-06-25 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Mon Jun 25 17:58:36 UTC 2018 Modified Files: src/share/mk: bsd.lib.mk bsd.prog.mk Log Message: Add a framework for renaming symbols in libc&co for MKSANITIZER A new keyword SANITIZER_RENAME_SYMBOL. It's a variable that has specifi

CVS commit: src/external/bsd/nvi

2018-06-25 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Mon Jun 25 18:00:34 UTC 2018 Modified Files: src/external/bsd/nvi: Makefile.inc Log Message: Specify SANITIZER_RENAME_SYMBOL in nvi Rename local versions of regcomp regerror regexec regfree in order to remove symbol clash with lib

CVS commit: src/external/gpl2/diffutils

2018-06-25 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Mon Jun 25 18:01:13 UTC 2018 Modified Files: src/external/gpl2/diffutils: Makefile.inc Log Message: Specify SANITIZER_RENAME_SYMBOL in diffutils Rename local versions of regcomp regerror regexec regfree in order to remove symbol c

CVS commit: src/external/gpl2/grep

2018-06-25 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Mon Jun 25 18:02:49 UTC 2018 Modified Files: src/external/gpl2/grep: Makefile.inc Log Message: Specify SANITIZER_RENAME_SYMBOL in grep Rename local versions of regcomp regerror regexec regfree in order to remove symbol clash with

CVS commit: src/external/gpl2/xcvs

2018-06-25 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Mon Jun 25 18:03:56 UTC 2018 Modified Files: src/external/gpl2/xcvs: Makefile.inc Log Message: Specify SANITIZER_RENAME_SYMBOL in cvs Rename local versions of regcomp regerror regexec regfree in order to remove symbol clash with l

CVS commit: src/usr.bin/chpass

2018-06-25 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Mon Jun 25 18:05:25 UTC 2018 Modified Files: src/usr.bin/chpass: Makefile Log Message: Specify SANITIZER_RENAME_SYMBOL in chpass Rename local versions of getpwent getpwnam getpwnam_r getpwuid getpwuid_r (all of the symbols are nam

CVS commit: src/external/bsd/nvi/dist/common

2018-06-25 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Mon Jun 25 18:36:36 UTC 2018 Modified Files: src/external/bsd/nvi/dist/common: log1.c Log Message: Include for offsetof(3) To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/external/bsd/nvi/dist/common/log1.c Plea

CVS commit: src/external/bsd/tmux/dist

2018-06-25 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Mon Jun 25 18:41:25 UTC 2018 Modified Files: src/external/bsd/tmux/dist: window-copy.c Log Message: Avoid UB in tmux/window_copy_add_formats() Do not perform NULL pointer arithmetics. Reported with MKSANITIZER/UBSan. The patch p

CVS commit: src/share/misc

2018-06-25 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue Jun 26 00:06:09 UTC 2018 Modified Files: src/share/misc: acronyms.comp Log Message: Document sanitizers in acronyms.comp Added: ASan, CFI, DFSan, ESan, HWASan, LSan, MSan, TSan, UBSan. To generate a diff of this commit: cvs

CVS commit: src/doc/roadmaps/people

2018-06-26 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue Jun 26 16:06:21 UTC 2018 Removed Files: src/doc/roadmaps/people: kamil Log Message: Remove roadmap/kamil -8 goals finished in the possible scope for 8.0RC2 -9 abandoned in that scope after research To generate a diff of this

CVS commit: src/doc

2018-06-26 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue Jun 26 17:13:41 UTC 2018 Added Files: src/doc: TODO.sanitizers Log Message: Add TODO.sanitizer Note short term, long term and unspecified tasks with sanitizers. The long term goals are planned to be started after emptying TOD

CVS commit: src/sbin/disklabel

2018-06-26 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 27 01:14:48 UTC 2018 Modified Files: src/sbin/disklabel: main.c Log Message: Avoid misaligned access in disklabel(8) in find_label() Introduce a new helper variable tlp and use it for memory access. Detected with MKSANITI

CVS commit: src/bin/expr

2018-06-27 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 27 17:12:50 UTC 2018 Modified Files: src/bin/expr: expr.y Log Message: Improve the * operator handling in expr(1) Fixes overflow detection in expressions INT * -UINT. Detected with libFuzzer & UBSan. To generate a diff

CVS commit: src/tests/bin/expr

2018-06-27 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 27 17:14:47 UTC 2018 Modified Files: src/tests/bin/expr: t_expr.sh Log Message: Add a couple of new ATF expr(1) tests Some of the newly covered test-cases contained regressions. All tests pass. To generate a diff of thi

CVS commit: src/bin/expr

2018-06-27 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 27 17:23:36 UTC 2018 Modified Files: src/bin/expr: expr.y Log Message: Add a missing check to handle correctly 0 * 0 in expr(1) To generate a diff of this commit: cvs rdiff -u -r1.44 -r1.45 src/bin/expr/expr.y Please not

CVS commit: src/tests/bin/expr

2018-06-27 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 27 17:39:30 UTC 2018 Modified Files: src/tests/bin/expr: t_expr.sh Log Message: Add 3 more expr(1) ATF tests detecting overflow Verify 0 * INT. To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/tests/bin/ex

CVS commit: src/doc

2018-06-27 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jun 27 18:43:16 UTC 2018 Modified Files: src/doc: TODO.sanitizers Log Message: Remove the expr(1) entry from TODO.sanitizer (finished) While there, fix a typo in text. To generate a diff of this commit: cvs rdiff -u -r1.1 -r

CVS commit: src

2018-06-29 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Fri Jun 29 11:33:47 UTC 2018 Modified Files: src/external/cddl/osnet/dev/dtrace: dtrace_hacks.c src/external/cddl/osnet/dev/dtrace/x86: dis_tables.c src/external/cddl/osnet/dev/profile: profile.c src/external

CVS commit: src/sys/arch/x86/x86

2018-07-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue Jul 3 11:45:54 UTC 2018 Modified Files: src/sys/arch/x86/x86: intr.c Log Message: Avoid unportable signed integer left shift in intr_calculatemasks() Detected with Kernel Undefined Behavior Sanitizer. There were at least two

CVS commit: src/sys/kern

2018-07-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue Jul 3 12:17:54 UTC 2018 Modified Files: src/sys/kern: kern_descrip.c Log Message: Avoid unportable signed integer left shift in fd_used() Detected with Kernel Undefined Behavior Sanitizer. There were at least a single place

CVS commit: src/sys/sys

2018-07-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue Jul 3 22:38:34 UTC 2018 Modified Files: src/sys/sys: wait.h Log Message: Try to appease KUBSan in sys/sys/wait.h in W_EXITCODE() Cast return value that is stored as int to unsigned int in order to appease the << 8 operation.

CVS commit: src/sys/kern

2018-07-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue Jul 3 22:49:51 UTC 2018 Modified Files: src/sys/kern: kern_descrip.c Log Message: Avoid unportable signed integer left shift in fd_isused() Detected with Kernel Undefined Behavior Sanitizer. sys/kern/kern_descrip.c:188:34, l

CVS commit: src/sys/kern

2018-07-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue Jul 3 23:11:06 UTC 2018 Modified Files: src/sys/kern: kern_descrip.c Log Message: Avoid unportable signed integer left shift in fd_copy() Detected with Kernel Undefined Behavior Sanitizer. There were at least a single place

CVS commit: src/sys/kern

2018-07-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue Jul 3 23:14:57 UTC 2018 Modified Files: src/sys/kern: kern_descrip.c Log Message: Avoid unportable signed integer left shift in fd_unused() Detected with Kernel Undefined Behavior Sanitizer. There were at least a single plac

CVS commit: src/sys/netinet6

2018-07-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jul 4 00:35:34 UTC 2018 Modified Files: src/sys/netinet6: in6.c Log Message: Paper over Undefined Behavior in in6_control1() Replace calculation of maxexpire (TIME_MAX) with a construct that triggers UB with a one that uses i

CVS commit: src/sys/sys

2018-07-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jul 4 01:17:32 UTC 2018 Modified Files: src/sys/sys: mman.h Log Message: Avoid undefined operation in signed integer shift in MAP_ALIGNED() Cast the shifted byte to unsigned int. sys/uvm/uvm_mmap.c:914:19, left shift of 255

CVS commit: src/sys/kern

2018-07-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Jul 4 01:42:37 UTC 2018 Modified Files: src/sys/kern: subr_pool.c Log Message: Avoid Undefined Behavior in pr_item_notouch_get() Change the type of left shifted integer from signed to unsigned. sys/kern/subr_pool.c:274:13, l

<    1   2   3   4   5   6   7   8   9   10   >