Re: pro tip: use scriptlets instead of custom plugins

2017-02-20 Thread Loïc Minier
I can't really say how common this is; it's the first time I had to hack around stage-packages; it could indeed have been addressed through a plugin I was just thinking that if you add pre- post- hooks for every step of the lifecycle, then one before pull would have worked for me here; I have a so

Re: pro tip: use scriptlets instead of custom plugins

2017-02-20 Thread Kyle Fazzari
On Feb 20, 2017 9:14 AM, "Loïc Minier" wrote: On Mon, Feb 20, 2017 at 5:55 PM, Kyle Fazzari wrote: > > - 'prepare' runs before build > - 'build' replaces plugin build (including install) > - 'install' runs after build. This is useful e.g. for a Makefile with no > installation targets, or copy

Re: pro tip: use scriptlets instead of custom plugins

2017-02-20 Thread Olivier Tilloy
On Mon, Feb 20, 2017 at 5:55 PM, Kyle Fazzari wrote: > On Feb 20, 2017 6:23 AM, "Olivier Tilloy" > wrote: > > On Fri, Feb 17, 2017 at 12:11 AM, Leo Arias wrote: >> Hello! >> >> This week I've been cleaning a few of my old snaps, using some of the >> new features in more recent versions of snapcr

Re: pro tip: use scriptlets instead of custom plugins

2017-02-20 Thread Loïc Minier
On Mon, Feb 20, 2017 at 5:55 PM, Kyle Fazzari wrote: > > - 'prepare' runs before build > - 'build' replaces plugin build (including install) > - 'install' runs after build. This is useful e.g. for a Makefile with no > installation targets, or copying over some config files after the plugin > does

Re: pro tip: use scriptlets instead of custom plugins

2017-02-20 Thread Kyle Fazzari
On Feb 20, 2017 6:23 AM, "Olivier Tilloy" wrote: On Fri, Feb 17, 2017 at 12:11 AM, Leo Arias wrote: > Hello! > > This week I've been cleaning a few of my old snaps, using some of the > new features in more recent versions of snapcraft. At first I wasn't > convinced about scriptlets, but now I th

Re: pro tip: use scriptlets instead of custom plugins

2017-02-20 Thread Mark Shuttleworth
On 20/02/17 15:22, Olivier Tilloy wrote: > One thing that bit me is that I was expecting the 'install' scriptlet > to replace the `make install` step when using the make plugin, but it > doesn't. It runs `make`, `make install`, and then the install > scriptlet. Note that the documentation is reason

Re: pro tip: use scriptlets instead of custom plugins

2017-02-20 Thread Olivier Tilloy
On Fri, Feb 17, 2017 at 12:11 AM, Leo Arias wrote: > Hello! > > This week I've been cleaning a few of my old snaps, using some of the > new features in more recent versions of snapcraft. At first I wasn't > convinced about scriptlets, but now I think they are great. Take a > look at this diff: > >

Re: pro tip: use scriptlets instead of custom plugins

2017-02-17 Thread Oliver Grawert
hi, Am Donnerstag, den 16.02.2017, 17:11 -0600 schrieb Leo Arias: > Hello! > > This week I've been cleaning a few of my old snaps, using some of the > new features in more recent versions of snapcraft. At first I wasn't > convinced about scriptlets, but now I think they are great. Take a > look at

Re: pro tip: use scriptlets instead of custom plugins

2017-02-16 Thread Joseph Rushton Wakeling
On 17/02/17 00:11, Leo Arias wrote: This week I've been cleaning a few of my old snaps, using some of the new features in more recent versions of snapcraft. At first I wasn't convinced about scriptlets, but now I think they are great. Take a look at this diff: Thanks so much for that tip -- the

pro tip: use scriptlets instead of custom plugins

2017-02-16 Thread Leo Arias
Hello! This week I've been cleaning a few of my old snaps, using some of the new features in more recent versions of snapcraft. At first I wasn't convinced about scriptlets, but now I think they are great. Take a look at this diff: 5 additions and 144 deletions https://github.com/elopio/ipfs-sna