Re: RFR: 8342860: Fix more NULL usage backsliding [v2]

2024-11-05 Thread theoweidmannoracle
> - Changed several "NULL" in comments to "null" > - Changed several `NULL` in code to `nullptr` theoweidmannoracle has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by

Re: RFR: 8342860: Fix more NULL usage backsliding

2024-11-05 Thread theoweidmannoracle
On Tue, 5 Nov 2024 15:00:37 GMT, Sonia Zaldana Calles wrote: >> Hi @theoweidmannoracle, I think the GHA tests are not running because you >> haven't enabled GHA on your personal fork. See >> https://wiki.openjdk.org/display/SKARA/Testing for a bit more info. > >&

Re: RFR: 8342860: Fix more NULL usage backsliding

2024-11-05 Thread theoweidmannoracle
On Tue, 5 Nov 2024 14:22:06 GMT, Sonia Zaldana Calles wrote: >> - Changed several "NULL" in comments to "null" >> - Changed several `NULL` in code to `nullptr` > > Hi @theoweidmannoracle, I think the GHA tests are not running because you > haven

RFR: 8342860: Fix more NULL usage backsliding

2024-11-05 Thread theoweidmannoracle
- Changed several "NULL" in comments to "null" - Changed several `NULL` in code to `nullptr` - Commit messages: - Fix copyright year - 8342860: Fix more NULL usage backsliding Changes: https://git.openjdk.org/jdk/pull/21826/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=2

Re: RFR: 8342860: Fix more NULL usage backsliding

2024-11-05 Thread theoweidmannoracle
On Mon, 4 Nov 2024 19:10:50 GMT, Sonia Zaldana Calles wrote: >> - Changed several "NULL" in comments to "null" >> - Changed several `NULL` in code to `nullptr` > > src/hotspot/os/linux/cgroupSubsystem_linux.cpp line 1: > >> 1: /* > > Missing copyright update. Thanks for spotting this! --

Re: RFR: 8342860: Fix more NULL usage backsliding [v2]

2024-11-07 Thread theoweidmannoracle
On Tue, 5 Nov 2024 16:02:07 GMT, Kim Barrett wrote: > Can you use the (updated) regex in the JBS issue description to verify the > only remaining "NULL"s in src/hotspot are the jvmti.{xml,xls} files and the > globalDefinitions_{gcc,visCPP}.hpp files? > > There are also some NULLs recently intr

Re: RFR: 8342860: Fix more NULL usage backsliding [v3]

2024-11-07 Thread theoweidmannoracle
> - Changed several "NULL" in comments to "null" > - Changed several `NULL` in code to `nullptr` theoweidmannoracle has updated the pull request incrementally with one additional commit since the last revision: Fix backslides in test - Changes: - al

Re: RFR: 8342860: Fix more NULL usage backsliding [v2]

2024-11-08 Thread theoweidmannoracle
On Tue, 5 Nov 2024 14:56:10 GMT, Johan Sjölen wrote: >> theoweidmannoracle has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains th

Integrated: 8342860: Fix more NULL usage backsliding

2024-11-08 Thread theoweidmannoracle
On Fri, 1 Nov 2024 13:35:56 GMT, theoweidmannoracle wrote: > - Changed several "NULL" in comments to "null" > - Changed several `NULL` in code to `nullptr` This pull request has now been integrated. Changeset: 7d6a2f37 Author:theoweidmannoracle URL: h