RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump

2023-10-30 Thread Taizo Kurashige
Hi, I fixed the typos for JFR.start and JFR.dump. Acconding to issue's description, there is some typo in JFR.stop documentation, but I couldn't find that. I confirmed that there is no such typo in this repository. So I thought there was no need to fix JFR.stop documentation. I confirmed that t

Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump

2023-11-27 Thread Taizo Kurashige
On Mon, 30 Oct 2023 22:39:34 GMT, David Holmes wrote: >> Hi, >> >> I fixed the typos for JFR.start and JFR.dump. >> Acconding to issue's description, there is some typo in JFR.stop >> documentation, but I couldn't find that. I confirmed that there is no such >> typo in this repository. So I th

Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump

2023-11-27 Thread Taizo Kurashige
On Mon, 30 Oct 2023 16:09:50 GMT, Erik Gahlin wrote: >> Hi, >> >> I fixed the typos for JFR.start and JFR.dump. >> Acconding to issue's description, there is some typo in JFR.stop >> documentation, but I couldn't find that. I confirmed that there is no such >> typo in this repository. So I tho

Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v2]

2023-11-28 Thread Taizo Kurashige
ix JFR.stop > documentation. > > I confirmed that the fixes are reflected and that all of the jdk_jfr tests > pass. > > Could someone please review it? Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: 8313710: jc

Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v3]

2023-12-26 Thread Taizo Kurashige
ix JFR.stop > documentation. > > I confirmed that the fixes are reflected and that all of the jdk_jfr tests > pass. > > Could someone please review it? Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: 8313710: jc

Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump

2023-12-26 Thread Taizo Kurashige
On Thu, 30 Nov 2023 11:37:07 GMT, Erik Gahlin wrote: > > @egahlin > > > Looks like the added character and shift to the right will make the > > > description exceed 80 characters in some lines, for example "included" > > > for the begin option. > > > > > > I'm sorry, I don't know from which l

Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v3]

2023-12-26 Thread Taizo Kurashige
On Tue, 28 Nov 2023 07:44:27 GMT, David Holmes wrote: >> Thank you for telling me about how to jcmd.1 nroff file is managed. >> I will split this change into separate subtasks. Then if one of the Oracle >> engineers finds that subtask, will he/she work on it like any other bug? > > Yes it will b

Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v3]

2024-01-18 Thread Taizo Kurashige
On Tue, 28 Nov 2023 07:44:27 GMT, David Holmes wrote: >> Thank you for telling me about how to jcmd.1 nroff file is managed. >> I will split this change into separate subtasks. Then if one of the Oracle >> engineers finds that subtask, will he/she work on it like any other bug? > > Yes it will b

Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v3]

2024-01-30 Thread Taizo Kurashige
On Mon, 30 Oct 2023 22:39:41 GMT, David Holmes wrote: >> Taizo Kurashige has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump > > Changes

Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v3]

2024-02-06 Thread Taizo Kurashige
On Thu, 1 Feb 2024 05:07:13 GMT, David Holmes wrote: >> @dholmes-ora @egahlin >> >> I'm sorry that my slow response has prolonged this issue. I created a >> subtask and modified the source. If possible, please review them. > > Thanks @kurashige23 , the manpage subtask will be handled by someon

Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v3]

2024-02-26 Thread Taizo Kurashige
On Tue, 26 Dec 2023 14:15:17 GMT, Taizo Kurashige wrote: >> Hi, >> >> I fixed the typos for JFR.start and JFR.dump. >> Acconding to issue's description, there is some typo in JFR.stop >> documentation, but I couldn't find that. I confirmed that there is

Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v4]

2024-02-27 Thread Taizo Kurashige
ix JFR.stop > documentation. > > I confirmed that the fixes are reflected and that all of the jdk_jfr tests > pass. > > Could someone please review it? Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes

Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v4]

2024-02-27 Thread Taizo Kurashige
On Tue, 27 Feb 2024 08:06:18 GMT, Taizo Kurashige wrote: >> Hi, >> >> I fixed the typos for JFR.start and JFR.dump. >> Acconding to issue's description, there is some typo in JFR.stop >> documentation, but I couldn't find that. I confirmed that there is

Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v4]

2024-02-27 Thread Taizo Kurashige
On Tue, 27 Feb 2024 08:06:18 GMT, Taizo Kurashige wrote: >> Hi, >> >> I fixed the typos for JFR.start and JFR.dump. >> Acconding to issue's description, there is some typo in JFR.stop >> documentation, but I couldn't find that. I confirmed that there is

Integrated: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump

2024-02-27 Thread Taizo Kurashige
On Mon, 30 Oct 2023 08:46:08 GMT, Taizo Kurashige wrote: > Hi, > > I fixed the typos for JFR.start and JFR.dump. > Acconding to issue's description, there is some typo in JFR.stop > documentation, but I couldn't find that. I confirmed that there is no such > t