Hi,
I fixed the typos for JFR.start and JFR.dump.
Acconding to issue's description, there is some typo in JFR.stop documentation,
but I couldn't find that. I confirmed that there is no such typo in this
repository. So I thought there was no need to fix JFR.stop documentation.
I confirmed that t
On Mon, 30 Oct 2023 22:39:34 GMT, David Holmes wrote:
>> Hi,
>>
>> I fixed the typos for JFR.start and JFR.dump.
>> Acconding to issue's description, there is some typo in JFR.stop
>> documentation, but I couldn't find that. I confirmed that there is no such
>> typo in this repository. So I th
On Mon, 30 Oct 2023 16:09:50 GMT, Erik Gahlin wrote:
>> Hi,
>>
>> I fixed the typos for JFR.start and JFR.dump.
>> Acconding to issue's description, there is some typo in JFR.stop
>> documentation, but I couldn't find that. I confirmed that there is no such
>> typo in this repository. So I tho
ix JFR.stop
> documentation.
>
> I confirmed that the fixes are reflected and that all of the jdk_jfr tests
> pass.
>
> Could someone please review it?
Taizo Kurashige has updated the pull request incrementally with one additional
commit since the last revision:
8313710: jc
ix JFR.stop
> documentation.
>
> I confirmed that the fixes are reflected and that all of the jdk_jfr tests
> pass.
>
> Could someone please review it?
Taizo Kurashige has updated the pull request incrementally with one additional
commit since the last revision:
8313710: jc
On Thu, 30 Nov 2023 11:37:07 GMT, Erik Gahlin wrote:
> > @egahlin
> > > Looks like the added character and shift to the right will make the
> > > description exceed 80 characters in some lines, for example "included"
> > > for the begin option.
> >
> >
> > I'm sorry, I don't know from which l
On Tue, 28 Nov 2023 07:44:27 GMT, David Holmes wrote:
>> Thank you for telling me about how to jcmd.1 nroff file is managed.
>> I will split this change into separate subtasks. Then if one of the Oracle
>> engineers finds that subtask, will he/she work on it like any other bug?
>
> Yes it will b
On Tue, 28 Nov 2023 07:44:27 GMT, David Holmes wrote:
>> Thank you for telling me about how to jcmd.1 nroff file is managed.
>> I will split this change into separate subtasks. Then if one of the Oracle
>> engineers finds that subtask, will he/she work on it like any other bug?
>
> Yes it will b
On Mon, 30 Oct 2023 22:39:41 GMT, David Holmes wrote:
>> Taizo Kurashige has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump
>
> Changes
On Thu, 1 Feb 2024 05:07:13 GMT, David Holmes wrote:
>> @dholmes-ora @egahlin
>>
>> I'm sorry that my slow response has prolonged this issue. I created a
>> subtask and modified the source. If possible, please review them.
>
> Thanks @kurashige23 , the manpage subtask will be handled by someon
On Tue, 26 Dec 2023 14:15:17 GMT, Taizo Kurashige wrote:
>> Hi,
>>
>> I fixed the typos for JFR.start and JFR.dump.
>> Acconding to issue's description, there is some typo in JFR.stop
>> documentation, but I couldn't find that. I confirmed that there is
ix JFR.stop
> documentation.
>
> I confirmed that the fixes are reflected and that all of the jdk_jfr tests
> pass.
>
> Could someone please review it?
Taizo Kurashige has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes
On Tue, 27 Feb 2024 08:06:18 GMT, Taizo Kurashige wrote:
>> Hi,
>>
>> I fixed the typos for JFR.start and JFR.dump.
>> Acconding to issue's description, there is some typo in JFR.stop
>> documentation, but I couldn't find that. I confirmed that there is
On Tue, 27 Feb 2024 08:06:18 GMT, Taizo Kurashige wrote:
>> Hi,
>>
>> I fixed the typos for JFR.start and JFR.dump.
>> Acconding to issue's description, there is some typo in JFR.stop
>> documentation, but I couldn't find that. I confirmed that there is
On Mon, 30 Oct 2023 08:46:08 GMT, Taizo Kurashige wrote:
> Hi,
>
> I fixed the typos for JFR.start and JFR.dump.
> Acconding to issue's description, there is some typo in JFR.stop
> documentation, but I couldn't find that. I confirmed that there is no such
> t
15 matches
Mail list logo