Re: RFR: 8341927: Remove hardcoded SunJCE provider [v2]

2024-10-21 Thread Matthew Donovan
t;, > System.getProperty("test.provider.name", "SunJCE")); Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision: Updated a few more tests. - Changes: - all: https://git.openjdk.org/jdk/pull/21551/files - n

RFR: 8341927: Remove hardcoded SunJCE provider

2024-10-16 Thread Matthew Donovan
In this PR, I removed hard-coded security providers and replaced them with a system property, test.provider.name. If the property is not specified, the provider originally used in the test is used: Cipher c = Cipher.getInstance("AES/GCM/NoPadding", System.getProperty("test.provider.name", "SunJ

Re: RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property [v5]

2024-10-30 Thread Matthew Donovan
t;, > System.getProperty("test.provider.name", "SunJCE")); Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision: added documentation for the new property - Changes: - all: https://git.openjdk.org/jdk/pull/21551

Integrated: 8341927: Replace hardcoded security providers with new test.provider.name system property

2024-10-30 Thread Matthew Donovan
On Wed, 16 Oct 2024 18:47:44 GMT, Matthew Donovan wrote: > In this PR, I removed hard-coded security providers and replaced them with a > system property, test.provider.name. If the property is not specified, the > provider originally used in the test is used: >

Re: RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property [v6]

2024-10-30 Thread Matthew Donovan
t;, > System.getProperty("test.provider.name", "SunJCE")); Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision: updated testing doc per PR comments - Changes: - all: https://git.openjdk.org/jdk/pull/21551/files

Re: RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property [v7]

2024-10-30 Thread Matthew Donovan
t;, > System.getProperty("test.provider.name", "SunJCE")); Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision: included additional services in testing.md - Changes: - all: https://git.openjdk.org/jdk/pull/21551

Re: RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property

2024-10-25 Thread Matthew Donovan
On Mon, 21 Oct 2024 12:42:08 GMT, Sean Mullan wrote: > You are changing more than SunJCE providers, so the title of this bug should > not be specific to SunJCE. Suggest: "Replace hardcoded security providers > with new test.provider.name system property". > > Are there any cases where a test h

Re: RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property [v3]

2024-10-23 Thread Matthew Donovan
t;, > System.getProperty("test.provider.name", "SunJCE")); Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision: fixed whitespace - Changes: - all: https://git.openjdk.org/jdk/pull/21551/files - new: https

Re: RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property [v4]

2024-10-25 Thread Matthew Donovan
t;, > System.getProperty("test.provider.name", "SunJCE")); Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional

Re: RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property

2024-10-25 Thread Matthew Donovan
On Fri, 25 Oct 2024 12:53:04 GMT, Sean Mullan wrote: > > I changed the name of the bug and PR. Yes there are cases where a test has > > more than one hardcoded provider. > > How would that work then if the property only allows you to specify one > provider? The tests with multiple, hardcoded