Re: RFR: 8348239: SA does not know about DeoptimizeObjectsALotThread

2025-01-23 Thread Dean Long
On Thu, 23 Jan 2025 20:15:35 GMT, Chris Plummer wrote: > If you run hotspot with -XX:+DeoptimizeObjectsALot, it will create one or > more DeoptimizeObjectsALotThread threads. This is one of many JavaThread > subclasses that SA needs to know about, but in this case it does not. When SA > tries

Re: RFR: 8348239: SA does not know about DeoptimizeObjectsALotThread

2025-01-23 Thread Dean Long
On Thu, 23 Jan 2025 20:15:35 GMT, Chris Plummer wrote: > If you run hotspot with -XX:+DeoptimizeObjectsALot, it will create one or > more DeoptimizeObjectsALotThread threads. This is one of many JavaThread > subclasses that SA needs to know about, but in this case it does not. When SA > tries

Re: RFR: 8348239: SA does not know about DeoptimizeObjectsALotThread [v2]

2025-01-24 Thread Dean Long
On Fri, 24 Jan 2025 23:23:43 GMT, Chris Plummer wrote: > I don't see how that relates to this change. It sounds more like a general > suggestion to overhaul of how vmStructs is implemented. It relates because if something like that was available then we could register types that are local to a

Re: RFR: 8348239: SA does not know about DeoptimizeObjectsALotThread [v2]

2025-01-24 Thread Dean Long
On Thu, 23 Jan 2025 22:30:48 GMT, Chris Plummer wrote: > > Overall the changes seem fine, however it would be nice if the > > vmStructs.cpp registration mechanism was modular and extensible, instead of > > monolithic. That would make it easier to register private types, or even > > types outsi

Re: RFR: 8349088: De-virtualize Codeblob and nmethod [v8]

2025-02-13 Thread Dean Long
On Thu, 13 Feb 2025 17:14:59 GMT, Vladimir Kozlov wrote: >> Remove virtual methods from CodeBlob and nmethod to simplify >> saving/restoring in Leyden AOT cache. It avoids the need to patch hidden >> VPTR pointer to class's virtual table. >> >> Added C++ static asserts to make sure no virtual

Re: RFR: 8192647: GClocker induced GCs can starve threads requiring memory leading to OOME [v2]

2025-02-14 Thread Dean Long
On Wed, 5 Feb 2025 14:41:39 GMT, Albert Mingkun Yang wrote: >> Here is an attempt to simplify GCLocker implementation for Serial and >> Parallel. >> >> GCLocker prevents GC when Java threads are in a critical region (i.e., >> calling JNI critical APIs). JDK-7129164 introduces an optimization t

Re: RFR: 8349088: De-virtualize Codeblob and nmethod [v8]

2025-02-13 Thread Dean Long
On Thu, 13 Feb 2025 17:14:59 GMT, Vladimir Kozlov wrote: >> Remove virtual methods from CodeBlob and nmethod to simplify >> saving/restoring in Leyden AOT cache. It avoids the need to patch hidden >> VPTR pointer to class's virtual table. >> >> Added C++ static asserts to make sure no virtual

Re: RFR: 8349088: De-virtualize Codeblob and nmethod [v8]

2025-02-13 Thread Dean Long
On Thu, 13 Feb 2025 17:14:59 GMT, Vladimir Kozlov wrote: >> Remove virtual methods from CodeBlob and nmethod to simplify >> saving/restoring in Leyden AOT cache. It avoids the need to patch hidden >> VPTR pointer to class's virtual table. >> >> Added C++ static asserts to make sure no virtual

Re: RFR: 8349088: De-virtualize Codeblob and nmethod [v8]

2025-02-13 Thread Dean Long
On Thu, 13 Feb 2025 17:14:59 GMT, Vladimir Kozlov wrote: >> Remove virtual methods from CodeBlob and nmethod to simplify >> saving/restoring in Leyden AOT cache. It avoids the need to patch hidden >> VPTR pointer to class's virtual table. >> >> Added C++ static asserts to make sure no virtual

Re: RFR: 8349753: Incorrect use of CodeBlob::is_buffer_blob() in few places

2025-02-12 Thread Dean Long
On Thu, 13 Feb 2025 01:22:55 GMT, Vladimir Kozlov wrote: > `CodeBlob::is_buffer_blob()` method is incorrectly used in few places because > BufferBlob is not "leaf" class. You need to add checks for its subclasses too. > > I also updated statistic output for CodeCache (`-XX:+PrintCodeCache > -X

<    1   2   3