Re: RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-14 Thread Archie Cobbs
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote: > The following changes, to javac.1, were never applied to the closed sources > and are "lost" by this update. These changes will need to be re-applied > directly in JDK 21 and JDK 22 Just curious, since you have access to the secret closed

Re: RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-14 Thread Archie Cobbs
On Wed, 14 Jun 2023 21:28:01 GMT, David Holmes wrote: > > Just curious, since you have access to the secret closed sources, can you > > not backport these changes yourself? Instead of just deleting them and > > expecting someone else to rescue them from oblivion? > > @archiecobbs we (Oracle) w

Re: RFR: 8343483: Remove unnecessary @SuppressWarnings annotations (serviceability) [v2]

2024-11-02 Thread Archie Cobbs
> Please review this patch which removes unnecessary `@SuppressWarnings` > annotations. Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request co

RFR: 8343483: Remove unnecessary @SuppressWarnings annotations (serviceability)

2024-11-02 Thread Archie Cobbs
@SuppressWarnings annotations that don't actually suppress any warnings create a potential pathway for future bugs to creep in unnoticed. They should be removed if possible. This issue is for those JDK files with the "serviceability" label. - Commit messages: - Remove unnecessary

Re: RFR: 8343483: Remove unnecessary @SuppressWarnings annotations (serviceability) [v3]

2024-11-13 Thread Archie Cobbs
On Fri, 8 Nov 2024 19:07:34 GMT, Archie Cobbs wrote: >> Please review this patch which removes unnecessary `@SuppressWarnings` >> annotations. > > Archie Cobbs has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev e

Integrated: 8343483: Remove unnecessary @SuppressWarnings annotations (serviceability)

2024-11-13 Thread Archie Cobbs
On Sat, 2 Nov 2024 16:04:10 GMT, Archie Cobbs wrote: > Please review this patch which removes unnecessary `@SuppressWarnings` > annotations. This pull request has now been integrated. Changeset: a5f11b5f Author:Archie Cobbs URL: https://git.openjdk.org/jdk/

Re: RFR: 8343483: Remove unnecessary @SuppressWarnings annotations (serviceability) [v3]

2024-11-12 Thread Archie Cobbs
On Tue, 12 Nov 2024 18:54:30 GMT, Chris Plummer wrote: >> Archie Cobbs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contai

Re: RFR: 8343483: Remove unnecessary @SuppressWarnings annotations (serviceability) [v3]

2024-11-08 Thread Archie Cobbs
> Please review this patch which removes unnecessary `@SuppressWarnings` > annotations. Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request co

RFR: 8261669: Add lint warning for widening primitive conversions that lose information

2025-02-20 Thread Archie Cobbs
This PR is a prototype to stimulate discussion of [JDK-8261669](https://bugs.openjdk.org/browse/JDK-8261669), which seeks to add more warnings when an implicit cast of a primitive value might lose information. This can possibly happen when converting an `int` to `float`, or when converting a `l