On Fri, 11 Jul 2025 05:44:08 GMT, Serguei Spitsyn wrote:
>> src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 4053:
>>
>>> 4051: }
>>> 4052:
>>> 4053: void VM_RedefineClasses::compute_matching_methods() {
>>
>> I can't see that this method actually still does anything useful. ??
>
> I thin
On Thu, 10 Jul 2025 00:08:26 GMT, Alex Menkov wrote:
> The fix adds guards against JVMTI_ERROR_WRONG_PHASE error in VMObjectAlloc
> event handler.
>
> Testing: fixed test on all platforms
This pull request has now been integrated.
Changeset: 8c00c374
Author:Alex Menkov
URL:
https:
> The VM option -XX:AllowRedefinitionToAddDeleteMethods was added in JDK 13 as
> a temporary backward compatibility flag under JDK-8192936 and was immediately
> marked as Deprecate. The fix is to obsolete this option in JDK 26 and expire
> in JDK 27.
>
> TBD: Need to submit a related CSR.
>
>
On Fri, 11 Jul 2025 14:54:55 GMT, Coleen Phillimore wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: keep right order of the obsoleted VM options
>
> src/hotspot/share/oops/methodFlags.hpp line 49:
>
>>
On Fri, 11 Jul 2025 08:30:57 GMT, Richard Reingruber wrote:
>> This pr moves the `notify()` call to the finally block to avoid the deadlock
>> in `join()` if `verifyHeapDump(dumpFile)` throws an exception.
>>
>> Testing was done with fastdebug and release builds on the main platforms and
>> al
> The VM option -XX:AllowRedefinitionToAddDeleteMethods was added in JDK 13 as
> a temporary backward compatibility flag under JDK-8192936 and was immediately
> marked as Deprecate. The fix is to obsolete this option in JDK 26 and expire
> in JDK 27.
>
> TBD: Need to submit a related CSR.
>
>
> This pr moves the `notify()` call to the finally block to avoid the deadlock
> in `join()` if `verifyHeapDump(dumpFile)` throws an exception.
>
> Testing was done with fastdebug and release builds on the main platforms and
> also on Linux/PPC64le and AIX.
Richard Reingruber has updated the pu
On Thu, 10 Jul 2025 21:01:32 GMT, Chris Plummer wrote:
> With your fix in place, I assume now if verifyHeapDump() throws an exception
> the test will still fail, but in a more timely and meaningful manner.
Yes, that's the intention.
> Why is verifyHeapDump() throwing an exception in the first
On Fri, 11 Jul 2025 05:49:40 GMT, Serguei Spitsyn wrote:
>> The VM option -XX:AllowRedefinitionToAddDeleteMethods was added in JDK 13 as
>> a temporary backward compatibility flag under JDK-8192936 and was
>> immediately marked as Deprecate. The fix is to obsolete this option in JDK
>> 26 and
On Fri, 11 Jul 2025 20:08:01 GMT, Serguei Spitsyn wrote:
>> It was decided in a local discussion with Chris and Alan to update the JVMTI
>> spec to make descriptions/clarifications of some `JVMTI_ERROR_OPAQUE_FRAME`
>> cases more consistent.
>> This impacts the following JVMTI spec sections:
>>
On Fri, 11 Jul 2025 15:02:38 GMT, Coleen Phillimore wrote:
> It's nice to be able to clean this code out but I also think it's being used.
> Was there another mechanism that we suggest for instrumenting native methods?
> And there was code once to prefix native methods so this adding private
>
On Thu, 10 Jul 2025 21:40:50 GMT, Chris Plummer wrote:
> Problem list serviceability/sa/ClhsdbThreadContext.java on Windows due to
> numerous failures.
This pull request has now been integrated.
Changeset: f7e8d255
Author:Chris Plummer
URL:
https://git.openjdk.org/jdk/commit/f7e8d2
On Thu, 10 Jul 2025 21:40:50 GMT, Chris Plummer wrote:
> Problem list serviceability/sa/ClhsdbThreadContext.java on Windows due to
> numerous failures.
Thanks for the reviews Alex and Serguei!
-
PR Comment: https://git.openjdk.org/jdk/pull/26254#issuecomment-3063511949
> It was decided in a local discussion with Chris and Alan to update the JVMTI
> spec to make descriptions/clarifications of some `JVMTI_ERROR_OPAQUE_FRAME`
> cases more consistent.
> This impacts the following JVMTI spec sections:
> - `PopFrame`
> - `NotifyFramePop`
> - `ForceEarlyReturn`
On Thu, 10 Jul 2025 14:09:16 GMT, SendaoYan wrote:
> Hi all,
>
> Several tests which call `ThreadController` native libary missing `/native`
> jtreg directive. This PR add `/native` directive will make test more
> friendly. The analysis process of how to find which tests missing show as
> [JD
On Fri, 11 Jul 2025 00:29:05 GMT, Serguei Spitsyn wrote:
>> Hi all,
>>
>> Several tests which call `ThreadController` native libary missing `/native`
>> jtreg directive. This PR add `/native` directive will make test more
>> friendly. The analysis process of how to find which tests missing sho
On Fri, 11 Jul 2025 08:30:57 GMT, Richard Reingruber wrote:
>> This pr moves the `notify()` call to the finally block to avoid the deadlock
>> in `join()` if `verifyHeapDump(dumpFile)` throws an exception.
>>
>> Testing was done with fastdebug and release builds on the main platforms and
>> al
On Wed, 9 Jul 2025 07:39:05 GMT, Richard Reingruber wrote:
> This pr moves the `notify()` call to the finally block to avoid the deadlock
> in `join()` if `verifyHeapDump(dumpFile)` throws an exception.
>
> Testing was done with fastdebug and release builds on the main platforms and
> also on
Hi all,
This pull request contains a backport of commit
[3bacf7ea](https://github.com/openjdk/jdk/commit/3bacf7ea85f1e3f5e57fd2d046b98dfafe2c7e18)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by SendaoYan on 12 Jul 2025 and was
review
19 matches
Mail list logo
