Re: RFR: 8356222: Thread.print command reports waiting on the Class initialization monitor for both carrier and virtual threads

2025-05-22 Thread David Holmes
On Wed, 21 May 2025 20:35:33 GMT, Alex Menkov wrote: > The change fixes "Thread.print" diagnostic command when mounted virtual > thread is waiting on the class initialization monitor. > > Testing: new test, tier1 sanity run To me, in the pinned case, both threads are "really waiting". The carr

Integrated: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails

2025-05-22 Thread PAWAN CHAWDHARY
On Tue, 29 Apr 2025 13:04:15 GMT, PAWAN CHAWDHARY wrote: > 8352926: New test TestDockerMemoryMetricsSubgroup.java fails This pull request has now been integrated. Changeset: 9ca1004e Author:pawan chawdhary Committer: Mikhailo Seledtsov URL: https://git.openjdk.org/jdk/commit/9ca100

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v2]

2025-05-22 Thread Johan Sjölen
> Hi, > > The constant pool currently has a lot of methods specific to extracting > parts of the operands array. What this array actually is, is a sequence of > bootstrap method attribute entries, where each entry has the following > components: > > ```c++ > struct BSMAE { > u2 bootstrap_me

Re: RFR: 8356848: Separate Metaspace and GC printing [v5]

2025-05-22 Thread Joel Sikström
> Hello, > > The goal of this RFE is to separate Metaspace printing from GC printing. The > main reason Metaspace and GC printing is coupled the way it is right now is > because historically, the permanent generation (PermGen), which was replaced > by Metaspace, was part of the GC heap. Hence,

Re: RFR: 8241678: Remove PerfData sampling via StatSampler [v4]

2025-05-22 Thread Casper Norrbin
> Hi everyone, > > This change removes the legacy `PerfData` sampling mechanism implemented > through the `StatSampler` — an always-on periodic task that runs every 50ms > my default. The sampling feature was originally introduced to collect > performance counters and timestamps, but has since

Re: RFR: 8241678: Remove PerfData sampling via StatSampler [v3]

2025-05-22 Thread Casper Norrbin
On Wed, 21 May 2025 13:48:07 GMT, Johan Sjölen wrote: > It seems like there's no user-visible change, except the removal of the > global variable. Is that correct? Besides the global variable, there's a slight change in the behaviour of the perfdata-counters for Serial/Parallel, as mentioned i

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v2]

2025-05-22 Thread Johan Sjölen
On Wed, 21 May 2025 17:28:12 GMT, Lois Foltan wrote: >> Johan Sjölen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Lois's comments > > src/hotspot/share/oops/constantPool.hpp line 80: > >> 78: }; >> 79: >> 80: class BSMAttributeEntry

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v2]

2025-05-22 Thread Johan Sjölen
On Thu, 22 May 2025 17:52:41 GMT, Johan Sjölen wrote: >> Hi, >> >> The constant pool currently has a lot of methods specific to extracting >> parts of the operands array. What this array actually is, is a sequence of >> bootstrap method attribute entries, where each entry has the following >

Re: RFR: 8356848: Separate Metaspace and GC printing [v4]

2025-05-22 Thread Joel Sikström
On Thu, 15 May 2025 11:47:07 GMT, Joel Sikström wrote: >> Hello, >> >> The goal of this RFE is to separate Metaspace printing from GC printing. The >> main reason Metaspace and GC printing is coupled the way it is right now is >> because historically, the permanent generation (PermGen), which

Re: RFR: 8357282: Test vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java times out after ClassNotFoundException

2025-05-22 Thread Leonid Mesnik
On Wed, 21 May 2025 20:17:09 GMT, Alex Menkov wrote: > The change fixes failure of > vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java test. > The test was problem-listed in jdk 11 due intermittent timeouts, but in > jdk15-16 changes in nsk framework made the test fail 100% (it

Re: RFR: 8355003: Implement JEP 515: Ahead-of-Time Method Profiling [v23]

2025-05-22 Thread Igor Veresov
> Improve warm-up time by making profile data from a previous run of an > application instantly available, when the HotSpot Java Virtual Machine > starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) > to store method execution profiles from training runs, reducing profili

Re: RFR: 8357282: Test vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java fails after ClassNotFoundException

2025-05-22 Thread Alex Menkov
On Thu, 22 May 2025 19:50:44 GMT, Leonid Mesnik wrote: > As I understand, this fix is not related to timeout. So test is going to > fail. It might be makes a sense to remove it from problemlist to see how it > works. However better to rename PR summary. Oh, right. It's socket timeout, not the

Re: RFR: 8357282: Test vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java fails after ClassNotFoundException

2025-05-22 Thread Alex Menkov
On Thu, 22 May 2025 19:51:43 GMT, Leonid Mesnik wrote: >> The change fixes failure of >> vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java test. >> The test was problem-listed in jdk 11 due intermittent timeouts, but in >> jdk15-16 changes in nsk framework made the test fail 10

Re: RFR: 8356978: Convert unicode sequences in Java source code to UTF-8

2025-05-22 Thread Phil Race
On Wed, 14 May 2025 14:29:23 GMT, Magnus Ihse Bursie wrote: > After we converted the source base to be fully UTF-8, we do not need to use > unicode sequences (like \u0123) in string literals. Sometimes, that might > still make sense, as for control characters, non-breaking space, etc. But for

Re: RFR: 8356222: Thread.print command reports waiting on the Class initialization monitor for both carrier and virtual threads

2025-05-22 Thread David Holmes
On Wed, 21 May 2025 20:35:33 GMT, Alex Menkov wrote: > The change fixes "Thread.print" diagnostic command when mounted virtual > thread is waiting on the class initialization monitor. > > Testing: new test, tier1 sanity run At the moment class initialization in a vthread pins the carrier so I'

Re: RFR: 8356222: Thread.print command reports waiting on the Class initialization monitor for both carrier and virtual threads

2025-05-22 Thread Alan Bateman
On Thu, 22 May 2025 09:44:01 GMT, David Holmes wrote: > At the moment class initialization in a vthread pins the carrier so I'm not > sure why this is considered a problem?? The output is confusing as it prints the "waiting on the Class initialization monitor for XXX" twice. It makes it looks

Re: RFR: 8337789: JEP 509: JFR CPU-Time Profiling (Experimental) [v3]

2025-05-22 Thread Aleksey Shipilev
On Mon, 19 May 2025 17:06:09 GMT, Johannes Bechberger wrote: >> This is the code for the [JEP 509: CPU Time based profiling for >> JFR](https://openjdk.org/jeps/509). >> >> Currently tested using [this test >> suite](https://github.com/parttimenerd/basic-profiler-tests). This runs >> profile

Re: RFR: 8352075: Perf regression accessing fields [v8]

2025-05-22 Thread Radim Vansa
> This optimization is a followup to https://github.com/openjdk/jdk/pull/24290 > trying to reduce the performance regression in some scenarios introduced in > https://bugs.openjdk.org/browse/JDK-8292818 . Based both on performance and > memory consumption it is a (better) alternative to > https

Re: RFR: 8352075: Perf regression accessing fields [v3]

2025-05-22 Thread Radim Vansa
On Wed, 21 May 2025 15:11:29 GMT, Ioi Lam wrote: >> Even if the fields are only defined within the same class, the names of the >> fields are shared among different classes. > > To validate that you have sorted the table correctly, you should add a > debug-only validation function. This functio

Re: RFR: 8356893: Use "stdin.encoding" for reading System.in with InputStreamReader/Scanner

2025-05-22 Thread Volkan Yazici
On Wed, 21 May 2025 21:37:07 GMT, Roger Riggs wrote: >> There are several locations in the JDK source where `System.in` and >> `FileDescriptor.in` is read with `InputStreamReader` and `Scanner` using the >> default charset. As recommended by the recently merged >> [JDK-8356420](https://bugs.op

Re: RFR: 8356848: Separate Metaspace and GC printing [v4]

2025-05-22 Thread Joel Sikström
On Thu, 15 May 2025 11:47:07 GMT, Joel Sikström wrote: >> Hello, >> >> The goal of this RFE is to separate Metaspace printing from GC printing. The >> main reason Metaspace and GC printing is coupled the way it is right now is >> because historically, the permanent generation (PermGen), which

Withdrawn: 8356893: Use "stdin.encoding" for reading System.in with InputStreamReader/Scanner

2025-05-22 Thread Volkan Yazici
On Wed, 21 May 2025 20:56:31 GMT, Volkan Yazici wrote: > There are several locations in the JDK source where `System.in` and > `FileDescriptor.in` is read with `InputStreamReader` and `Scanner` using the > default charset. As recommended by the recently merged > [JDK-8356420](https://bugs.open

Re: RFR: 8356848: Separate Metaspace and GC printing [v4]

2025-05-22 Thread Thomas Stuefe
On Thu, 15 May 2025 11:47:07 GMT, Joel Sikström wrote: >> Hello, >> >> The goal of this RFE is to separate Metaspace printing from GC printing. The >> main reason Metaspace and GC printing is coupled the way it is right now is >> because historically, the permanent generation (PermGen), which

Re: RFR: 8356848: Separate Metaspace and GC printing [v4]

2025-05-22 Thread Joel Sikström
On Thu, 22 May 2025 08:19:00 GMT, Thomas Stuefe wrote: >> Joel Sikström has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update new order in tests > > src/hotspot/share/memory/metaspace/metaspaceDCmd.cpp line 62: > >> 60: void MetaspaceD

Re: RFR: 8356222: Thread.print command reports waiting on the Class initialization monitor for both carrier and virtual threads

2025-05-22 Thread Alan Bateman
On Thu, 22 May 2025 11:58:37 GMT, David Holmes wrote: > To me, in the pinned case, both threads are "really waiting". The carrier > physically and the vthread "logically". This also indicates it is actually > doing pinning. The intended mental model has always been that the carrier is waiting

Re: RFR: 8355003: Implement JEP 515: Ahead-of-Time Method Profiling [v24]

2025-05-22 Thread Igor Veresov
> Improve warm-up time by making profile data from a previous run of an > application instantly available, when the HotSpot Java Virtual Machine > starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) > to store method execution profiles from training runs, reducing profili

Re: RFR: 8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1 [v3]

2025-05-22 Thread PAWAN CHAWDHARY
> 8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1 PAWAN CHAWDHARY has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge branch 'master' into 8354475 - Update TestDockerMemoryMetricsSubgroup.ja

Re: RFR: 8356848: Separate Metaspace and GC printing [v4]

2025-05-22 Thread Thomas Stuefe
On Thu, 22 May 2025 08:46:55 GMT, Joel Sikström wrote: >> src/hotspot/share/memory/metaspace/metaspaceDCmd.cpp line 62: >> >>> 60: void MetaspaceDCmd::execute(DCmdSource source, TRAPS) { >>> 61: MetaspaceUtils::print_on(output()); >>> 62: >> >> Okay, though arguably somewhat redundant with t

Re: RFR: 8356848: Separate Metaspace and GC printing [v4]

2025-05-22 Thread Thomas Stuefe
On Thu, 22 May 2025 08:48:47 GMT, Joel Sikström wrote: >> test/hotspot/jtreg/serviceability/dcmd/gc/HeapInfoTest.java line 48: >> >>> 46: OutputAnalyzer output = executor.execute(cmd); >>> 47: output.shouldNotContain("Unknown diagnostic command"); >>> 48: output.shouldHav

Re: RFR: 8356848: Separate Metaspace and GC printing [v5]

2025-05-22 Thread Thomas Stuefe
On Thu, 22 May 2025 19:49:17 GMT, Joel Sikström wrote: >> Hello, >> >> The goal of this RFE is to separate Metaspace printing from GC printing. The >> main reason Metaspace and GC printing is coupled the way it is right now is >> because historically, the permanent generation (PermGen), which

Re: RFR: 8356848: Separate Metaspace and GC printing [v6]

2025-05-22 Thread Joel Sikström
> Hello, > > The goal of this RFE is to separate Metaspace printing from GC printing. The > main reason Metaspace and GC printing is coupled the way it is right now is > because historically, the permanent generation (PermGen), which was replaced > by Metaspace, was part of the GC heap. Hence,