Re: RFR: 8354407: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad.java still fails on Windows [v2]

2025-05-01 Thread Kevin Walls
On Wed, 30 Apr 2025 21:20:33 GMT, Kevin Walls wrote: >> I would simplify to >> >> for (int i = 0; i < TEST_COUNT; i++) { >> double load = mbean.getProcessCpuLoad(); >> if (load == -1.0 && Platform.isWindows()) { >> // Some Windows 2019 systems can return

Re: RFR: 8354407: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad.java still fails on Windows [v2]

2025-05-01 Thread Leonid Mesnik
On Wed, 30 Apr 2025 18:42:27 GMT, Kevin Walls wrote: >> This is hard to reproduce, and at first I'd only seen -1 returned on the >> first calls to mbean.getProcessCpuLoad(). >> But eventually I observed a -1 at any time, including in middle of the >> iterations, or on the last iteration which m

Integrated: 8354407: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad.java still fails on Windows

2025-05-01 Thread Kevin Walls
On Wed, 30 Apr 2025 11:13:53 GMT, Kevin Walls wrote: > This is hard to reproduce, and at first I'd only seen -1 returned on the > first calls to mbean.getProcessCpuLoad(). > But eventually I observed a -1 at any time, including in middle of the > iterations, or on the last iteration which makes

Re: RFR: 8354407: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad.java still fails on Windows [v2]

2025-05-01 Thread Leonid Mesnik
On Thu, 1 May 2025 10:07:04 GMT, Kevin Walls wrote: >> Thanks Leonid, yes we could do it like that. There have to be a load of >> ways we could arrange this. Yes, it could be a little simpler that what we >> have now, although it's not _that_ complicated now... > > I do like having the Except

Re: RFR: 8354407: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad.java still fails on Windows [v2]

2025-05-01 Thread Kevin Walls
On Thu, 1 May 2025 15:49:49 GMT, Leonid Mesnik wrote: >> I do like having the Exception created at the point where we recognise >> there's a problem. While the message could hard-code in the -1 in the >> Windows case, it must be also good to use the same expression to build the >> message, ri

Re: RFR: 8355003: Implement Ahead-of-Time Method Profiling [v9]

2025-05-01 Thread Igor Veresov
> Improve warm-up time by making profile data from a previous run of an > application instantly available, when the HotSpot Java Virtual Machine > starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) > to store method execution profiles from training runs, reducing profili

Re: RFR: 8354407: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad.java still fails on Windows [v2]

2025-05-01 Thread Kevin Walls
On Wed, 30 Apr 2025 18:42:27 GMT, Kevin Walls wrote: >> This is hard to reproduce, and at first I'd only seen -1 returned on the >> first calls to mbean.getProcessCpuLoad(). >> But eventually I observed a -1 at any time, including in middle of the >> iterations, or on the last iteration which m

Re: RFR: 8354461: Update tests to disable streaming output for attach tools

2025-05-01 Thread Alex Menkov
On Tue, 15 Apr 2025 23:30:35 GMT, Alex Menkov wrote: > The change is a preparation step to enable attach streaming output by default. > The fix updates a number of tests which fail with timeout in tier1..tier7 > when attach streaming output is enabled. > Details in the first comment. > Testing:

Re: RFR: 8355003: Implement Ahead-of-Time Method Profiling [v10]

2025-05-01 Thread Igor Veresov
> Improve warm-up time by making profile data from a previous run of an > application instantly available, when the HotSpot Java Virtual Machine > starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) > to store method execution profiles from training runs, reducing profili