Re: RFR: 8349638: Build libjdwp with SIZE optimization

2025-04-10 Thread Matthias Baesken
On Wed, 9 Apr 2025 20:26:13 GMT, Chris Plummer wrote: > > Making hotspot `-Os` would certainly never make any sense, for example.) > > When the minimalVM was first created, there was a quite of bit of > benchmarking done to decide which hotspot files to build with -Os and which > to build with

Re: RFR: 8352773: JVMTI should disable events during java upcalls [v3]

2025-04-10 Thread David Holmes
On Thu, 10 Apr 2025 05:50:23 GMT, Serguei Spitsyn wrote: >> As noted in [JDK-8352088](https://bugs.openjdk.org/browse/JDK-8352088), >> JVMTI `GetThreadGroupChildren` does an upcall to java. This results in >> a`ClassPrepare` event the first time it does this, and these events can >> cause pro

Re: RFR: 8342682: Errors related to unused code on Windows after 8339120 in dt_shmem jdwp security and jpackage [v7]

2025-04-10 Thread Julian Waters
On Mon, 11 Nov 2024 09:51:35 GMT, Julian Waters wrote: >> After 8339120, gcc began catching many different instances of unused code in >> the Windows specific codebase. Some of these seem to be bugs. I've taken the >> effort to mark out all the relevant globals and locals that trigger the >> u

Re: RFR: 8352773: JVMTI should disable events during java upcalls [v3]

2025-04-10 Thread Serguei Spitsyn
On Thu, 10 Apr 2025 05:50:23 GMT, Serguei Spitsyn wrote: >> As noted in [JDK-8352088](https://bugs.openjdk.org/browse/JDK-8352088), >> JVMTI `GetThreadGroupChildren` does an upcall to java. This results in >> a`ClassPrepare` event the first time it does this, and these events can >> cause pro

Re: RFR: 8350441: ZGC: Overhaul Page Allocation [v2]

2025-04-10 Thread Joel Sikström
On Thu, 10 Apr 2025 09:20:58 GMT, Joel Sikström wrote: >>> Note that any reference to pages from here on out refers to the concept of >>> a heap region in ZGC, not pages in the operating system (OS), unless stated >>> otherwise. >> >> # Background >> >> This PR addresses fragmentation by intr

Re: RFR: 8350441: ZGC: Overhaul Page Allocation [v2]

2025-04-10 Thread Joel Sikström
>> Note that any reference to pages from here on out refers to the concept of a >> heap region in ZGC, not pages in the operating system (OS), unless stated >> otherwise. > > # Background > > This PR addresses fragmentation by introducing a Mapped Cache that replaces > the Page Cache in ZGC. T

Re: RFR: 8350441: ZGC: Overhaul Page Allocation [v2]

2025-04-10 Thread Erik Österlund
On Thu, 10 Apr 2025 09:20:58 GMT, Joel Sikström wrote: >>> Note that any reference to pages from here on out refers to the concept of >>> a heap region in ZGC, not pages in the operating system (OS), unless stated >>> otherwise. >> >> # Background >> >> This PR addresses fragmentation by intr

Re: RFR: 8350441: ZGC: Overhaul Page Allocation [v2]

2025-04-10 Thread Axel Boldt-Christmas
On Thu, 10 Apr 2025 09:16:56 GMT, Joel Sikström wrote: >>> Note that any reference to pages from here on out refers to the concept of >>> a heap region in ZGC, not pages in the operating system (OS), unless stated >>> otherwise. >> >> # Background >> >> This PR addresses fragmentation by intr

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2025-04-10 Thread Eirik Bjørsnøs
On Thu, 10 Apr 2025 07:32:18 GMT, Magnus Ihse Bursie wrote: >> You don't have to do that, I'm working on an omnibus UTF-8 fixing PR right >> now, where I will include a fix for this as well. > > If anything, I might be a bit worried that there are more incorrect > conversions stemming from this

Re: RFR: 8352730: RISC-V: Disable tests in qemu-user [v3]

2025-04-10 Thread Robbin Ehn
On Thu, 10 Apr 2025 02:13:46 GMT, Fei Yang wrote: > > qemu-user, "uarch: qemu" in cpuinfo: `[0.084s][info ][os,cpu] CPU: total 28 > > (initial active 28) qemu rv64 rvi rvm rva rvf rvd rvc rvv zba zbb zbs zfh > > zfhmin zvbc zvfh zicond` Hence we know this is qemu-user (only qemu-user > > sets

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2025-04-10 Thread Magnus Ihse Bursie
On Thu, 10 Apr 2025 08:08:02 GMT, Eirik Bjørsnøs wrote: >> If anything, I might be a bit worried that there are more incorrect >> conversions stemming from this PR, that my automated tools and manual >> scanning has not revealed. > > Some observations: > > 1: This PR seems to have been abondo

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2025-04-10 Thread Magnus Ihse Bursie
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote: >> JDK .properties files still use ISO-8859-1 encoding with escape sequences. >> It would improve readability to see the native characters instead of escape >> sequences (especially for the L10n process). The majority of files changed >> are l

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2025-04-10 Thread Eirik Bjørsnøs
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote: >> JDK .properties files still use ISO-8859-1 encoding with escape sequences. >> It would improve readability to see the native characters instead of escape >> sequences (especially for the L10n process). The majority of files changed >> are l

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2025-04-10 Thread Magnus Ihse Bursie
On Thu, 10 Apr 2025 07:31:37 GMT, Magnus Ihse Bursie wrote: >> Right, that `å` looks to have been incorrectly converted during the >> ISO-8859-1 to UTF-8 conversion. (I can't find the script used for conversion >> as this change is from some time ago.) >> >> Since the change occurs in a commen

Re: RFR: 8352773: JVMTI should disable events during java upcalls

2025-04-10 Thread Serguei Spitsyn
On Wed, 9 Apr 2025 20:38:08 GMT, Chris Plummer wrote: >> As noted in [JDK-8352088](https://bugs.openjdk.org/browse/JDK-8352088), >> JVMTI `GetThreadGroupChildren` does an upcall to java. This results in >> a`ClassPrepare` event the first time it does this, and these events can >> cause proble

Re: RFR: 8353727: HeapDumpPath doesn't expand %p [v4]

2025-04-10 Thread Kevin Walls
On Wed, 9 Apr 2025 11:04:26 GMT, Kevin Walls wrote: >> This is a long-standing oversight: HeapDumpPath does not recognise %p for >> pid expansion. >> The default filename uses a pid (e.g. java_pid1676937.hprof) but >> HeapDumpPath does not. >> It has always done a manual "root plus pid plus ext

Re: RFR: 8352773: JVMTI should disable events during java upcalls [v3]

2025-04-10 Thread Leonid Mesnik
On Thu, 10 Apr 2025 05:50:23 GMT, Serguei Spitsyn wrote: >> As noted in [JDK-8352088](https://bugs.openjdk.org/browse/JDK-8352088), >> JVMTI `GetThreadGroupChildren` does an upcall to java. This results in >> a`ClassPrepare` event the first time it does this, and these events can >> cause pro

Re: RFR: 8352773: JVMTI should disable events during java upcalls [v4]

2025-04-10 Thread Serguei Spitsyn
> As noted in [JDK-8352088](https://bugs.openjdk.org/browse/JDK-8352088), JVMTI > `GetThreadGroupChildren` does an upcall to java. This results in > a`ClassPrepare` event the first time it does this, and these events can cause > problems (deadlocks) for the debugger or debug agent. The > [JDK

Re: RFR: 8352773: JVMTI should disable events during java upcalls [v3]

2025-04-10 Thread Serguei Spitsyn
On Thu, 10 Apr 2025 05:50:23 GMT, Serguei Spitsyn wrote: >> As noted in [JDK-8352088](https://bugs.openjdk.org/browse/JDK-8352088), >> JVMTI `GetThreadGroupChildren` does an upcall to java. This results in >> a`ClassPrepare` event the first time it does this, and these events can >> cause pro

Re: RFR: 8350441: ZGC: Overhaul Page Allocation [v2]

2025-04-10 Thread Stefan Karlsson
On Thu, 10 Apr 2025 09:16:56 GMT, Joel Sikström wrote: >>> Note that any reference to pages from here on out refers to the concept of >>> a heap region in ZGC, not pages in the operating system (OS), unless stated >>> otherwise. >> >> # Background >> >> This PR addresses fragmentation by intr

RFR: 8352773: JVMTI should disable events during java upcalls

2025-04-10 Thread Serguei Spitsyn
As noted in [JDK-8352088](https://bugs.openjdk.org/browse/JDK-8352088), JVMTI `GetThreadGroupChildren` does an upcall to java. This results in a`ClassPrepare` event the first time it does this, and these events can cause problems (deadlocks) for the debugger or debug agent. The [JDK-8352088](

Integrated: 8350441: ZGC: Overhaul Page Allocation

2025-04-10 Thread Joel Sikström
On Wed, 9 Apr 2025 13:37:16 GMT, Joel Sikström wrote: >> Note that any reference to pages from here on out refers to the concept of a >> heap region in ZGC, not pages in the operating system (OS), unless stated >> otherwise. > > # Background > > This PR addresses fragmentation by introducing

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2025-04-10 Thread Justin Lu
On Thu, 10 Apr 2025 08:44:28 GMT, Eirik Bjørsnøs wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Replace InputStreamReader with BufferedReader > > FWIW, I checked out the revision of the commit previous to this change

RFR: 8351927: Change VirtualThread implementation to use use FJP delayed task handling

2025-04-10 Thread Alan Bateman
Follow up to JDK-8319447 to change the VirtualThread implementation to use FJP's delayed task handling. The SPTE based implementation is not removed. It will continue to be used by tests. If custom schedulers are exposed in the future then they will use this implementation. For timed-Object.wa

Re: RFR: 8341491: Reserve and commit memory operations should be protected by NMT lock [v3]

2025-04-10 Thread Stefan Karlsson
On Tue, 8 Apr 2025 14:11:21 GMT, Stefan Karlsson wrote: >> Robert Toyonaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> exclude file mapping tests on AIX. > > test/hotspot/gtest/runtime/test_os.cpp line 1145: > >> 1143: EXPECT_TRUE

Re: RFR: 8352773: JVMTI should disable events during java upcalls [v4]

2025-04-10 Thread David Holmes
On Thu, 10 Apr 2025 17:59:15 GMT, Serguei Spitsyn wrote: >> As noted in [JDK-8352088](https://bugs.openjdk.org/browse/JDK-8352088), >> JVMTI `GetThreadGroupChildren` does an upcall to java. This results in >> a`ClassPrepare` event the first time it does this, and these events can >> cause pro

RFR: 8353953: con/sun/jdi tests should be fixed to not always require includevirtualthreads=y

2025-04-10 Thread Chris Plummer
Don't use includevirtualthreads=y unless the test requires it. Debuggers don't usually use includevirtualthreads=y, so we should be doing most of our testing without it. The only reason tests use it is because some tests need it so they can find virtual threads in the debuggee by using vm.allThr

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2025-04-10 Thread Magnus Ihse Bursie
On Wed, 9 Apr 2025 21:26:15 GMT, Justin Lu wrote: >> src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/Encodings.properties >> line 22: >> >>> 20: # Peter Smolik >>> 21: Cp1250 WINDOWS-1250 0x00FF >>> 22: # Patch attributed to hava...@underdusken.no (H�vard Wigtil) >> >> Th

Re: RFR: 8352773: JVMTI should disable events during java upcalls

2025-04-10 Thread Serguei Spitsyn
On Wed, 9 Apr 2025 08:14:04 GMT, Serguei Spitsyn wrote: > As noted in [JDK-8352088](https://bugs.openjdk.org/browse/JDK-8352088), JVMTI > `GetThreadGroupChildren` does an upcall to java. This results in > a`ClassPrepare` event the first time it does this, and these events can cause > problems

Re: RFR: 8352773: JVMTI should disable events during java upcalls [v4]

2025-04-10 Thread Leonid Mesnik
On Thu, 10 Apr 2025 17:59:15 GMT, Serguei Spitsyn wrote: >> As noted in [JDK-8352088](https://bugs.openjdk.org/browse/JDK-8352088), >> JVMTI `GetThreadGroupChildren` does an upcall to java. This results in >> a`ClassPrepare` event the first time it does this, and these events can >> cause pro

Re: RFR: 8349638: Build libjdwp with SIZE optimization

2025-04-10 Thread Magnus Ihse Bursie
On Tue, 11 Feb 2025 15:56:39 GMT, Matthias Baesken wrote: > The libjdwp is currently built with LOW optimization level, it could be built > with SIZE optimization to lower the lib size by ~ 10 % on UNIX. > On Windows LOW and SIZE currently translate to the same O1 optimization flag > so no diff

Re: RFR: 8353953: con/sun/jdi tests should be fixed to not always require includevirtualthreads=y [v2]

2025-04-10 Thread Chris Plummer
> Don't use includevirtualthreads=y unless the test requires it. Debuggers > don't usually use includevirtualthreads=y, so we should be doing most of our > testing without it. The only reason tests use it is because some tests need > it so they can find virtual threads in the debuggee by using v

Re: RFR: 8353727: HeapDumpPath doesn't expand %p

2025-04-10 Thread Kevin Walls
On Tue, 8 Apr 2025 01:37:21 GMT, Chris Plummer wrote: >> This is a long-standing oversight: HeapDumpPath does not recognise %p for >> pid expansion. >> The default filename uses a pid (e.g. java_pid1676937.hprof) but >> HeapDumpPath does not. >> It has always done a manual "root plus pid plus e

Integrated: 8352773: JVMTI should disable events during java upcalls

2025-04-10 Thread Serguei Spitsyn
On Wed, 9 Apr 2025 08:14:04 GMT, Serguei Spitsyn wrote: > As noted in [JDK-8352088](https://bugs.openjdk.org/browse/JDK-8352088), JVMTI > `GetThreadGroupChildren` does an upcall to java. This results in > a`ClassPrepare` event the first time it does this, and these events can cause > problems

Re: RFR: 8353953: con/sun/jdi tests should be fixed to not always require includevirtualthreads=y [v2]

2025-04-10 Thread Hendrik Schick
On Thu, 10 Apr 2025 20:31:13 GMT, Chris Plummer wrote: >> Don't use includevirtualthreads=y unless the test requires it. Debuggers >> don't usually use includevirtualthreads=y, so we should be doing most of our >> testing without it. The only reason tests use it is because some tests need >> i

Re: RFR: 8352773: JVMTI should disable events during java upcalls [v4]

2025-04-10 Thread Serguei Spitsyn
On Thu, 10 Apr 2025 17:59:15 GMT, Serguei Spitsyn wrote: >> As noted in [JDK-8352088](https://bugs.openjdk.org/browse/JDK-8352088), >> JVMTI `GetThreadGroupChildren` does an upcall to java. This results in >> a`ClassPrepare` event the first time it does this, and these events can >> cause pro

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2025-04-10 Thread Magnus Ihse Bursie
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote: >> JDK .properties files still use ISO-8859-1 encoding with escape sequences. >> It would improve readability to see the native characters instead of escape >> sequences (especially for the L10n process). The majority of files changed >> are l

Re: RFR: 8349638: Build libjdwp with SIZE optimization

2025-04-10 Thread Magnus Ihse Bursie
On Tue, 11 Feb 2025 15:56:39 GMT, Matthias Baesken wrote: > The libjdwp is currently built with LOW optimization level, it could be built > with SIZE optimization to lower the lib size by ~ 10 % on UNIX. > On Windows LOW and SIZE currently translate to the same O1 optimization flag > so no diff

Re: RFR: 8352773: JVMTI should disable events during java upcalls [v4]

2025-04-10 Thread Chris Plummer
On Thu, 10 Apr 2025 17:59:15 GMT, Serguei Spitsyn wrote: >> As noted in [JDK-8352088](https://bugs.openjdk.org/browse/JDK-8352088), >> JVMTI `GetThreadGroupChildren` does an upcall to java. This results in >> a`ClassPrepare` event the first time it does this, and these events can >> cause pro

Re: RFR: 8353953: con/sun/jdi tests should be fixed to not always require includevirtualthreads=y [v3]

2025-04-10 Thread Chris Plummer
> Don't use includevirtualthreads=y unless the test requires it. Debuggers > don't usually use includevirtualthreads=y, so we should be doing most of our > testing without it. The only reason tests use it is because some tests need > it so they can find virtual threads in the debuggee by using v

Re: RFR: 8353953: con/sun/jdi tests should be fixed to not always require includevirtualthreads=y [v2]

2025-04-10 Thread Chris Plummer
On Thu, 10 Apr 2025 21:32:05 GMT, Hendrik Schick wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix copyright. > > test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java line 1: > >> 1: /* > > update c