Re: RFR: 8352098: -Xrunjdwp fails on static JDK [v2]

2025-04-05 Thread Chris Plummer
On Tue, 18 Mar 2025 16:54:51 GMT, Jiangli Zhou wrote: >> Please review this fix that avoids `JvmtiAgent::convert_xrun_agent` from >> prematurely exiting VM if `lookup_On_Load_entry_point` cannot load the agent >> using `JVM_OnLoad` symbol. Thanks >> >> `lookup_On_Load_entry_point` first tries

Re: RFR: 8344671: Few JFR streaming tests fail with application not alive error on MacOS 15 [v2]

2025-04-05 Thread Larry Cable
On Thu, 27 Mar 2025 06:27:44 GMT, Jaikiran Pai wrote: >> Larry Cable has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - Update src/jdk.attach/macosx/native/libattach/VirtualMachineImpl.c >> >>Co-authored-by: David Holmes >> <62

Re: RFR: 8352163: [AIX] SIGILL in AttachOperation::ReplyWriter::write_fully after 8319055

2025-04-05 Thread Alex Menkov
On Tue, 18 Mar 2025 09:21:42 GMT, Martin Doerr wrote: > LGTM. Thanks for fixing it so quickly! Should `reply_writer` get implemented? > We could file an RFE. Yes, AIX implementation needs update (it does not support attach API v2 and streaming output). I was going to file RFE after the code is

Re: RFR: 8341491: Reserve and commit memory operations should be protected by NMT lock

2025-04-05 Thread Robert Toyonaga
On Mon, 24 Mar 2025 16:16:34 GMT, Stefan Karlsson wrote: >> ### Summary: >> This PR makes memory operations atomic with NMT accounting. >> >> ### The problem: >> In memory related functions like `os::commit_memory` and >> `os::reserve_memory` the OS memory operations are currently done before

Re: RFR: 8352730: RISC-V: Disable tests in qemu-user [v2]

2025-04-05 Thread Robbin Ehn
On Thu, 27 Mar 2025 17:57:37 GMT, Hamlin Li wrote: > I also feel annoying to see some tests fail interminently. > > Not sure if I understand the goal of this pr, seems it might not be the best > solution to simply disable these tests when running with qemu. My concerns > are: qemu is still one

Re: RFR: 8341491: Reserve and commit memory operations should be protected by NMT lock

2025-04-05 Thread Stefan Karlsson
On Fri, 28 Mar 2025 09:44:00 GMT, Thomas Stuefe wrote: > > > > > > > I don't understand why we don't treat that as a fatal error OR > > > > > > > make sure that all call-sites handles that error, which they > > > > > > > don't do today. > > > > > > > > > > > > > > > > > > I think release/unco

Re: RFR: 8352088: Call of com.sun.jdi.ThreadReference.threadGroups() can lock up target VM [v7]

2025-04-05 Thread Chris Plummer
> Calling ThreadGroupReference.groups() from an event handler can cause a > deadlock. Details in first comment. Tested with :jdk_lang on all supported > platforms and tier1, tier2, tier3, and tier5 svc testing. Chris Plummer has updated the pull request incrementally with one additional commit

Re: RFR: 8352163: [AIX] SIGILL in AttachOperation::ReplyWriter::write_fully after 8319055

2025-04-05 Thread Martin Doerr
On Tue, 18 Mar 2025 22:19:53 GMT, Alex Menkov wrote: > > > Yes, AIX implementation needs update (it does not support attach API v2 > > > and streaming output). I was going to file RFE after the code is > > > stabilized (AIX implementation is basically the same as posix > > > implementation) >

RFR: 8316682: serviceability/jvmti/vthread/SelfSuspendDisablerTest timed out

2025-04-05 Thread Serguei Spitsyn
This fixes the issue with lack of synchronization between JVMTI thread suspend and resume functions in a self-suspend case. More detailed fix description is in the first PR comment. Testing: Ran mach5 tiers 1-6. - Commit messages: - 8316682: serviceability/jvmti/vthread/SelfSuspen

Re: RFR: 8351002: com/sun/management/OperatingSystemMXBean cpuLoad tests fail intermittently [v3]

2025-04-05 Thread Leonid Mesnik
On Tue, 25 Mar 2025 11:21:28 GMT, Kevin Walls wrote: >> These tests have always silently permitted a -1 return value from >> OperatingSystemMXBean CPU time methods. >> >> They need to be stricter, but occasionally Windows 2019 returns a -1 for the >> first few calls of these methods. This see

RFR: 8351310: Deprecate com.sun.jdi.JDIPermission for removal

2025-04-05 Thread Kevin Walls
Following on from JEP 486 (Permanently Disable the Security Manager), there are Permission classes which are unused. These should be deprecated, for removal in future. - Commit messages: - 8351310: Deprecate jdk.jdi/share/classes/com/sun/jdi/JDIPermission.java for removal Changes

Re: RFR: 8352392: AIX: implement attach API v2 and streaming output

2025-04-05 Thread Joachim Kern
On Sun, 23 Mar 2025 14:33:36 GMT, Varada M wrote: > AIX changes for attach API to support arbitrary length arguments and the > streaming output support. > serviceability/attach/AttachAPIv2/StreamingOutputTest.java test passes > > tier1, tier2 and tier3 testing is successful with fastdebug leve

Re: RFR: 8353597: Refactor handling VM options for AOT cache input and output [v3]

2025-04-05 Thread Ioi Lam
> Since [JEP 483: Ahead-of-Time Class Loading & > Linking](https://openjdk.org/jeps/483), VM options such as `-XX:AOTCache `are > implemented as aliases of "classical" CDS options such as > `-XX:SharedArchiveFile`. > > In anticipation of the [JEP: Ahead-of-time Command Line > Ergonomics](https

Re: RFR: 8323100: com/sun/tools/attach/StartManagementAgent.java failed with "WaitForSingleObject failed"

2025-04-05 Thread Kevin Walls
On Tue, 1 Apr 2025 05:57:55 GMT, David Holmes wrote: > See bug report for gory details. > > Short version: in the Windows version of `VirtualMachineImpl::execute`, if an > exception occurred after we created the `SocketInputStreamImpl` (which is the > test scenario of the failing test), we wou

Re: RFR: 8341491: Reserve and commit memory operations should be protected by NMT lock [v2]

2025-04-05 Thread Joachim Kern
On Wed, 2 Apr 2025 14:02:25 GMT, Robert Toyonaga wrote: >> ### Summary: >> This PR makes memory operations atomic with NMT accounting. >> >> ### The problem: >> In memory related functions like `os::commit_memory` and >> `os::reserve_memory` the OS memory operations are currently done before >

RFR: 8352652: [BACKOUT] nsk/jvmti/ tests should fail when nsk_jvmti_setFailStatus() is called

2025-04-05 Thread David Holmes
Revert "8351375: nsk/jvmti/ tests should fail when nsk_jvmti_setFailStatus() is called" This reverts commit 334a1eec2375a4f9f3150bdb556c1c2432596b4b. The original change caused numerous test failures. Thanks - Commit messages: - Revert "8351375: nsk/jvmti/ tests should fail when

Integrated: 8344671: Few JFR streaming tests fail with application not alive error on MacOS 15

2025-04-05 Thread Larry Cable
On Mon, 17 Mar 2025 18:26:57 GMT, Larry Cable wrote: > on both Linux and MacOS libattach utilizes UNIX signal (QUIT) to cause a > target JVM (attachee) to create the socket file used as transport for > subsequent jcmds (and other attach based interactions) and to listen upon > that for such. >

Re: RFR: 8353597: Refactor handling VM options for AOT cache input and output [v2]

2025-04-05 Thread Ioi Lam
On Thu, 3 Apr 2025 19:33:12 GMT, Leonid Mesnik wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> more clean up > > test/hotspot/jtreg/runtime/cds/appcds/AOTFlags.java line 28: > >> 26: * @test >> 27: * @summary "AOT" a

Re: RFR: 8323100: com/sun/tools/attach/StartManagementAgent.java failed with "WaitForSingleObject failed"

2025-04-05 Thread David Holmes
On Tue, 1 Apr 2025 09:08:06 GMT, Kevin Walls wrote: >> See bug report for gory details. >> >> Short version: in the Windows version of `VirtualMachineImpl::execute`, if >> an exception occurred after we created the `SocketInputStreamImpl` (which is >> the test scenario of the failing test), we

Re: RFR: 8341491: Reserve and commit memory operations should be protected by NMT lock

2025-04-05 Thread Robert Toyonaga
On Tue, 25 Mar 2025 18:55:56 GMT, Stefan Karlsson wrote: > Are there any code that we know of that doesn't fit into a synchronization > pattern similar to the above? > I can think of some contrived example where Thread B asks the OS for memory > mappings and uses that to ascertain that a pre-de

RFR: 8353597: Refactor handling VM options for AOT cache input and output

2025-04-05 Thread Ioi Lam
Since [JEP 483: Ahead-of-Time Class Loading & Linking](https://openjdk.org/jeps/483), VM options such as `-XX:AOTCache `are implemented as aliases of "classical" CDS options such as `-XX:SharedArchiveFile`. In anticipation of the [JEP: Ahead-of-time Command Line Ergonomics](https://bugs.openjd