Re: RFR: 8336881: [Linux] Support for hierarchical limits for Metrics [v17]

2025-04-01 Thread Severin Gehwolf
> Please review this fix for cgroups-based metrics reporting in the > `jdk.internal.platform` package. This fix is supposed to address wrong > reporting of certain limits if the limits aren't set at the leaf nodes. > > For example, on cg v2, the memory limit interface file is `memory.max`. > Co

Re: RFR: 8353479: jcmd with streaming output breaks intendation

2025-04-01 Thread Alex Menkov
On Tue, 1 Apr 2025 21:23:01 GMT, Alex Menkov wrote: > `outputStream` implementations should call `update_position` from `write` to > correctly handle indentation. > The fix adds the call to `attachStream::write` > > testing: sanity tier1; >in progress: tier2..4,hs-tier5-svc Example of outp

Re: RFR: 8323100: com/sun/tools/attach/StartManagementAgent.java failed with "WaitForSingleObject failed"

2025-04-01 Thread Alex Menkov
On Tue, 1 Apr 2025 05:57:55 GMT, David Holmes wrote: > See bug report for gory details. > > Short version: in the Windows version of `VirtualMachineImpl::execute`, if an > exception occurred after we created the `SocketInputStreamImpl` (which is the > test scenario of the failing test), we wou

Re: RFR: 8352088: Call of com.sun.jdi.ThreadReference.threadGroups() can lock up target VM [v7]

2025-04-01 Thread Serguei Spitsyn
On Tue, 1 Apr 2025 20:00:22 GMT, Chris Plummer wrote: >> Calling ThreadGroupReference.groups() from an event handler can cause a >> deadlock. Details in first comment. Tested with :jdk_lang on all supported >> platforms and tier1, tier2, tier3, and tier5 svc testing. > > Chris Plummer has updat

Debugger overhead for virtual threads creation

2025-04-01 Thread Egor Ushakov
Hi everyone! Is it expected that with the debugger attached creating virtual threads is much slower? We're getting bugs like: https://youtrack.jetbrains.com/issue/IDEA-365900 And I can reproduce it easily with jdb... Just attaching the debugger immediately slows down virtual threads creation s

Integrated: 8323100: com/sun/tools/attach/StartManagementAgent.java failed with "WaitForSingleObject failed"

2025-04-01 Thread David Holmes
On Tue, 1 Apr 2025 05:57:55 GMT, David Holmes wrote: > See bug report for gory details. > > Short version: in the Windows version of `VirtualMachineImpl::execute`, if an > exception occurred after we created the `SocketInputStreamImpl` (which is the > test scenario of the failing test), we wou

Re: RFR: 8323100: com/sun/tools/attach/StartManagementAgent.java failed with "WaitForSingleObject failed"

2025-04-01 Thread David Holmes
On Tue, 1 Apr 2025 18:35:36 GMT, Alex Menkov wrote: >> See bug report for gory details. >> >> Short version: in the Windows version of `VirtualMachineImpl::execute`, if >> an exception occurred after we created the `SocketInputStreamImpl` (which is >> the test scenario of the failing test), we

Re: Debugger overhead for virtual threads creation

2025-04-01 Thread Chris Plummer
The short answer is yes. The debug agent needs to deal with JVMTI_EVENT_VIRTUAL_THREAD_START/END events for every virtual thread. What makes it worse is when there are a large number of virtual threads that are currently alive. They are tracked on a list of ThreadNodes that starts to slow down

RFR: 8353231: Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad still fails intermittently

2025-04-01 Thread Kevin Walls
Test com/sun/management/OperatingSystemMXBean/GetProcessCpuLoad still fails intermittently. On failure, 10 attempts with sleep(200) each time, only read -1 from mbean.getProcessCpuLoad(). The method is documented to return -1 when info is not available, but want to avoid the test accepting a -1

Re: RFR: 8352088: Call of com.sun.jdi.ThreadReference.threadGroups() can lock up target VM [v7]

2025-04-01 Thread Jaikiran Pai
On Tue, 1 Apr 2025 20:00:22 GMT, Chris Plummer wrote: >> Calling ThreadGroupReference.groups() from an event handler can cause a >> deadlock. Details in first comment. Tested with :jdk_lang on all supported >> platforms and tier1, tier2, tier3, and tier5 svc testing. > > Chris Plummer has updat

RFR: 8353479: jcmd with streaming output breaks intendation

2025-04-01 Thread Alex Menkov
`outputStream` implementations should call `update_position` from `write` to correctly handle indentation. The fix adds the call to `attachStream::write` testing: sanity tier1; in progress: tier2..4,hs-tier5-svc - Commit messages: - fix Changes: https://git.openjdk.org/jdk/pull

Re: RFR: 8352088: Call of com.sun.jdi.ThreadReference.threadGroups() can lock up target VM [v7]

2025-04-01 Thread Alan Bateman
On Tue, 1 Apr 2025 20:00:22 GMT, Chris Plummer wrote: >> Calling ThreadGroupReference.groups() from an event handler can cause a >> deadlock. Details in first comment. Tested with :jdk_lang on all supported >> platforms and tier1, tier2, tier3, and tier5 svc testing. > > Chris Plummer has updat

Re: RFR: 8349638: Build libjdwp with SIZE optimization

2025-04-01 Thread Magnus Ihse Bursie
On Tue, 11 Feb 2025 15:56:39 GMT, Matthias Baesken wrote: > The libjdwp is currently built with LOW optimization level, it could be built > with SIZE optimization to lower the lib size by ~ 10 % on UNIX. > On Windows LOW and SIZE currently translate to the same O1 optimization flag > so no diff

Re: RFR: 8352392: AIX: implement attach API v2 and streaming output [v3]

2025-04-01 Thread Martin Doerr
On Tue, 1 Apr 2025 10:32:55 GMT, Varada M wrote: >> src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java line 196: >> >>> 194: } >>> 195: } >>> 196: >> >> Same here. > > Hi Martin, I have added the indentation fix and comment Thanks! I think it's good. Let's wait

Re: RFR: 8352392: AIX: implement attach API v2 and streaming output [v4]

2025-04-01 Thread Varada M
> AIX changes for attach API to support arbitrary length arguments and the > streaming output support. > serviceability/attach/AttachAPIv2/StreamingOutputTest.java test passes > > tier1, tier2 and tier3 testing is successful with fastdebug level > > JBS Issue : [JDK-8352392](https://bugs.openjd

Re: RFR: 8352392: AIX: implement attach API v2 and streaming output [v3]

2025-04-01 Thread Varada M
On Mon, 31 Mar 2025 10:16:31 GMT, Martin Doerr wrote: >> Varada M has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - updated copyright header >> - removed StreamingOutputTest.java from problem list > > src/jdk.attach/aix/classes/sun/tool

Re: RFR: 8341491: Reserve and commit memory operations should be protected by NMT lock

2025-04-01 Thread Stefan Karlsson
On Mon, 31 Mar 2025 14:09:22 GMT, Robert Toyonaga wrote: > OK should I update this PR to do the following things: > > * Add comments explaining the asymmetrical locking and warning against > patterns that lead to races Sounds like a good idea. > > * swapping the order of `NmtVirtualM