Re: RFR: 8352392: AIX: implement attach API v2 and streaming output

2025-03-27 Thread Varada M
On Sun, 23 Mar 2025 14:33:36 GMT, Varada M wrote: > AIX changes for attach API to support arbitrary length arguments and the > streaming output support. > serviceability/attach/AttachAPIv2/StreamingOutputTest.java test passes > > tier1, tier2 and tier3 testing is successful with fastdebug leve

Re: RFR: 8352088: Call of com.sun.jdi.ThreadReference.threadGroups() can lock up target VM [v4]

2025-03-27 Thread Coleen Phillimore
On Wed, 26 Mar 2025 20:50:36 GMT, Chris Plummer wrote: >> Calling ThreadGroupReference.groups() from an event handler can cause a >> deadlock. Details in first comment. Tested with :jdk_lang on all supported >> platforms and tier1, tier2, tier3, and tier5 svc testing. > > Chris Plummer has upda

Re: RFR: 8341491: Reserve and commit memory operations should be protected by NMT lock

2025-03-27 Thread Robert Toyonaga
On Wed, 26 Mar 2025 20:18:43 GMT, Stefan Karlsson wrote: > > > > > I don't understand why we don't treat that as a fatal error OR make > > > > > sure that all call-sites handles that error, which they don't do > > > > > today. > > > > > > > > > > > > I think release/uncommit failures should b

Re: RFR: 8351224: Deprecate com.sun.tools.attach.AttachPermission for removal

2025-03-27 Thread Serguei Spitsyn
On Thu, 20 Mar 2025 14:27:05 GMT, Kevin Walls wrote: > Following on from JEP 486 (Permanently Disable the Security Manager), there > are Permission classes which are unused. These should be deprecated, for > removal in future. Looks good. - Marked as reviewed by sspitsyn (Reviewe

Re: RFR: 8352392: AIX: implement attach API v2 and streaming output

2025-03-27 Thread Alex Menkov
On Sun, 23 Mar 2025 14:33:36 GMT, Varada M wrote: > AIX changes for attach API to support arbitrary length arguments and the > streaming output support. > serviceability/attach/AttachAPIv2/StreamingOutputTest.java test passes > > tier1, tier2 and tier3 testing is successful with fastdebug leve

Withdrawn: 8352392: AIX: implement attach API v2 and streaming output

2025-03-27 Thread Varada M
On Sun, 23 Mar 2025 14:33:36 GMT, Varada M wrote: > AIX changes for attach API to support arbitrary length arguments and the > streaming output support. > serviceability/attach/AttachAPIv2/StreamingOutputTest.java test passes > > tier1, tier2 and tier3 testing is successful with fastdebug leve

Re: RFR: 8352088: Call of com.sun.jdi.ThreadReference.threadGroups() can lock up target VM [v4]

2025-03-27 Thread Alan Bateman
On Wed, 26 Mar 2025 20:50:36 GMT, Chris Plummer wrote: >> Calling ThreadGroupReference.groups() from an event handler can cause a >> deadlock. Details in first comment. Tested with :jdk_lang on all supported >> platforms and tier1, tier2, tier3, and tier5 svc testing. > > Chris Plummer has upda

Re: RFR: 8352088: Call of com.sun.jdi.ThreadReference.threadGroups() can lock up target VM [v2]

2025-03-27 Thread Alan Bateman
On Wed, 26 Mar 2025 20:37:46 GMT, Chris Plummer wrote: >> Yes, one EventHandler thread dispatching to all listeners. More details >> below: >> >> There is an interface called TargetListener which declares all the event >> callbacks. TargetAdapter implements TargetListener and provides and empt

Re: RFR: 8341491: Reserve and commit memory operations should be protected by NMT lock

2025-03-27 Thread Thomas Stuefe
On Wed, 26 Mar 2025 16:43:21 GMT, Stefan Karlsson wrote: > > > > I think release/uncommit failures should be handled by the callers. > > > > Currently, uncommit failure is handled in most places by the caller, > > > > release failure seems mostly not. Since, at least for uncommit, we > > > > c

Re: RFR: 8352088: Call of com.sun.jdi.ThreadReference.threadGroups() can lock up target VM [v4]

2025-03-27 Thread Chris Plummer
On Thu, 27 Mar 2025 11:07:31 GMT, Coleen Phillimore wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove unused locals. > > src/java.base/share/classes/java/lang/ThreadGroup.java line 661: > >> 659: /** >>

Re: RFR: 8352730: RISC-V: Disable tests in qemu-user [v2]

2025-03-27 Thread Robbin Ehn
> Hi, for you to consider. > > These tests constantly fails in qemu-user. > Either the require host to be same arch or they are very very slow in > emulation. > E.g. "ptrace(PTRACE_ATTACH, ..) failed for 405157: Function not implemented'" > for SA tests. > This is the initial set of tests, there

Re: RFR: 8352730: RISC-V: Disable tests in qemu-user [v2]

2025-03-27 Thread Hamlin Li
On Thu, 27 Mar 2025 14:32:18 GMT, Robbin Ehn wrote: >> Hi, for you to consider. >> >> These tests constantly fails in qemu-user. >> Either the require host to be same arch or they are very very slow in >> emulation. >> E.g. "ptrace(PTRACE_ATTACH, ..) failed for 405157: Function not >> implemen

Re: RFR: 8344671: Few JFR streaming tests fail with application not alive error on MacOS 15 [v3]

2025-03-27 Thread David Holmes
On Thu, 27 Mar 2025 22:27:05 GMT, Larry Cable wrote: >> on both Linux and MacOS libattach utilizes UNIX signal (QUIT) to cause a >> target JVM (attachee) to create the socket file used as transport for >> subsequent jcmds (and other attach based interactions) and to listen upon >> that for suc

Re: RFR: 8344671: Few JFR streaming tests fail with application not alive error on MacOS 15 [v3]

2025-03-27 Thread David Holmes
On Mon, 17 Mar 2025 23:44:40 GMT, David Holmes wrote: >> Larry Cable has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Merge branch 'JDK-8344671' of github.com:larry-cable/jdk into JDK-8344671 >> - JDK-8344671: removed JFR tests from pr

Re: RFR: 8344671: Few JFR streaming tests fail with application not alive error on MacOS 15 [v2]

2025-03-27 Thread Larry Cable
> on both Linux and MacOS libattach utilizes UNIX signal (QUIT) to cause a > target JVM (attachee) to create the socket file used as transport for > subsequent jcmds (and other attach based interactions) and to listen upon > that for such. > > it should be noted that the default behavior for QU

Re: RFR: 8344671: Few JFR streaming tests fail with application not alive error on MacOS 15 [v3]

2025-03-27 Thread Larry Cable
> on both Linux and MacOS libattach utilizes UNIX signal (QUIT) to cause a > target JVM (attachee) to create the socket file used as transport for > subsequent jcmds (and other attach based interactions) and to listen upon > that for such. > > it should be noted that the default behavior for QU

Re: RFR: 8352088: Call of com.sun.jdi.ThreadReference.threadGroups() can lock up target VM [v4]

2025-03-27 Thread Serguei Spitsyn
On Wed, 26 Mar 2025 20:50:36 GMT, Chris Plummer wrote: >> Calling ThreadGroupReference.groups() from an event handler can cause a >> deadlock. Details in first comment. Tested with :jdk_lang on all supported >> platforms and tier1, tier2, tier3, and tier5 svc testing. > > Chris Plummer has upda

Re: RFR: 8352088: Call of com.sun.jdi.ThreadReference.threadGroups() can lock up target VM [v4]

2025-03-27 Thread Chris Plummer
On Thu, 27 Mar 2025 20:47:31 GMT, Serguei Spitsyn wrote: > The fix looks okay to me. I guess new test fails with a deadlock without your > fix. Yes. That is the failure mode. There is no detecting the failure other than a timeout. - PR Comment: https://git.openjdk.org/jdk/pull/24