Re: RFR: 8351821: VMManagementImpl.c avoid switching off warnings

2025-03-14 Thread Magnus Ihse Bursie
On Fri, 14 Mar 2025 10:06:32 GMT, Matthias Baesken wrote: > We switched off unused-variable warnings for the file VMManagementImpl.c, > this should be avoided. > This came up in [JDK-8351542](https://bugs.openjdk.org/browse/JDK-8351542) , Build changes look good to me. - Marked as

Re: RFR: 8319055: JCMD should not buffer the whole output of commands [v6]

2025-03-14 Thread Alex Menkov
On Tue, 11 Mar 2025 01:39:55 GMT, Alex Menkov wrote: >> The fix implements streaming output support for attach protocol. >> See JBS issue for evaluation, summary of the changes in the 1st comment. >> Testing: tier1..4,hs-tier5-svc > > Alex Menkov has updated the pull request incrementally with on

Integrated: 8350524: Some hotspot/jtreg/serviceability/dcmd/vm tier1 tests fail on static JDK

2025-03-14 Thread Jiangli Zhou
On Sat, 22 Feb 2025 03:31:53 GMT, Jiangli Zhou wrote: > Please review the fix in following tests to not check for shared libraries > when running on static JDK: > > test/hotspot/jtreg/serviceability/dcmd/vm/DynLibsTest.java > test/hotspot/jtreg/serviceability/dcmd/vm/SystemDumpMapTest.java > te

RFR: 8351821: VMManagementImpl.c avoid switching off warnings

2025-03-14 Thread Matthias Baesken
We switched off unused-variable warnings for the file VMManagementImpl.c, this should be avoided. This came up in [JDK-8351542](https://bugs.openjdk.org/browse/JDK-8351542) , - Commit messages: - JDK-8351821 Changes: https://git.openjdk.org/jdk/pull/24052/files Webrev: https://we

Re: RFR: 8351821: VMManagementImpl.c avoid switching off warnings

2025-03-14 Thread Matthias Baesken
On Fri, 14 Mar 2025 10:06:32 GMT, Matthias Baesken wrote: > We switched off unused-variable warnings for the file VMManagementImpl.c, > this should be avoided. > This came up in [JDK-8351542](https://bugs.openjdk.org/browse/JDK-8351542) , In case someone has a good/better idea what to do with t

Re: RFR: 8351821: VMManagementImpl.c avoid switching off warnings

2025-03-14 Thread Kevin Walls
On Fri, 14 Mar 2025 10:06:32 GMT, Matthias Baesken wrote: > We switched off unused-variable warnings for the file VMManagementImpl.c, > this should be avoided. > This came up in [JDK-8351542](https://bugs.openjdk.org/browse/JDK-8351542) , We know GetOptionalSupport can't realistically fail, unl

Re: RFR: 8351542: LIBMANAGEMENT_OPTIMIZATION remove special optimization settings [v5]

2025-03-14 Thread Matthias Baesken
On Thu, 13 Mar 2025 17:41:28 GMT, Kevin Walls wrote: > Yes seems likely the same history for libverify, so should be good to do the > same update there. I created https://bugs.openjdk.org/browse/JDK-8352015 . - PR Comment: https://git.openjdk.org/jdk/pull/23966#issuecomment-272398

Re: RFR: 8350524: Some hotspot/jtreg/serviceability/dcmd/vm tier1 tests fail on static JDK [v2]

2025-03-14 Thread Jiangli Zhou
On Fri, 14 Mar 2025 06:15:40 GMT, Thomas Stuefe wrote: >> Jiangli Zhou has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address @tstuefe review: >> - Renamed shouldMatchUnconditionally__libjvm to >> shouldMatch__libjvm in SystemMapTest