Re: RFR: 8350903: Remove explicit libjvm.so dependency for libVThreadEventTest

2025-03-02 Thread David Holmes
On Fri, 28 Feb 2025 01:40:34 GMT, Jiangli Zhou wrote: > Please review the test fix that removes `libVThreadEventTest` explicit > dependency to `libjvm`, by removing the call to `JNI_GetCreatedJavaVMs` in > `Agent_OnAttach`. There is a `vm` argument passed via `Agent_OnAttach`. With > the chang

Re: RFR: 8350818: Improve OperatingSystemMXBean cpu load tests to not accept -1.0 by default

2025-03-02 Thread David Holmes
On Fri, 28 Feb 2025 00:05:23 GMT, Leonid Mesnik wrote: > The cpuLoad tests were updated to fail if -1.0 returns to catch bugs like > https://bugs.openjdk.org/browse/JDK-8350820 > > The -1.0 means that JDK can't obtain cpu load. It shouldn't be returned. > If this functionality doesn't work on c

Re: RFR: 8350818: Improve OperatingSystemMXBean cpu load tests to not accept -1.0 by default

2025-03-02 Thread David Holmes
On Fri, 28 Feb 2025 00:05:23 GMT, Leonid Mesnik wrote: > The cpuLoad tests were updated to fail if -1.0 returns to catch bugs like > https://bugs.openjdk.org/browse/JDK-8350820 > > The -1.0 means that JDK can't obtain cpu load. It shouldn't be returned. > If this functionality doesn't work on c

Re: RFR: 8315488: SA ciReplay support is no longer up-to-date with hotspot ciReplay support [v6]

2025-03-02 Thread Coleen Phillimore
> This change removes the ci, c1 and c2 compiler code from the serviceability > agent. The ciReplay functionality is supported inside the jvm and this > duplicated functionality in SA had bit rotted so is removed. > Tested with tier1-4. Coleen Phillimore has updated the pull request incremental

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v17]

2025-03-02 Thread Sergey Chernyshev
On Sun, 2 Mar 2025 19:07:32 GMT, Severin Gehwolf wrote: > OK for me now. `test_cgroupSubsystem_linux.cpp` needs a copyright update as > well. Thanks for your review @jerboaa ! I cheched the test_cgroupSubsystem_linux.cpp, it's already updated to 2025 in the master branch. - PR Co

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v17]

2025-03-02 Thread Severin Gehwolf
On Fri, 28 Feb 2025 20:40:37 GMT, Sergey Chernyshev wrote: >> Cgroup V1 subsustem fails to initialize mounted controllers properly in >> certain cases, that may lead to controllers left undetected/inactive. We >> observed the behavior in CloudFoundry deployments, it affects also host >> syste

Re: RFR: 8315488: SA ciReplay support is no longer up-to-date with hotspot ciReplay support [v5]

2025-03-02 Thread Coleen Phillimore
> This change removes the ci, c1 and c2 compiler code from the serviceability > agent. The ciReplay functionality is supported inside the jvm and this > duplicated functionality in SA had bit rotted so is removed. > Tested with tier1-4. Coleen Phillimore has updated the pull request incremental

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v17]

2025-03-02 Thread Severin Gehwolf
On Sun, 2 Mar 2025 21:17:04 GMT, Sergey Chernyshev wrote: > > OK for me now. `test_cgroupSubsystem_linux.cpp` needs a copyright update as > > well. > > Thanks for your review @jerboaa ! I cheched the > test_cgroupSubsystem_linux.cpp, it's already updated to 2025 in the master > branch. OK!