Re: RFR: 8349088: De-virtualize Codeblob and nmethod [v2]

2025-02-09 Thread Chris Plummer
On Sun, 9 Feb 2025 19:43:29 GMT, Vladimir Kozlov wrote: >> Remove virtual methods from CodeBlob and nmethod to simplify >> saving/restoring in Leyden AOT cache. It avoids the need to patch hidden >> VPTR pointer to class's virtual table. >> >> Added C++ static asserts to make sure no virtual m

Re: RFR: 8349088: De-virtualize Codeblob and nmethod [v2]

2025-02-09 Thread Chris Plummer
On Mon, 10 Feb 2025 02:47:58 GMT, Chris Plummer wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix Zero and Minimal VM builds > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/CodeCache.java line >

Re: RFR: 8342682: Errors related to unused code on Windows after 8339120 in dt_shmem jdwp security and jpackage [v7]

2025-02-09 Thread Julian Waters
On Mon, 11 Nov 2024 09:51:35 GMT, Julian Waters wrote: >> After 8339120, gcc began catching many different instances of unused code in >> the Windows specific codebase. Some of these seem to be bugs. I've taken the >> effort to mark out all the relevant globals and locals that trigger the >> u

RFR: 8349088: De-virtualize Codeblob and nmethod

2025-02-09 Thread Vladimir Kozlov
Remove virtual methods from CodeBlob and nmethod to simplify saving/restoring in Leyden AOT cache. It avoids the need to patch hidden VPTR pointer to class's virtual table. Added C++ static asserts to make sure no virtual methods are added in a future. Fixed/cleaned SA code which process CodeBl

Re: RFR: 8349088: De-virtualize Codeblob and nmethod [v2]

2025-02-09 Thread Vladimir Kozlov
> Remove virtual methods from CodeBlob and nmethod to simplify saving/restoring > in Leyden AOT cache. It avoids the need to patch hidden VPTR pointer to > class's virtual table. > > Added C++ static asserts to make sure no virtual methods are added in a > future. > > Fixed/cleaned SA code whi

Re: RFR: 8349088: De-virtualize Codeblob and nmethod

2025-02-09 Thread Vladimir Kozlov
On Sun, 9 Feb 2025 17:45:30 GMT, Vladimir Kozlov wrote: > Remove virtual methods from CodeBlob and nmethod to simplify saving/restoring > in Leyden AOT cache. It avoids the need to patch hidden VPTR pointer to > class's virtual table. > > Added C++ static asserts to make sure no virtual method