On Thu, 7 Nov 2024 17:25:40 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> previ
On Thu, 7 Nov 2024 13:16:19 GMT, Coleen Phillimore wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @DanHeidinga comment -- exit VM when runtimeSetup() fails
>
> src/hotspot/share/cds/aotConstantPoolResolver.cpp line 2:
On Thu, 7 Nov 2024 12:16:23 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove FIXME
>
> I really wish we did not mess with `_stdcall` and `_cdecl` in this PR. A
> future me chasing
On Mon, 4 Nov 2024 18:15:37 GMT, Kevin Walls wrote:
> This test is sensitive to timing, and should not run with -Xcomp (like
> NotifReconnectDeadlockTest.java).
>
> With -Xcomp, this test can fail on the the conn.getDefaultDomain() call, but
> if we handle that, it can also fail on the first i
On Mon, 4 Nov 2024 18:15:37 GMT, Kevin Walls wrote:
> This test is sensitive to timing, and should not run with -Xcomp (like
> NotifReconnectDeadlockTest.java).
>
> With -Xcomp, this test can fail on the the conn.getDefaultDomain() call, but
> if we handle that, it can also fail on the first i
On Mon, 4 Nov 2024 18:15:37 GMT, Kevin Walls wrote:
> This test is sensitive to timing, and should not run with -Xcomp (like
> NotifReconnectDeadlockTest.java).
>
> With -Xcomp, this test can fail on the the conn.getDefaultDomain() call, but
> if we handle that, it can also fail on the first i
On Wed, 6 Nov 2024 17:55:47 GMT, Kevin Walls wrote:
> A few small cleanup changes in javax/management.
> No logic changes, comments and text only.
This pull request has now been integrated.
Changeset: d2b681d4
Author:Kevin Walls
URL:
https://git.openjdk.org/jdk/commit/d2b681d4557109
On Mon, 4 Nov 2024 18:15:37 GMT, Kevin Walls wrote:
> This test is sensitive to timing, and should not run with -Xcomp (like
> NotifReconnectDeadlockTest.java).
>
> With -Xcomp, this test can fail on the the conn.getDefaultDomain() call, but
> if we handle that, it can also fail on the first i
On Thu, 7 Nov 2024 12:16:23 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove FIXME
>
> I really wish we did not mess with `_stdcall` and `_cdecl` in this PR. A
> future me chasing
On Thu, 7 Nov 2024 00:38:18 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the changes
> Cgroup V1 subsustem fails to initialize mounted controllers properly in
> certain cases, that may lead to controllers left undetected/inactive. We
> observed the behavior in CloudFoundry deployments, it affects also host
> systems.
>
> The relevant /proc/self/mountinfo line is
>
>
> 2207 21
On Thu, 7 Nov 2024 00:38:57 GMT, Patricio Chilano Mateo
wrote:
>>> the call to java_lang_Thread::set_is_in_VTMS_transition()is not needed in
>>> JvmtiUnmountBeginMark
>>>
>> Why is not needed? I guess you meant to say we should use
>> `JvmtiVTMSTransitionDisabler::set_is_in_VTMS_transition()`
On Thu, 7 Nov 2024 00:40:26 GMT, Patricio Chilano Mateo
wrote:
>>> So at some point I think we need to figure out how to make them go away ...
>>
>> Yes, the 2 extension events (`VirtualThreadMount` and
>> `VirtualThreadUnmount`) were added for testing purposes. We wanted to get
>> rid of th
On Thu, 7 Nov 2024 00:38:18 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the changes
On Thu, 31 Oct 2024 15:00:25 GMT, Sergey Chernyshev
wrote:
> Cgroup V1 subsustem fails to initialize mounted controllers properly in
> certain cases, that may lead to controllers left undetected/inactive. We
> observed the behavior in CloudFoundry deployments, it affects also host
> systems.
On Wed, 6 Nov 2024 15:21:10 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
Long-standing nit where an Exception could fail to be reported.
One-character fix to a comparison.
Does not cause any different results in any javax/management tests.
-
Commit messages:
- 8272780: ServerNotifForwarder.removeNotificationListener() incorrect
exception handling
Change
On Fri, 1 Nov 2024 13:13:07 GMT, Sergey Chernyshev
wrote:
> As they're in fact mounting read-write, the logic picked up `rw` mount option
> and falsely detected "host mode". Also the `--privileged` creates `rw`
> mounts, so the entire approach needs correction.
Yes. See https://bugs.openjdk.o
On Thu, 7 Nov 2024 18:32:14 GMT, Serguei Spitsyn wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use JvmtiVTMSTransitionDisabler::VTMS_vthread_mount/unmount
>
> src/hotspot/share/prims/jvmtiThreadState.cp
On Wed, 30 Oct 2024 17:20:49 GMT, Larry Cable wrote:
>> the implementation I originally provided does not in fact solve the issue!
>>
>> the attach protocol initiation "handshake" requires that the "attacher" (the
>> caller of this code) and the "attachee"(the target JVM to be "attached" to)
>
On Wed, 9 Oct 2024 19:45:24 GMT, Kevin Walls wrote:
>> Sebastian Lövdahl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Have EventGeneratorLoop end after a more predictable duration
>
> Yes OEL was Oracle Linux:
>
> Our CI tests with d
On Thu, 7 Nov 2024 18:31:51 GMT, Kim Barrett wrote:
> The grep results are exactly as expected. Thanks for checking that. Now if we
> can just get the build to start checking for us, we can stop needing these
> periodic cleanups. I forget whether a JBS issue has been filed for that. If
> not,
> Cgroup V1 subsustem fails to initialize mounted controllers properly in
> certain cases, that may lead to controllers left undetected/inactive. We
> observed the behavior in CloudFoundry deployments, it affects also host
> systems.
>
> The relevant /proc/self/mountinfo line is
>
>
> 2207 21
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Thu, 7 Nov 2024 09:45:40 GMT, Amit Kumar wrote:
> > I think we can add @requires vm.continuations to this test. It's not useful
> > to run with the alternative virtual thread implementation.
>
> Sure, that sounds ok. Thanks.
>
Added `@requires vm.continuations` to the test.
-
P
On Thu, 7 Nov 2024 08:32:16 GMT, theoweidmannoracle wrote:
>> - Changed several "NULL" in comments to "null"
>> - Changed several `NULL` in code to `nullptr`
>
> theoweidmannoracle has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fix backsli
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Thu, 7 Nov 2024 17:25:40 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> previ
On Thu, 7 Nov 2024 16:09:22 GMT, Chris Plummer wrote:
> What changed that caused it to suddenly start failing a lot?
This is the test I changed recently in JDK-8343378 -- it used to not fail even
if it threw an Exception. So I make that change, test, and see no failures.
But of course -Xcomp
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Thu, 7 Nov 2024 17:25:40 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> previ
On Thu, 7 Nov 2024 17:25:40 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> previ
On Thu, 7 Nov 2024 09:40:19 GMT, Alan Bateman wrote:
>I think we can add @requires vm.continuations to this test. It's not useful to
>run with the alternative virtual thread implementation.
Sure, that sounds ok. Thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/21565#issuecom
On Thu, 7 Nov 2024 12:16:23 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove FIXME
>
> I really wish we did not mess with `_stdcall` and `_cdecl` in this PR. A
> future me chasing
On Mon, 4 Nov 2024 18:15:37 GMT, Kevin Walls wrote:
> This test is sensitive to timing, and should not run with -Xcomp (like
> NotifReconnectDeadlockTest.java).
>
> With -Xcomp, this test can fail on the the conn.getDefaultDomain() call, but
> if we handle that, it can also fail on the first i
On Wed, 6 Nov 2024 17:38:59 GMT, Patricio Chilano Mateo
wrote:
>> Good work! I'll approve the GC related changes.
>>
>> There are some simplifications I think can be done in the ObjectMonitor
>> layer, but nothing that should go into this PR.
>>
>> Similarly, (even if some of this is preexist
On Thu, 7 Nov 2024 12:08:50 GMT, Aleksey Shipilev wrote:
>> src/hotspot/os/windows/os_windows.cpp line 510:
>>
>>> 508: // Thread start routine for all newly created threads.
>>> 509: // Called with the associated Thread* as the argument.
>>> 510: static unsigned thread_native_entry(void* t) {
>
On Wed, 6 Nov 2024 00:56:49 GMT, David Holmes wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix: jvm_md.h was included, but not jvm.h...
>
> src/hotspot/os/windows/os_windows.cpp line 510:
>
>> 508: // Thr
On Wed, 6 Nov 2024 17:55:47 GMT, Kevin Walls wrote:
> A few small cleanup changes in javax/management.
> No logic changes, comments and text only.
Thanks Chris!
-
PR Comment: https://git.openjdk.org/jdk/pull/21938#issuecomment-2462183982
On Mon, 4 Nov 2024 23:57:48 GMT, Ioi Lam wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://openjdk.org/jeps/483).
>>
>>
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https:
On Mon, 4 Nov 2024 18:15:37 GMT, Kevin Walls wrote:
> This test is sensitive to timing, and should not run with -Xcomp (like
> NotifReconnectDeadlockTest.java).
>
> With -Xcomp, this test can fail on the the conn.getDefaultDomain() call, but
> if we handle that, it can also fail on the first i
On Tue, 5 Nov 2024 16:02:07 GMT, Kim Barrett wrote:
> Can you use the (updated) regex in the JBS issue description to verify the
> only remaining "NULL"s in src/hotspot are the jvmti.{xml,xls} files and the
> globalDefinitions_{gcc,visCPP}.hpp files?
>
> There are also some NULLs recently intr
> - Changed several "NULL" in comments to "null"
> - Changed several `NULL` in code to `nullptr`
theoweidmannoracle has updated the pull request incrementally with one
additional commit since the last revision:
Fix backslides in test
-
Changes:
- all: https://git.openjdk.org/jd
On Wed, 6 Nov 2024 17:38:59 GMT, Patricio Chilano Mateo
wrote:
>> Good work! I'll approve the GC related changes.
>>
>> There are some simplifications I think can be done in the ObjectMonitor
>> layer, but nothing that should go into this PR.
>>
>> Similarly, (even if some of this is preexist
On Thu, 7 Nov 2024 12:23:26 GMT, Kevin Walls wrote:
> Long-standing nit where an Exception could fail to be reported.
> One-character fix to a comparison.
> Does not cause any different results in any javax/management tests.
LGTM.
Thanks
-
Marked as reviewed by dholmes (Reviewer).
On Fri, 8 Nov 2024 02:13:09 GMT, David Holmes wrote:
> Can someone confirm that use of `__stdcall` has no affect on name
> decorations, as there is no mention here about anything being ignored:
>
> https://learn.microsoft.com/en-us/cpp/build/reference/decorated-names?view=msvc-170
>
> I would
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://openjdk.org/jeps/483).
>
>
> Note: this is a combined PR of the following individual PRs
> - https://github.com/openjdk/jdk/pull/20516
> - https://github.com/openjdk/jdk/pull/20517
> - https://github.co
On Thu, 7 Nov 2024 19:15:50 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the changes
On Wed, 6 Nov 2024 15:21:10 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Fri, 8 Nov 2024 02:32:42 GMT, Alex Menkov wrote:
> Can someone confirm that use of `__stdcall` has no affect on name
> decorations, as there is no mention here about anything being ignored:
>
> https://learn.microsoft.com/en-us/cpp/build/reference/decorated-names?view=msvc-170
>
> I would h
On Fri, 8 Nov 2024 02:32:42 GMT, Alex Menkov wrote:
> In the page you mentioned:
@alexmenkov that is for C functions, not C++.
-
PR Comment: https://git.openjdk.org/jdk/pull/21744#issuecomment-2463796536
On Fri, 8 Nov 2024 05:26:37 GMT, Julian Waters wrote:
>>> Can someone confirm that use of `__stdcall` has no affect on name
>>> decorations, as there is no mention here about anything being ignored:
>>>
>>> https://learn.microsoft.com/en-us/cpp/build/reference/decorated-names?view=msvc-170
>>>
On Wed, 6 Nov 2024 15:21:10 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Thu, 7 Nov 2024 17:25:40 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> previ
54 matches
Mail list logo
