Re: RFR: 8331385: G1: Prefix HeapRegion helper classes with G1

2024-07-05 Thread Thomas Schatzl
On Tue, 2 Jul 2024 10:21:35 GMT, Albert Mingkun Yang wrote: >> Hi all, >> >> after [JDK-8330694](https://bugs.openjdk.org/browse/JDK-8330694) which >> renamed HeapRegion to G1HeapRegion, there were a few related helper classes >> in this CR that were not renamed. >> >> It's purely mechanic

Integrated: 8331385: G1: Prefix HeapRegion helper classes with G1

2024-07-05 Thread Thomas Schatzl
On Mon, 1 Jul 2024 09:35:00 GMT, Thomas Schatzl wrote: > Hi all, > > after [JDK-8330694](https://bugs.openjdk.org/browse/JDK-8330694) which > renamed HeapRegion to G1HeapRegion, there were a few related helper classes > in this CR that were not renamed. > > It's purely mechanical renaming

Re: RFR: 8335619: Add an @apiNote to j.l.i.ClassFileTransformer to warn about recursive class loading and ClassCircularityErrors [v2]

2024-07-05 Thread Volker Simonis
On Thu, 4 Jul 2024 10:49:47 GMT, Volker Simonis wrote: >> Since Java 5 the `java.lang.instrument` package provides services that allow >> Java programming language agents to instrument (i.e. modify the bytecode) of >> programs running on the Java Virtual Machine. The `java.lang.instrument` >>

Re: RFR: 8335688: Fix -Wzero-as-null-pointer-constant warnings from fflush calls in jvmti tests

2024-07-05 Thread Julian Waters
On Thu, 4 Jul 2024 12:15:09 GMT, Kim Barrett wrote: > Please review this change to some jvmti tests, which were calling fflush with > an argument of 0. Most of these are in C++ code, where we change them to use > nullptr as the argument. A couple are in C, where we change them to use NULL. > Thi

Re: RFR: 8335643: serviceability/dcmd/vm tests fail for ZGC after JDK-8322475

2024-07-05 Thread Thomas Stuefe
On Fri, 5 Jul 2024 06:20:27 GMT, Severin Gehwolf wrote: > @tstuefe Please also remove the problem list entry. See the error from the > skara bot. Thanks! Oh, Skara tells me this now? Or did I never notice :) In any case that's cool. Thanks! - PR Comment: https://git.openjdk.org/j

Re: RFR: 8335643: serviceability/dcmd/vm tests fail for ZGC after JDK-8322475 [v2]

2024-07-05 Thread Thomas Stuefe
> The new System.map facility fails its tests when the JVM is using ZGC. The > facility is working fine, but the test checks for the java heap to appear as > committed non-shared memory segment, but on ZGC we reserve the memory as > shared memory. Thomas Stuefe has updated the pull request incr

RFR: 8335743: jhsdb jstack cannot print some information on the waiting thread

2024-07-05 Thread KIRIYAMA Takuya
This bug was introduced by JDK-8284161. "Object.wait (long timeoutMillis)" was changed to call "Object.wait0 (long timeoutMillis)" in JDK-8284161. When "jhdsb jstack" is executed, the stack and lock information are printed in "sun.jvm.hotspot.runtime.JavaVFrame.printLockInfo(PrintStream tty, int

[jdk23] Integrated: 8322812: Manpage for jcmd is missing JFR.view command

2024-07-05 Thread Erik Gahlin
On Thu, 4 Jul 2024 10:51:48 GMT, Erik Gahlin wrote: > 8322812: Manpage for jcmd is missing JFR.view command This pull request has now been integrated. Changeset: 10b28bab Author:Erik Gahlin URL: https://git.openjdk.org/jdk/commit/10b28babe53821fcdeef3a1aa0712feb7cd67529 Stats: 4

Re: RFR: 8335643: serviceability/dcmd/vm tests fail for ZGC after JDK-8322475 [v2]

2024-07-05 Thread Severin Gehwolf
On Fri, 5 Jul 2024 08:53:30 GMT, Thomas Stuefe wrote: >> The new System.map facility fails its tests when the JVM is using ZGC. The >> facility is working fine, but the test checks for the java heap to appear as >> committed non-shared memory segment, but on ZGC we reserve the memory as >> sha

Re: RFR: 8335643: serviceability/dcmd/vm tests fail for ZGC after JDK-8322475 [v3]

2024-07-05 Thread Thomas Stuefe
> The new System.map facility fails its tests when the JVM is using ZGC. The > facility is working fine, but the test checks for the java heap to appear as > committed non-shared memory segment, but on ZGC we reserve the memory as > shared memory. Thomas Stuefe has updated the pull request incr

[jdk23] Integrated: 8324089: Fix typo in the manual page for "jcmd" (man jcmd)

2024-07-05 Thread Erik Gahlin
On Thu, 4 Jul 2024 10:54:22 GMT, Erik Gahlin wrote: > 8324089: Fix typo in the manual page for "jcmd" (man jcmd) This pull request has now been integrated. Changeset: 90d5b5b4 Author:Erik Gahlin URL: https://git.openjdk.org/jdk/commit/90d5b5b4c497ac99d0e2ade689b6459fffea3e2a Stats:

RFR: 8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file

2024-07-05 Thread Severin Gehwolf
Trivial comment only change in a test. Please review! Thanks! - Commit messages: - 8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file Changes: https://git.openjdk.org/jdk/pull/20051/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20051&range=00 Issue:

Re: RFR: 8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file

2024-07-05 Thread George Adams
On Fri, 5 Jul 2024 11:14:10 GMT, Severin Gehwolf wrote: > Trivial comment only change in a test. Please review! > > Thanks! Marked as reviewed by gdams (Author). - PR Review: https://git.openjdk.org/jdk/pull/20051#pullrequestreview-2160518890

Re: RFR: 8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file

2024-07-05 Thread Thomas Stuefe
On Fri, 5 Jul 2024 11:14:10 GMT, Severin Gehwolf wrote: > Trivial comment only change in a test. Please review! > > Thanks! Good and trivial Marked as reviewed by stuefe (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/20051#pullrequestreview-2160533824 PR Review: https:

Re: RFR: 8335643: serviceability/dcmd/vm tests fail for ZGC after JDK-8322475 [v3]

2024-07-05 Thread Severin Gehwolf
On Fri, 5 Jul 2024 10:56:37 GMT, Thomas Stuefe wrote: >> The new System.map facility fails its tests when the JVM is using ZGC. The >> facility is working fine, but the test checks for the java heap to appear as >> committed non-shared memory segment, but on ZGC we reserve the memory as >> sha

Re: RFR: 8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file

2024-07-05 Thread Severin Gehwolf
On Fri, 5 Jul 2024 11:14:10 GMT, Severin Gehwolf wrote: > Trivial comment only change in a test. Please review! > > Thanks! Thanks for the review! - PR Comment: https://git.openjdk.org/jdk/pull/20051#issuecomment-2210765310

Integrated: 8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file

2024-07-05 Thread Severin Gehwolf
On Fri, 5 Jul 2024 11:14:10 GMT, Severin Gehwolf wrote: > Trivial comment only change in a test. Please review! > > Thanks! This pull request has now been integrated. Changeset: ff49f677 Author:Severin Gehwolf URL: https://git.openjdk.org/jdk/commit/ff49f677ee5017019c90823bc412ceb9

RFR: 8267887: RMIConnector_NPETest.java fails after removal of RMI Activation (JDK-8267123)

2024-07-05 Thread Kevin Walls
The test test/jdk/javax/management/remote/mandatory/connection/RMIConnector_NPETest.java should be removed. This test was added when 6984520 was fixed in 6u25. It has been problemlisted since JDK-8267123 removed RMI Activation (it does not use RMI Activation, it just wanted something "RMI" to

Re: RFR: 8335684: Test ThreadCpuTime.java should pause like ThreadCpuTimeArray.java

2024-07-05 Thread Serguei Spitsyn
On Thu, 4 Jul 2024 10:08:30 GMT, Kevin Walls wrote: > There are two similarly names tests. > Recently: > JDK-8335124: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed > with CPU time out of expected range > ...made a simple change to try and avoid noisy test failures. The same fix