Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v5]

2024-07-01 Thread Sebastian Lövdahl
> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid > (Kubernetes debug container) Sebastian Lövdahl has updated the pull request incrementally with one additional commit since the last revision: Adapt code style - Changes: - all: https://git.openjdk.org/jdk

Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v4]

2024-07-01 Thread Sebastian Lövdahl
On Fri, 28 Jun 2024 18:02:28 GMT, Kevin Walls wrote: >> Sebastian Lövdahl has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add test for the elevated privileges case > > src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java

RFR: 8313235: TestClhsdbJstackLock.java failed with '^\s+- waiting to lock <0x[0-9a-f]+> \(a java\.lang\.Class for LingeredAppWithLock\)$' missing from stdout/stderr

2024-07-01 Thread Chris Plummer
Once the main thread has detected that the spawned thread is in the BLOCKED state, the spawned thread's LingeredAppWithLock.lockMethod() should be visible on the top of the stack, but it is not, so the "waiting to lock" message is missing from the stack trace. I think the explanations mentioned

Re: RFR: 8335291: Problem list all SA core file tests on macosx-aarch64 due to JDK-8318754 [v2]

2024-07-01 Thread Chris Plummer
> On macosx-aarch64, sometimes the generated core file does not contain all > valid memory. This causes SA tests to fail with various address related java > exceptions. There's nothing SA can do to work around the problem, and these > failures over time have been just too noisy, so I'm problem l

Integrated: 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container

2024-07-01 Thread Severin Gehwolf
On Mon, 11 Mar 2024 16:55:36 GMT, Severin Gehwolf wrote: > Please review this enhancement to the container detection code which allows > it to figure out whether the JVM is actually running inside a container > (`podman`, `docker`, `crio`), or with some other means that enforces > memory/cpu l

Re: RFR: 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container [v8]

2024-07-01 Thread Severin Gehwolf
On Fri, 28 Jun 2024 15:41:48 GMT, Severin Gehwolf wrote: >> Please review this enhancement to the container detection code which allows >> it to figure out whether the JVM is actually running inside a container >> (`podman`, `docker`, `crio`), or with some other means that enforces >> memory/c

Re: RFR: 8333891: Method excluded with directive is not compiled after removal of directive [v2]

2024-07-01 Thread Damon Fenacci
On Sat, 22 Jun 2024 09:30:25 GMT, Evgeny Astigeevich wrote: >> A Java method can become non-compilable if there are issues with its >> compilation or if its compiled version causes problems. Additionally, a >> method can be marked as non-compilable using a compile command or a compiler >> dir

Re: RFR: 8269881: SA stack dump fails to include stack trace for SteadyStateThread

2024-07-01 Thread Kevin Walls
On Fri, 28 Jun 2024 20:34:48 GMT, Chris Plummer wrote: > The completely unrelated fix to > [JDK-8335124](https://bugs.openjdk.org/browse/JDK-8335124) led me to believe > that the issue with sometimes not being able to get the stack trace of the > SteadyStateThread might be due to the thread be

Re: RFR: 8313235: TestClhsdbJstackLock.java failed with '^\s+- waiting to lock <0x[0-9a-f]+> \(a java\.lang\.Class for LingeredAppWithLock\)$' missing from stdout/stderr

2024-07-01 Thread Kevin Walls
On Fri, 28 Jun 2024 22:30:52 GMT, Chris Plummer wrote: > Once the main thread has detected that the spawned thread is in the BLOCKED > state, the spawned thread's LingeredAppWithLock.lockMethod() should be > visible on the top of the stack, but it is not, so the "waiting to lock" > message is

Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v5]

2024-07-01 Thread Kevin Walls
On Mon, 1 Jul 2024 07:19:48 GMT, Sebastian Lövdahl wrote: >> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid >> (Kubernetes debug container) > > Sebastian Lövdahl has updated the pull request incrementally with one > additional commit since the last revision: > > Adapt c

Re: [jdk23] RFR: 8326820: Metadata artificially kept alive

2024-07-01 Thread Axel Boldt-Christmas
On Thu, 27 Jun 2024 14:30:43 GMT, Axel Boldt-Christmas wrote: > Hi all, > > This pull request contains a backport of commit > [5909d541](https://github.com/openjdk/jdk/commit/5909d54147355dd7da5786ff39ead4c15816705c) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The c

[jdk23] Integrated: 8326820: Metadata artificially kept alive

2024-07-01 Thread Axel Boldt-Christmas
On Thu, 27 Jun 2024 14:30:43 GMT, Axel Boldt-Christmas wrote: > Hi all, > > This pull request contains a backport of commit > [5909d541](https://github.com/openjdk/jdk/commit/5909d54147355dd7da5786ff39ead4c15816705c) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The c

Re: [jdk23] RFR: 8333542: Breakpoint in parallel code does not work

2024-07-01 Thread Coleen Phillimore
On Fri, 28 Jun 2024 12:14:55 GMT, Coleen Phillimore wrote: > Clean backport of JDK-8333542. After this, we need a backport for > JDK-8335134 to fix the test. Thank you Chris. - PR Comment: https://git.openjdk.org/jdk/pull/19938#issuecomment-210801

[jdk23] Integrated: 8333542: Breakpoint in parallel code does not work

2024-07-01 Thread Coleen Phillimore
On Fri, 28 Jun 2024 12:14:55 GMT, Coleen Phillimore wrote: > Clean backport of JDK-8333542. After this, we need a backport for > JDK-8335134 to fix the test. This pull request has now been integrated. Changeset: 7040de19 Author:Coleen Phillimore URL: https://git.openjdk.org/jdk/co

Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v5]

2024-07-01 Thread Kevin Walls
On Mon, 1 Jul 2024 07:19:48 GMT, Sebastian Lövdahl wrote: >> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid >> (Kubernetes debug container) > > Sebastian Lövdahl has updated the pull request incrementally with one > additional commit since the last revision: > > Adapt c

Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v5]

2024-07-01 Thread Laurence Cable
On 7/1/24 5:59 AM, Kevin Walls wrote: On Mon, 1 Jul 2024 07:19:48 GMT, Sebastian Lövdahl wrote: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) Sebastian Lövdahl has updated the pull request incrementally with one additional commit since

Re: RFR: 8333891: Method excluded with directive is not compiled after removal of directive [v2]

2024-07-01 Thread Evgeny Astigeevich
On Sat, 22 Jun 2024 09:30:25 GMT, Evgeny Astigeevich wrote: >> A Java method can become non-compilable if there are issues with its >> compilation or if its compiled version causes problems. Additionally, a >> method can be marked as non-compilable using a compile command or a compiler >> dir

Re: RFR: 8333891: Method excluded with directive is not compiled after removal of directive [v2]

2024-07-01 Thread Evgeny Astigeevich
On Fri, 28 Jun 2024 15:15:31 GMT, Damon Fenacci wrote: >> Evgeny Astigeevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix data race > > src/hotspot/share/compiler/compileBroker.cpp line 1336: > >> 1334: } >> 1335: >> 1336: A

[jdk23] RFR: 8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout

2024-07-01 Thread Chris Plummer
Clean backport. Need to backport this since it was introduced with the new test in [JDK-8333542](https://bugs.openjdk.org/browse/JDK-8333542), which has also been backpoted to 23. - Commit messages: - Backport 4e8cbf884ab1eee9c3110712ab62edc706e948ba Changes: https://git.openjdk.o

Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v5]

2024-07-01 Thread Sebastian Lövdahl
On Mon, 1 Jul 2024 12:55:24 GMT, Kevin Walls wrote: >(!havePidNSes && nsPid > 1) > I didn't get this at first, I think it's because PID 1 can't have a parent? > (in the same namespace) That was my assumption as well. Is that correct @larry-cable? Maybe it could be worth clarifying with a comm

Re: RFR: 8322812: Manpage for jcmd is missing JFR.view command

2024-07-01 Thread Markus Grönlund
On Fri, 28 Jun 2024 14:51:57 GMT, Erik Gahlin wrote: > Could I have a review of a change to the jcmd man page? A typo was also fixed > for JFR.start. > > Testing: tier1 > > Thanks > Erik Marked as reviewed by mgronlun (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/199

Re: RFR: 8322812: Manpage for jcmd is missing JFR.view command

2024-07-01 Thread Kevin Walls
On Fri, 28 Jun 2024 14:51:57 GMT, Erik Gahlin wrote: > Could I have a review of a change to the jcmd man page? A typo was also fixed > for JFR.start. > > Testing: tier1 > > Thanks > Erik Marked as reviewed by kevinw (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19942

RFR: 8322812: Manpage for jcmd is missing JFR.view command

2024-07-01 Thread Erik Gahlin
Could I have a review of a change to the jcmd man page? A typo was also fixed for JFR.start. Testing: tier1 Thanks Erik - Commit messages: - Don't touch version - Review feedback - Initial Changes: https://git.openjdk.org/jdk/pull/19942/files Webrev: https://webrevs.openjdk.o

Re: RFR: 8269881: SA stack dump fails to include stack trace for SteadyStateThread

2024-07-01 Thread Chris Plummer
On Mon, 1 Jul 2024 09:31:12 GMT, Kevin Walls wrote: >> The completely unrelated fix to >> [JDK-8335124](https://bugs.openjdk.org/browse/JDK-8335124) led me to believe >> that the issue with sometimes not being able to get the stack trace of the >> SteadyStateThread might be due to the thread b

Re: [jdk23] RFR: 8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout

2024-07-01 Thread David Holmes
On Mon, 1 Jul 2024 17:10:44 GMT, Chris Plummer wrote: > Clean backport. Need to backport this since it was introduced with the new > test in [JDK-8333542](https://bugs.openjdk.org/browse/JDK-8333542), which has > also been backpoted to 23. Backport looks accurate. Thanks - Marke

Re: [jdk23] RFR: 8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout

2024-07-01 Thread Chris Plummer
On Mon, 1 Jul 2024 17:10:44 GMT, Chris Plummer wrote: > Clean backport. Need to backport this since it was introduced with the new > test in [JDK-8333542](https://bugs.openjdk.org/browse/JDK-8333542), which has > also been backpoted to 23. Thanks David! Integrating now since without this back

[jdk23] Integrated: 8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout

2024-07-01 Thread Chris Plummer
On Mon, 1 Jul 2024 17:10:44 GMT, Chris Plummer wrote: > Clean backport. Need to backport this since it was introduced with the new > test in [JDK-8333542](https://bugs.openjdk.org/browse/JDK-8333542), which has > also been backpoted to 23. This pull request has now been integrated. Changeset:

Re: RFR: 8332124: Jcmd processing should accept the "help" sub option as command argument [v3]

2024-07-01 Thread Thomas Stuefe
On Fri, 28 Jun 2024 14:39:12 GMT, Sonia Zaldana Calles wrote: >> Sonia Zaldana Calles has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Updating copyright header >> - Modifying usage to --help and -help. Updated ensuing test case to