Re: RFR: 8334287: Man page update for jstatd deprecation [v2]

2024-06-25 Thread Kevin Walls
> Man page update for JDK-8327793 which marked jstatd as deprecated for removal > in JDK 24. Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: text update - Changes: - all: https://git.openjdk.org/jdk/pull/19829/files

Re: RFR: 8334287: Man page update for jstatd deprecation [v2]

2024-06-25 Thread Alan Bateman
On Tue, 25 Jun 2024 08:25:00 GMT, Kevin Walls wrote: >> Man page update for JDK-8327793 which marked jstatd as deprecated for >> removal in JDK 24. > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > text update Marked as revi

Re: RFR: 8334287: Man page update for jstatd deprecation

2024-06-25 Thread Kevin Walls
On Fri, 21 Jun 2024 14:05:51 GMT, Kevin Walls wrote: > Man page update for JDK-8327793 which marked jstatd as deprecated for removal > in JDK 24. Thanks Alan and David, moving to a single line: JSTATD(1) JDK Commands

Re: RFR: 8334287: Man page update for jstatd deprecation [v2]

2024-06-25 Thread Kevin Walls
On Tue, 25 Jun 2024 08:27:38 GMT, Kevin Walls wrote: >> Man page update for JDK-8327793 which marked jstatd as deprecated for >> removal in JDK 24. > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > text update Thanks Alan an

Integrated: 8334287: Man page update for jstatd deprecation

2024-06-25 Thread Kevin Walls
On Fri, 21 Jun 2024 14:05:51 GMT, Kevin Walls wrote: > Man page update for JDK-8327793 which marked jstatd as deprecated for removal > in JDK 24. This pull request has now been integrated. Changeset: baafa662 Author:Kevin Walls URL: https://git.openjdk.org/jdk/commit/baafa662a2f070

Re: RFR: 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container [v6]

2024-06-25 Thread Jan Kratochvil
On Thu, 20 Jun 2024 12:06:43 GMT, Severin Gehwolf wrote: >> Please review this enhancement to the container detection code which allows >> it to figure out whether the JVM is actually running inside a container >> (`podman`, `docker`, `crio`), or with some other means that enforces >> memory/c

Re: RFR: 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container [v6]

2024-06-25 Thread Severin Gehwolf
On Tue, 25 Jun 2024 13:39:07 GMT, Jan Kratochvil wrote: > Currently this patch conflicts a lot with #19085 > (jerboaa:jdk-8331560-cgroup-controller-delegation). Yes, I'll resolve it one way or another depending on which one goes in first. - PR Comment: https://git.openjdk.org/jdk

Re: RFR: 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container [v7]

2024-06-25 Thread Severin Gehwolf
> Please review this enhancement to the container detection code which allows > it to figure out whether the JVM is actually running inside a container > (`podman`, `docker`, `crio`), or with some other means that enforces > memory/cpu limits by means of the cgroup filesystem. If neither of thos

Re: RFR: 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container [v6]

2024-06-25 Thread Severin Gehwolf
On Thu, 20 Jun 2024 17:37:05 GMT, Thomas Stuefe wrote: >> Severin Gehwolf has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove problem listing of PlainRead which is reworked here > > src/hotspot/os/linux/cgroupSubsystem_linux.cpp line

Re: RFR: 8332124: Jcmd processing should accept the "help" sub option as command argument [v2]

2024-06-25 Thread Sonia Zaldana Calles
> Hi all, > > This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124) > enabling jcmd to accept "help" as an argument to subcommands. > > Testing: > - [x] Verified running `jcmd 4711 VM.metaspace help` works along with other > subcommands. > - [x] Added test case passes. >

Re: RFR: 8332124: Jcmd processing should accept the "help" sub option as command argument [v2]

2024-06-25 Thread Kevin Walls
On Tue, 25 Jun 2024 13:55:32 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124) >> enabling jcmd to accept "help" as an argument to subcommands. >> >> Testing: >> - [x] Verified running `jcmd 4711 VM.metaspace help` wo

Re: RFR: 8332124: Jcmd processing should accept the "help" sub option as command argument [v2]

2024-06-25 Thread Laurence Cable
what about '*jcmd help *' not a great deal of additional code for the 'help' jcmd to delegate to the target jcmd? - Larry On 6/25/24 10:15 AM, Kevin Walls wrote: On Tue, 25 Jun 2024 13:55:32 GMT, Sonia Zaldana Calles wrote: Hi all, This PR addresses [8332124](https://bugs.openjdk.org/b

Re: RFR: 8332124: Jcmd processing should accept the "help" sub option as command argument [v2]

2024-06-25 Thread Laurence Cable
and jcmd already supports "help" w/o a target argument, so this pattern is a natural extension, and one which other toolsets have adopted! On 6/25/24 1:28 PM, Laurence Cable wrote: what about '*jcmd help *' not a great deal of additional code for the 'help' jcmd to delegate to the target jcm

Re: RFR: 8332124: Jcmd processing should accept the "help" sub option as command argument [v2]

2024-06-25 Thread Thomas Stuefe
On Tue, 25 Jun 2024 13:55:32 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124) >> enabling jcmd to accept "help" as an argument to subcommands. >> >> Testing: >> - [x] Verified running `jcmd 4711 VM.metaspace help` wo

RFR: 8335137: Disable the SUSPEND_NONE mode of BreakpointOnClassPrepare.java

2024-06-25 Thread SendaoYan
Hi all, The newly added test `com/sun/jdi/BreakpointOnClassPrepare.java` fails at `SUSPEND_NONE` mode. To make this test less noisy, should we disable the SUSPEND_NONE mode for now. - Commit messages: - 8335137: Disable the SUSPEND_NONE mode of BreakpointOnClassPrepare.java Changes