Re: RFR: 8332042: Move MEMFLAGS to its own include file

2024-05-12 Thread Afshin Zafari
On Fri, 10 May 2024 09:06:08 GMT, Thomas Stuefe wrote: > MEMFLAGS, as well as its enum constants, should live in its own include. > > The constants are used throughout the code base, often without needing the > allocation APIs exposed through allocation.hpp. > > The MEMFLAGS enum def is often

Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v2]

2024-05-12 Thread Sebastian Lövdahl
On Mon, 6 May 2024 18:31:06 GMT, Larry Cable wrote: >> Sebastian Lövdahl has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Reworked attach logic > > On 5/6/24 10:35 AM, Sebastian Lövdahl wrote: >> >> I pushed an updated attempt at this now

RFR: 8332098: Add missing `@since` tags to `jdk.jdi`

2024-05-12 Thread Nizar Benalla
Please review this simple change where I add `@since` tags to the package-info file of the following packages ```com.sun.jdi com.sun.jdi.connect com.sun.jdi.connect.spi com.sun.jdi.event com.sun.jdi.request I used the unix `grep` command to find the oldest `@since` in each package and used that

RFR: 8332112: Update nsk.share.Log to don't be Finalizable

2024-05-12 Thread Leonid Mesnik
The nsk.share.Log doing some cleanup and reporting errors in the cleanup method. This method is supposed to be executed by finalizer originally. However, now it is called only during shutdown hook. The cleanup using Cleaner doesn't work. See https://bugs.openjdk.org/browse/JDK-8330760 The clea

Re: RFR: 8330171: Lazy W^X switch implementation

2024-05-12 Thread Dean Long
On Fri, 12 Apr 2024 14:40:05 GMT, Sergey Nazarkin wrote: > An alternative for preemptively switching the W^X thread mode on macOS with > an AArch64 CPU. This implementation triggers the switch in response to the > SIGBUS signal if the *si_addr* belongs to the CodeCache area. With this > approa

Re: RFR: 8332112: Update nsk.share.Log to don't be Finalizable

2024-05-12 Thread David Holmes
On Sun, 12 May 2024 21:34:41 GMT, Leonid Mesnik wrote: > The nsk.share.Log doing some cleanup and reporting errors in the cleanup > method. This method is supposed to be executed by finalizer originally. > However, now it is called only during shutdown hook. > The cleanup using Cleaner doesn't

Re: RFR: 8330988: Implementation of 8288293: Windows/gcc Port for hsdis

2024-05-12 Thread Julian Waters
On Wed, 24 Apr 2024 09:15:21 GMT, Magnus Ihse Bursie wrote: >> WIP >> >> This changeset contains hsdis for Windows/gcc Port. It supports both the >> binutils and capstone backends, though the LLVM backend is left out due to >> compatibility issues encountered during the build. Currently, which

Re: RFR: 8332042: Move MEMFLAGS to its own include file [v2]

2024-05-12 Thread Thomas Stuefe
> MEMFLAGS, as well as its enum constants, should live in its own include. > > The constants are used throughout the code base, often without needing the > allocation APIs exposed through allocation.hpp. > > The MEMFLAGS enum def is often needed within NMT itself, again often without > needing

Re: RFR: 8332042: Move MEMFLAGS to its own include file [v2]

2024-05-12 Thread Johan Sjölen
On Mon, 13 May 2024 04:55:24 GMT, Thomas Stuefe wrote: >> MEMFLAGS, as well as its enum constants, should live in its own include. >> >> The constants are used throughout the code base, often without needing the >> allocation APIs exposed through allocation.hpp. >> >> The MEMFLAGS enum def is

Re: RFR: 8332098: Add missing `@since` tags to `jdk.jdi`

2024-05-12 Thread Alan Bateman
On Sun, 12 May 2024 01:58:38 GMT, Nizar Benalla wrote: > Please review this simple change where I add `@since` tags to the > package-info file of the following packages > ```com.sun.jdi > com.sun.jdi.connect > com.sun.jdi.connect.spi > com.sun.jdi.event > com.sun.jdi.request > > I used the unix