Re: RFR: 8329774: Break long lines in jdk/src/jdk.hotspot.agent/doc /transported_core.html [v2]

2024-04-11 Thread Ludvig Janiuk
> I used "fold -sw 120" and removed trailing whitespaces. Ludvig Janiuk has updated the pull request incrementally with three additional commits since the last revision: - prepends - fold 100 - Revert "8329774 Break long lines in jdk/src/jdk.hotspot.agent/doc /transported_core.html" T

Re: RFR: 8329774: Break long lines in jdk/src/jdk.hotspot.agent/doc /transported_core.html

2024-04-11 Thread Ludvig Janiuk
On Fri, 5 Apr 2024 12:50:04 GMT, Ludvig Janiuk wrote: > I used "fold -sw 120" and removed trailing whitespaces. I followed your suggestion, and also fixed a typo. - PR Comment: https://git.openjdk.org/jdk/pull/18654#issuecomment-2049055211

Re: RFR: 8329774: Break long lines in jdk/src/jdk.hotspot.agent/doc /transported_core.html [v2]

2024-04-11 Thread Kevin Walls
On Thu, 11 Apr 2024 07:12:20 GMT, Ludvig Janiuk wrote: >> I used "fold -sw 120" and removed trailing whitespaces. > > Ludvig Janiuk has updated the pull request incrementally with three > additional commits since the last revision: > > - prepends > - fold 100 > - Revert "8329774 Break long l

Re: RFR: 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container

2024-04-11 Thread Severin Gehwolf
On Mon, 11 Mar 2024 16:55:36 GMT, Severin Gehwolf wrote: > Please review this enhancement to the container detection code which allows > it to figure out whether the JVM is actually running inside a container > (`podman`, `docker`, `crio`), or with some other means that enforces > memory/cpu l

Integrated: 8329774: Break long lines in jdk/src/jdk.hotspot.agent/doc /transported_core.html

2024-04-11 Thread Ludvig Janiuk
On Fri, 5 Apr 2024 12:50:04 GMT, Ludvig Janiuk wrote: > I used "fold -sw 120" and removed trailing whitespaces. This pull request has now been integrated. Changeset: 9acce7a6 Author:Ludvig Janiuk URL: https://git.openjdk.org/jdk/commit/9acce7a6f326543c302ca0408213cf333f5f778a Stats:

Re: RFR: 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container [v2]

2024-04-11 Thread Severin Gehwolf
> Please review this enhancement to the container detection code which allows > it to figure out whether the JVM is actually running inside a container > (`podman`, `docker`, `crio`), or with some other means that enforces > memory/cpu limits by means of the cgroup filesystem. If neither of thos

Re: RFR: 8240343: JDI stopListening/stoplis001 "FAILED: listening is successfully stopped without starting listening" [v2]

2024-04-11 Thread Serguei Spitsyn
On Wed, 10 Apr 2024 17:36:32 GMT, Alex Menkov wrote: >> The test starts listening on dynamic port and calls stopListening with >> incorrect (cArgs1) and correct (cArgs2) argument maps. >> Incorrect map is created by finding "free" port (`(new >> ServerSocket(0)).getLocalPort()`) >> The test fai

Fwd: RFO: a tool to analyze HotSpot fatal error logs

2024-04-11 Thread Laurence Cable
Forwarded Message Subject:RFO: a tool to analyze HotSpot fatal error logs Date: Thu, 11 Apr 2024 18:05:44 +0400 From: Maxim Kartashev To: disc...@openjdk.org, hotspot-...@openjdk.org Hello, I am writing to inquire about the potential interest of the people

Re: RFR: 8329674: JvmtiEnvThreadState::reset_current_location function should use JvmtiHandshake [v2]

2024-04-11 Thread Patricio Chilano Mateo
On Wed, 10 Apr 2024 04:21:23 GMT, Serguei Spitsyn wrote: >> The internal JVM TI JvmtiHandshake and JvmtiUnitedHandshakeClosure classes >> were introduced in the JDK 22 to unify/simplify the JVM TI functions >> supporting implementation of the virtual threads. This enhancement is to >> refactor

Re: RFR: 8303689: javac -Xlint could/should report on "dangling" doc comments [v2]

2024-04-11 Thread Jonathan Gibbons
> Please review the updates to support a proposed new > `-Xlint:dangling-doc-comments` option. > > The work can be thought of as in 3 parts: > > 1. An update to the `javac` internal class `DeferredLintHandler` so that it > is possible to specify the appropriately configured `Lint` object when i

Re: RFR: 8329674: JvmtiEnvThreadState::reset_current_location function should use JvmtiHandshake [v2]

2024-04-11 Thread Serguei Spitsyn
On Thu, 11 Apr 2024 16:22:44 GMT, Patricio Chilano Mateo wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: refactored to get rid of overloaded doit functions > > src/hotspot/share/prims/jvmtiEnvThreadStat

Re: RFR: 8329674: JvmtiEnvThreadState::reset_current_location function should use JvmtiHandshake [v2]

2024-04-11 Thread Serguei Spitsyn
On Thu, 11 Apr 2024 16:25:30 GMT, Patricio Chilano Mateo wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: refactored to get rid of overloaded doit functions > > src/hotspot/share/prims/jvmtiEnvThreadStat

Re: RFR: 8329674: JvmtiEnvThreadState::reset_current_location function should use JvmtiHandshake [v2]

2024-04-11 Thread Serguei Spitsyn
On Thu, 11 Apr 2024 16:26:51 GMT, Patricio Chilano Mateo wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: refactored to get rid of overloaded doit functions > > src/hotspot/share/prims/jvmtiEnvThreadStat

Re: RFR: 8329674: JvmtiEnvThreadState::reset_current_location function should use JvmtiHandshake [v2]

2024-04-11 Thread Serguei Spitsyn
On Thu, 11 Apr 2024 22:54:16 GMT, Serguei Spitsyn wrote: >> src/hotspot/share/prims/jvmtiEnvThreadState.cpp line 367: >> >>> 365: GetCurrentLocationClosure op; >>> 366: JvmtiHandshake::execute(&op, &tlh, thread, thread_h); >>> 367: >> >> Seems we are missing a JvmtiVTMSTransitionDi

RFR: 8322043: HeapDumper should use parallel dump by default

2024-04-11 Thread Alex Menkov
The fix makes VM heap dumping parallel by default. `jcmd GC.heap_dump` and `jmap -dump` had parallel dumping by default, the fix affects `HotSpotDiagnosticMXBean.dumpHeap()`, `-XX:+HeapDumpBeforeFullGC`, `-XX:+HeapDumpAfterFullGC` and `-XX:+HeapDumpOnOutOfMemoryError`. Testing: - manually test

Re: RFR: 8322043: HeapDumper should use parallel dump by default

2024-04-11 Thread Thomas Stuefe
On Fri, 12 Apr 2024 02:17:34 GMT, Alex Menkov wrote: > The fix makes VM heap dumping parallel by default. > `jcmd GC.heap_dump` and `jmap -dump` had parallel dumping by default, the fix > affects `HotSpotDiagnosticMXBean.dumpHeap()`, `-XX:+HeapDumpBeforeFullGC`, > `-XX:+HeapDumpAfterFullGC` and