On Fri, 16 Feb 2024 05:25:44 GMT, Thomas Stuefe wrote:
> > > Hi,
> > > some remarks:
> > >
> > > * there is no need for a copy for the first call to dll_load_library.
> > > Just hand in the string 1:1.
> > > * I would only do the *.a fallback loading if the error indicates that
> > > the *.so
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or if jcheck
> changes how it checks files (perhaps due to bug fixes).
>
> I hav
On Thu, 15 Feb 2024 17:53:41 GMT, Naoto Sato wrote:
>> `\u000b` is VT (vertical tab)
>> `\u0009` or `\t` perhaps?
>
> Right. `\t` is better to avoid such a mistake.
Ok, fixed.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/17871#discussion_r1492403403
On Fri, 16 Feb 2024 12:25:39 GMT, Suchismith Roy wrote:
> > > > Hi,
> > > > some remarks:
> > > >
> > > > * there is no need for a copy for the first call to dll_load_library.
> > > > Just hand in the string 1:1.
> > > > * I would only do the *.a fallback loading if the error indicates that
>
On Thu, 15 Feb 2024 08:46:43 GMT, Serguei Spitsyn wrote:
> This enhancement replaces uses of NULL with nullptr in the XML-description
> files for JVMTI. These are the files `hotsport/share/prims/jvmti.xml` and
> `hotspot/share/prims/jvmti*.xls`.
>
> The following files are auto-generated from
On Fri, 16 Feb 2024 12:43:25 GMT, Magnus Ihse Bursie wrote:
>> Since jcheck only checks file in a commit, there is a possibility of us
>> getting files in the repository that would not be accepted by jcheck. This
>> can happen when extending the set of files checked by jcheck, or if jcheck
>>
On Fri, 16 Feb 2024 01:23:42 GMT, Alex Menkov wrote:
> When I proposed this change 10 years ago, there was a push back:
> https://bugs.openjdk.org/browse/JDK-8005604.
Right, the HPROF format was created to be independent of VM or any
configuration. So JDK-8176520 is not really a bug, instead i
On Fri, 16 Feb 2024 12:43:25 GMT, Magnus Ihse Bursie wrote:
>> Since jcheck only checks file in a commit, there is a possibility of us
>> getting files in the repository that would not be accepted by jcheck. This
>> can happen when extending the set of files checked by jcheck, or if jcheck
>>
Merging a super class into its single sub class.
Test: tier1-6
-
Commit messages:
- merge-space
Changes: https://git.openjdk.org/jdk/pull/17891/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17891&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8326065
Stats: 401 l
On Fri, 16 Feb 2024 17:00:15 GMT, Albert Mingkun Yang wrote:
> Merging a super class into its single sub class.
>
> Test: tier1-6
The changes look good. It looks like the GenerationFactory removal is something
that should have previously been done. Is that the case, or is there something
abou
On Fri, 16 Feb 2024 18:48:47 GMT, Chris Plummer wrote:
> It looks like the GenerationFactory removal is something that should have
> previously been done.
True; I overlooked it until the removal of `SpaceClosure` in this PR.
-
PR Comment: https://git.openjdk.org/jdk/pull/17891#iss
On Thu, 15 Feb 2024 08:46:43 GMT, Serguei Spitsyn wrote:
> This enhancement replaces uses of NULL with nullptr in the XML-description
> files for JVMTI. These are the files `hotsport/share/prims/jvmti.xml` and
> `hotspot/share/prims/jvmti*.xls`.
>
> The following files are auto-generated from
On Fri, 16 Feb 2024 15:25:38 GMT, Alan Bateman wrote:
> > When I proposed this change 10 years ago, there was a push back:
> > https://bugs.openjdk.org/browse/JDK-8005604.
>
> Right, the HPROF format was created to be independent of VM or any
> configuration. So JDK-8176520 is not really a bug
On Thu, 15 Feb 2024 08:46:43 GMT, Serguei Spitsyn wrote:
> This enhancement replaces uses of NULL with nullptr in the XML-description
> files for JVMTI. These are the files `hotsport/share/prims/jvmti.xml` and
> `hotspot/share/prims/jvmti*.xls`.
>
> The following files are auto-generated from
Please review this trivial change that renames the file
test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/aod/jvmti_aod.h to jvmti_aod.hpp,
and replace uses of NULL in the file.
The #include updates were performed mechanically, and build would fail if
there were mistakes. All of the including files ha
On Thu, 15 Feb 2024 02:45:26 GMT, Alex Menkov wrote:
>> The fix updates heap dumpers to report correct instance size value for
>> HPROF_GC_CLASS_DUMP records (currently it's reported as size of all instance
>> fields)
>>
>> Testing: tier1, tier2, tier5-svc
>
> Alex Menkov has updated the pull
On Sat, 17 Feb 2024 01:40:44 GMT, Chris Plummer wrote:
> Can't the instance size as currently computed be computed by hprof tool
> vendors using class information already present in the hprof file (list of
> class fields and types, class hierarchy info, etc)? If so, then they have
> recourse i
> The fix updates heap dumpers to report correct instance size value for
> HPROF_GC_CLASS_DUMP records (currently it's reported as size of all instance
> fields)
>
> Testing: tier1, tier2, tier5-svc
Alex Menkov has updated the pull request incrementally with one additional
commit since the las
18 matches
Mail list logo
