On Wed, 24 Jan 2024 22:30:38 GMT, Jiangli Zhou wrote:
> Maybe we could live with symbol redefinition using #define (conditionally for
> static linking in OpenJDK, as Coleen suggested earlier) for now, until the
> tooling can support symbol localizing better. Then localizing symbols using
> too
On Sat, 27 Jan 2024 17:38:59 GMT, Suchismith Roy wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library ibm_16_am
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8324668?
>
> This change proposes to fix the issue in jdwp where when launching a child
> process (for the `launch=` option), it iterates over an extremely large
> number of file descripto
On Sat, 27 Jan 2024 13:09:45 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
On Mon, 29 Jan 2024 04:36:35 GMT, David Holmes wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - log a warning message if we fallback to slower logic of closing file
>> descriptors
>> - ignore return values, cast
> This mechanically replaces NULL with nullptr in hpp/cpp native files in test
> native code. This didn't attempt to change NULL in comments to say null
> because nullptr is generally the right thing for the comment to say. It does
> attempt to change NULL to "null" rather than "nullptr" in st
On Sun, 28 Jan 2024 22:33:01 GMT, Rafael Winterhalter
wrote:
> What stops people from supplying a fake instance? Wouldn't you need to "test
> run" the instance first?
Not necessarily. When the generated API implementation relies on the
capabilities of class `Instrumentation` -- such as openin
On Mon, 29 Jan 2024 14:09:40 GMT, Andrew Dinn wrote:
> What stops people from supplying a fake instance? Wouldn't you need to "test
> run" the instance first?
In passing, Instrumentation was a candidate to be sealed at one point as the
only implementations should be in the java.instrument modu
On Mon, 29 Jan 2024 13:47:10 GMT, Coleen Phillimore wrote:
>> This mechanically replaces NULL with nullptr in hpp/cpp native files in test
>> native code. This didn't attempt to change NULL in comments to say null
>> because nullptr is generally the right thing for the comment to say. It
>>
On Fri, 16 Apr 2021 20:30:15 GMT, Rafael Winterhalter
wrote:
>> To allow agents the definition of auxiliary classes, an API is needed to
>> allow this. Currently, this is often achieved by using `sun.misc.Unsafe` or
>> `jdk.internal.misc.Unsafe` ever since the `defineClass` method was removed
On Sat, 27 Jan 2024 05:11:28 GMT, Alexander Kriegisch wrote:
> Bytecode transformation should not be rocket science, but it progressively is
> developing in that direction.
Hmm? Bytecode transformation of the JDK runtime implementation is a lot more
complicated than your comments seem to ackno
We have the text "host-or-interface-name" describing the
com.sun.management.jmxremote.host property in management.properties, but
interface names (like "eth0" or "lo", or "ens3"...) are not what it accepts.
It should just say it needs to be a host name or address.
This change only affects comm
On Mon, 29 Jan 2024 14:45:24 GMT, Kevin Walls wrote:
> We have the text "host-or-interface-name" describing the
> com.sun.management.jmxremote.host property in management.properties, but
> interface names (like "eth0" or "lo", or "ens3"...) are not what it accepts.
> It should just say it nee
On Mon, 29 Jan 2024 13:47:10 GMT, Coleen Phillimore wrote:
>> This mechanically replaces NULL with nullptr in hpp/cpp native files in test
>> native code. This didn't attempt to change NULL in comments to say null
>> because nullptr is generally the right thing for the comment to say. It
>>
On Fri, 26 Jan 2024 16:40:32 GMT, Coleen Phillimore wrote:
> This mechanically replaces NULL with nullptr in hpp/cpp native files in test
> native code. This didn't attempt to change NULL in comments to say null
> because nullptr is generally the right thing for the comment to say. It does
>
On Mon, 29 Jan 2024 10:00:37 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
On Sat, 27 Jan 2024 01:18:09 GMT, Jaikiran Pai wrote:
>> src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c line 129:
>>
>>> 127: * and assume all were opened for the parent process and
>>> 128: * copied over to this child process. we close them all */
>>> 129: const rlim
On Mon, 29 Jan 2024 17:51:36 GMT, Gerard Ziemski wrote:
>> Jaikiran Pai has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - add a log message to help debuggability
>> - improve code comments
>> - David's review - use standard isdigit i
On Mon, 29 Jan 2024 10:00:37 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
On Mon, 29 Jan 2024 14:31:10 GMT, Andrew Dinn wrote:
> > Bytecode transformation should not be rocket science, but it progressively
> > is developing in that direction.
>
> Hmm? Bytecode transformation of the JDK runtime implementation is a lot more
> complicated than your comments seem to ack
Please review this trivial change that renames the file
test/hotspot/jtreg/serviceability/jvmti/thread/GetStackTrace/get_stack_trace.h
to get_stack_trace.hpp, and renames uses of NULL in that file.
The updates to #include lines in using files were performed mechanically.
Testing: mach5 tier1
---
On Fri, 10 Nov 2023 10:41:16 GMT, Roman Kennke wrote:
>> See JBS issue for details.
>>
>> I basically:
>> - took the test-modification and turned it into its own test-case
>> - added test runners for lightweight- and legacy-locking, so that we keep
>> testing both, no matter what is the defau
On Mon, 29 Jan 2024 09:42:20 GMT, Andrew Haley wrote:
> > Maybe we could live with symbol redefinition using #define (conditionally
> > for static linking in OpenJDK, as Coleen suggested earlier) for now, until
> > the tooling can support symbol localizing better. Then localizing symbols
> > u
On Mon, 29 Jan 2024 19:21:05 GMT, Chris Plummer wrote:
>> src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c line 108:
>>
>>> 106: if (isdigit(dirp->d_name[0]) &&
>>> 107: (fd = strtol(dirp->d_name, NULL, 10)) >= from_fd) {
>>> 108: (void)close(fd);
>>
>> I'd reall
On Mon, 29 Jan 2024 19:25:35 GMT, Chris Plummer wrote:
>> Jaikiran Pai has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - add a log message to help debuggability
>> - improve code comments
>> - David's review - use standard isdigit in
On Mon, 29 Jan 2024 10:00:37 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child
>> process (for the `launch=` option), it
On Tue, 30 Jan 2024 06:47:38 GMT, David Holmes wrote:
> If we are going to check close for errors then we will have to know for
> certain we are only trying to close open fd's, and we will have to deal with
> EINTR. I would think this is a "best effort" to close open FD's and not
> something w
On Tue, 30 Jan 2024 03:43:15 GMT, Kim Barrett wrote:
> Please review this trivial change that renames the file
> test/hotspot/jtreg/serviceability/jvmti/thread/GetStackTrace/get_stack_trace.h
> to get_stack_trace.hpp, and renames uses of NULL in that file.
>
> The updates to #include lines in us
28 matches
Mail list logo
