On Tue, 9 Jan 2024 02:30:05 GMT, David Holmes wrote:
> Trivial fix to the formatting of "argument" lists for a few sub-commands.
> Thanks
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17318#pullrequestreview-1810601092
On Tue, 9 Jan 2024 08:10:44 GMT, Alan Bateman wrote:
>> Trivial fix to the formatting of "argument" lists for a few sub-commands.
>> Thanks
>
> Marked as reviewed by alanb (Reviewer).
Thanks for the review @AlanBateman !
-
PR Comment: https://git.openjdk.org/jdk/pull/17318#issuecom
On Tue, 9 Jan 2024 02:30:05 GMT, David Holmes wrote:
> Trivial fix to the formatting of "argument" lists for a few sub-commands.
> Thanks
This pull request has now been integrated.
Changeset: 075fed91
Author:David Holmes
URL:
https://git.openjdk.org/jdk/commit/075fed91bd144d94328e19
On Mon, 8 Jan 2024 20:16:50 GMT, Chris Plummer wrote:
> Fix some broken links and other minor cleanups:
>
> There are a few broken links in the javadoc for ObjectReference.java. For
> example:
>
>
> * Not all target VMs support this operation. See
> * VirtualMachine#canGetMonitorIn
On Tue, 9 Jan 2024 18:44:04 GMT, Alan Bateman wrote:
>> Fix some broken links and other minor cleanups:
>>
>> There are a few broken links in the javadoc for ObjectReference.java. For
>> example:
>>
>>
>> * Not all target VMs support this operation. See
>> * VirtualMachine#canGetMo
On Tue, 9 Jan 2024 07:24:57 GMT, Serguei Spitsyn wrote:
>> Fix some broken links and other minor cleanups:
>>
>> There are a few broken links in the javadoc for ObjectReference.java. For
>> example:
>>
>>
>> * Not all target VMs support this operation. See
>> * VirtualMachine#canGe
On Sat, 16 Dec 2023 02:15:16 GMT, Alex Menkov wrote:
> HeapDumper dumps virtual threads in 2 places:
> - dumping platform threads (mounted virtual threads are dumped as separate
> thread object);
> - dumping heap objects when the object is `java.lang.VirtualThread`.
>
> In the 2nd case mounted
On Tue, 9 Jan 2024 19:09:33 GMT, Chris Plummer wrote:
>> src/jdk.jdi/share/classes/com/sun/jdi/ObjectReference.java line 331:
>>
>>> 329: * false otherwise.
>>> 330: * @throws VMCannotBeModifiedException if the VirtualMachine is
>>> read-only
>>> 331: * - see {@link VirtualMachin
On Tue, 9 Jan 2024 20:00:29 GMT, Alan Bateman wrote:
>> There are a lot of places where we use `see` in this manner, because it
>> applies specifically to the text that proceeds it. These 3 were different in
>> that the space was missing.
>
> Personally I wouldn't not use this style, instead I
On Wed, 13 Dec 2023 21:32:50 GMT, Alex Menkov wrote:
> FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate
> class fields in the reverse order and use field indexes to access instead of
> forward iteration. This is performance ineffective (see
> [JDK-8317692](https://bugs.
On Tue, 9 Jan 2024 19:08:11 GMT, Chris Plummer wrote:
>> src/jdk.jdi/share/classes/com/sun/jdi/VirtualMachine.java line 681:
>>
>>> 679: * class prepare events by source name.
>>> 680: *
>>> 681: * @see ClassPrepareRequest#addSourceNameFilter
>>
>> It is not clear why the link ha
On Wed, 13 Dec 2023 21:32:50 GMT, Alex Menkov wrote:
> FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate
> class fields in the reverse order and use field indexes to access instead of
> forward iteration. This is performance ineffective (see
> [JDK-8317692](https://bugs.
On Wed, 20 Dec 2023 21:28:04 GMT, Serguei Spitsyn wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [0f8e4e0a](https://github.com/openjdk/jdk/commit/0f8e4e0a81257c678e948c341a241dc0b810494f)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
This fix adds a ResourceMark missing in the `SetFramePopClosure::do_thread` and
`SetFramePopClosure::do_vthread`.
Testing:
- TBD to submit tiers: 1-5
-
Commit messages:
- 8321685: Missing ResourceMark in code called from
JvmtiEnvBase::get_vthread_jvf
Changes: https://git.openjdk
Backport of
https://github.com/openjdk/jdk/commit/075fed91bd144d94328e198b41ea2946961940e9
which was reviewed by Alan Bateman.
The backport is not clean as one item in mainline does not exist in JDK 22.
Thanks.
-
Commit messages:
- Backport 075fed91bd144d94328e198b41ea2946961940e
The change fixes workaround introduced by JDK-8250630.
Submitter confirmed that the fix resolved the issue.
Testing: tier1, all JDI-related tests (test/hotspot/jtreg/vmTestbase/nsk/jdwp,
test/hotspot/jtreg/vmTestbase/nsk/jdi, test/hotspot/jtreg/vmTestbase/nsk/jdb,
test/jdk/com/sun/jdi)
On Tue, 9 Jan 2024 23:48:35 GMT, Serguei Spitsyn wrote:
> This fix adds a ResourceMark missing in the `SetFramePopClosure::do_thread`
> and `SetFramePopClosure::do_vthread`.
>
> Testing:
> - TBD to submit tiers: 1-5
Marked as reviewed by amenkov (Reviewer).
-
PR Review: https://
On Tue, 9 Jan 2024 23:48:35 GMT, Serguei Spitsyn wrote:
> This fix adds a ResourceMark missing in the `SetFramePopClosure::do_thread`
> and `SetFramePopClosure::do_vthread`.
>
> Testing:
> - TBD to submit tiers: 1-5
Looks good. Note, it would be good if the jvmti code added comments explainin
> FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate
> class fields in the reverse order and use field indexes to access instead of
> forward iteration. This is performance ineffective (see
> [JDK-8317692](https://bugs.openjdk.org/browse/JDK-8317692) for details).
> The cha
On Wed, 10 Jan 2024 01:53:36 GMT, David Holmes wrote:
> Backport of
> https://github.com/openjdk/jdk/commit/075fed91bd144d94328e198b41ea2946961940e9
> which was reviewed by Alan Bateman.
>
> The backport is not clean as one item in mainline does not exist in JDK 22.
>
> Thanks.
Looks good.
On Wed, 10 Jan 2024 01:53:02 GMT, Alex Menkov wrote:
> The change fixes workaround introduced by JDK-8250630.
> Submitter confirmed that the fix resolved the issue.
>
> Testing: tier1, all JDI-related tests
> (test/hotspot/jtreg/vmTestbase/nsk/jdwp,
> test/hotspot/jtreg/vmTestbase/nsk/jdi, tes
On Wed, 10 Jan 2024 02:43:57 GMT, Chris Plummer wrote:
> There's no explanation here of the root cause and how the fix solves it, and
> the CR has too much discussion to wade through.
Sorry, my fault. Without explanation the fix may look not as simple as it is.
It's a typo in the code - need to
On Wed, 10 Jan 2024 02:40:45 GMT, Chris Plummer wrote:
>> Backport of
>> https://github.com/openjdk/jdk/commit/075fed91bd144d94328e198b41ea2946961940e9
>> which was reviewed by Alan Bateman.
>>
>> The backport is not clean as one item in mainline does not exist in JDK 22.
>>
>> Thanks.
>
> Lo
On Wed, 10 Jan 2024 01:53:36 GMT, David Holmes wrote:
> Backport of
> https://github.com/openjdk/jdk/commit/075fed91bd144d94328e198b41ea2946961940e9
> which was reviewed by Alan Bateman.
>
> The backport is not clean as one item in mainline does not exist in JDK 22.
>
> Thanks.
This pull req
On Wed, 10 Jan 2024 01:53:02 GMT, Alex Menkov wrote:
> The change fixes workaround introduced by
> [[JDK-8250630]](https://bugs.openjdk.org/browse/JDK-8250630).
> The root cause of the test failure was identified by JDK-8250630:
> On Apline Linux getaddrinfo function returns 2 entries for "any"
On Wed, 10 Jan 2024 02:39:33 GMT, Alex Menkov wrote:
>> FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate
>> class fields in the reverse order and use field indexes to access instead of
>> forward iteration. This is performance ineffective (see
>> [JDK-8317692](https://b
On Wed, 10 Jan 2024 02:39:33 GMT, Alex Menkov wrote:
>> FieldStream/FilteredFieldStream classes from reflectionUtils.hpp iterate
>> class fields in the reverse order and use field indexes to access instead of
>> forward iteration. This is performance ineffective (see
>> [JDK-8317692](https://b
On Wed, 10 Jan 2024 05:20:27 GMT, Chris Plummer wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> copyright headers
>
> src/hotspot/share/prims/jvmtiEnv.cpp line 2910:
>
>> 2908: result_list[i] = jfieldIDWorkarou
28 matches
Mail list logo
