Re: RFR: 8319244: implement JVMTI handshakes support for virtual threads [v10]

2023-11-21 Thread Serguei Spitsyn
On Sun, 19 Nov 2023 05:12:50 GMT, Serguei Spitsyn wrote: >> The handshakes support for virtual threads is needed to simplify the JVMTI >> implementation for virtual threads. There is a significant duplication in >> the JVMTI code to differentiate code intended to support platform, virtual >> t

Integrated: 8319244: implement JVMTI handshakes support for virtual threads

2023-11-21 Thread Serguei Spitsyn
On Wed, 1 Nov 2023 18:44:04 GMT, Serguei Spitsyn wrote: > The handshakes support for virtual threads is needed to simplify the JVMTI > implementation for virtual threads. There is a significant duplication in the > JVMTI code to differentiate code intended to support platform, virtual > thread

RE: [External] : Re: Proposal: Add overwrite heapdump flag to java

2023-11-21 Thread Kevin Walls
Hi, Just going back to a technical point, did you manage to capture a stacktrace from the hang when running with -XX:OnError="jcmd %p GC.heap_dump -overwrite filename.dmp" It would be great to know if that is a reliable hang, and what it looks like. Maybe gclocker should not be blocking us at

RFR: 8313355: javax/management/remote/mandatory/notif/ListenerScaleTest.java failed with "Exception: Failed: ratio=792.2791601423487"

2023-11-21 Thread Kevin Walls
This test fails occasionally, and can be tuned to avoid most of the failures ever seen. It exists to check that notification work does not scale linearly with number of MBeans, so it calculates a ratio of the time taken with one, and with 20,000 MBeans. We should increase point at which that c

Re: Handling of DTraceMethodProbes

2023-11-21 Thread Vladimir Kozlov
CCing to serviceability group. Do we still support dtrace? Thanks, Vladimir K On 11/21/23 4:34 AM, Thomas Stüfe wrote: Hi, It seems that the handling of DTraceMethodProbes is inconsistent: in most places, we handle the flag at runtime by generating code that uses conditional jumps. In one pl

RFR: 8320536: problemlist failing serviceability/attach/ConcAttachTest.java test on macosx

2023-11-21 Thread Chris Plummer
Problemlisting ConcAttachTest.java on OSX (it's already problem listed on linux and doesn't get run on Windows). This one test seems to be causing all the issues with attach and dcmd tests described in [JDK-8318866](https://bugs.openjdk.org/browse/JDK-8318866), so if we problem list it we shoul

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap

2023-11-21 Thread Chris Plummer
On Fri, 22 Sep 2023 02:48:57 GMT, David Holmes wrote: >> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: >> `/tmp/perf-%d.map`. This change adds an option for specifying a file name. >> >> The help message of Compiler.perfmap: >> >> Compiler.perfmap >> Write map file for

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap

2023-11-21 Thread Chris Plummer
On Thu, 21 Sep 2023 20:43:56 GMT, Yi-Fan Tsai wrote: > `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: > `/tmp/perf-%d.map`. This change adds an option for specifying a file name. > > The help message of Compiler.perfmap: > > Compiler.perfmap > Write map file for Linux pe

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v46]

2023-11-21 Thread Jonathan Joo
> 8315149: Add hsperf counters for CPU time of internal GC threads Jonathan Joo has updated the pull request incrementally with two additional commits since the last revision: - Update memory tracking type for CPUTimeCounters - Fix assertion logic - Changes: - all: https://git.

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v46]

2023-11-21 Thread Jonathan Joo
On Tue, 21 Nov 2023 21:42:39 GMT, Jonathan Joo wrote: >> 8315149: Add hsperf counters for CPU time of internal GC threads > > Jonathan Joo has updated the pull request incrementally with two additional > commits since the last revision: > > - Update memory tracking type for CPUTimeCounters >

Re: RFR: 8320536: problemlist failing serviceability/attach/ConcAttachTest.java test on macosx

2023-11-21 Thread Alex Menkov
On Tue, 21 Nov 2023 20:16:39 GMT, Chris Plummer wrote: > Problemlisting ConcAttachTest.java on OSX (it's already problem listed on > linux and doesn't get run on Windows). This one test seems to be causing all > the issues with attach and dcmd tests described in > [JDK-8318866](https://bugs.op

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v2]

2023-11-21 Thread Yi-Fan Tsai
> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: > `/tmp/perf-%d.map`. This change adds an option for specifying a file name. > > The help message of `jcmd PID help Compiler.perfmap` will be updated in a > separate PR. Yi-Fan Tsai has updated the pull request incrementall

Re: RFR: 8308614: Enabling JVMTI ClassLoad event slows down vthread creation by factor 10 [v3]

2023-11-21 Thread Serguei Spitsyn
On Mon, 20 Nov 2023 00:59:35 GMT, David Holmes wrote: >> @dcubed-ojdk >> I don't know FJP implementation well enough to point at the code where it >> happens. However, I observe that new `JavaThread `is being created between >> two points of the execution path. >> - First point is in the `Jvmt

Re: RFR: 8319935: Ensure only one JvmtiThreadState is create for one JavaThread associated with attached native thread [v3]

2023-11-21 Thread Serguei Spitsyn
On Mon, 20 Nov 2023 19:28:13 GMT, Jiangli Zhou wrote: >> Please review JvmtiThreadState::state_for_while_locked change to handle the >> state->get_thread_oop() null case. Please see >> https://bugs.openjdk.org/browse/JDK-8319935 for details. > > Jiangli Zhou has updated the pull request increme

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v3]

2023-11-21 Thread Yi-Fan Tsai
> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: > `/tmp/perf-%d.map`. This change adds an option for specifying a file name. > > The help message of `jcmd PID help Compiler.perfmap` will be updated in a > separate PR. Yi-Fan Tsai has updated the pull request incrementall

Re: RFR: 8319935: Ensure only one JvmtiThreadState is create for one JavaThread associated with attached native thread [v3]

2023-11-21 Thread Serguei Spitsyn
On Mon, 20 Nov 2023 19:28:13 GMT, Jiangli Zhou wrote: >> Please review JvmtiThreadState::state_for_while_locked change to handle the >> state->get_thread_oop() null case. Please see >> https://bugs.openjdk.org/browse/JDK-8319935 for details. > > Jiangli Zhou has updated the pull request increme

Re: Handling of DTraceMethodProbes

2023-11-21 Thread David Holmes
On 22/11/2023 3:09 am, Vladimir Kozlov wrote: CCing to serviceability group. Do we still support dtrace? A qualified "yes" - the hooks still exist, mainly for systemTap IIRC but we don't actively update or maintain anything so I expect there is some bitrot. Thanks, Vladimir K On 11/21/23

Re: RFR: 8319935: Ensure only one JvmtiThreadState is create for one JavaThread associated with attached native thread [v2]

2023-11-21 Thread Serguei Spitsyn
On Fri, 17 Nov 2023 02:51:03 GMT, Jiangli Zhou wrote: >> Jiangli Zhou has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Don't try to setup_jvmti_thread_state for obj allocation sampling if the >> current thread is attaching from native an

Re: RFR: 8319935: Ensure only one JvmtiThreadState is create for one JavaThread associated with attached native thread [v3]

2023-11-21 Thread Serguei Spitsyn
On Mon, 20 Nov 2023 19:28:13 GMT, Jiangli Zhou wrote: >> Please review JvmtiThreadState::state_for_while_locked change to handle the >> state->get_thread_oop() null case. Please see >> https://bugs.openjdk.org/browse/JDK-8319935 for details. > > Jiangli Zhou has updated the pull request increme

Re: RFR: 8313816: Accessing jmethodID might lead to spurious crashes

2023-11-21 Thread David Holmes
On Mon, 20 Nov 2023 21:48:11 GMT, Coleen Phillimore wrote: >> The method holder is an `InstanceKlass` object which can be retrieved as >> `method->method_holder()` (I apologize if I am using not completely correct >> terms - this is what I grokked from the sources). And incomplete methods >> c

Re: RFR: 8313816: Accessing jmethodID might lead to spurious crashes

2023-11-21 Thread David Holmes
On Tue, 14 Nov 2023 17:56:09 GMT, Jaroslav Bachorik wrote: > Please, review this fix for a corner case handling of `jmethodID` values. > > The issue is related to the interplay between `jmethodID` values and method > redefinitions. Each `jmethodID` value is effectively a pointer to a `Method`

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v46]

2023-11-21 Thread Man Cao
On Tue, 21 Nov 2023 21:42:39 GMT, Jonathan Joo wrote: >> 8315149: Add hsperf counters for CPU time of internal GC threads > > Jonathan Joo has updated the pull request incrementally with two additional > commits since the last revision: > > - Update memory tracking type for CPUTimeCounters >

Re: RFR: 8319935: Ensure only one JvmtiThreadState is create for one JavaThread associated with attached native thread [v3]

2023-11-21 Thread David Holmes
On Tue, 21 Nov 2023 22:45:54 GMT, Serguei Spitsyn wrote: >> Jiangli Zhou has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add a check for a thread is_attaching_via_jni, based on David Holmes' >> comment. > > src/hotspot/share/prims/jvmti

Re: RFR: 8320536: problemlist failing serviceability/attach/ConcAttachTest.java test on macosx

2023-11-21 Thread David Holmes
On Tue, 21 Nov 2023 20:16:39 GMT, Chris Plummer wrote: > Problemlisting ConcAttachTest.java on OSX (it's already problem listed on > linux and doesn't get run on Windows). This one test seems to be causing all > the issues with attach and dcmd tests described in > [JDK-8318866](https://bugs.op