Re: RFR: 8316447: 8 sun/management/jmxremote tests ignore VM flags

2023-10-05 Thread Kevin Walls
On Thu, 5 Oct 2023 05:32:20 GMT, Leonid Mesnik wrote: > Updated test to use createTesJvm. > Removed internal timeout to not fail when Xcomp is used and also to get more > info if the test times out., > > Tested by running tier1, hs-tier5 and executing test with various VM flags. Looks good -

Re: RFR: 8315880: change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT

2023-10-05 Thread Julian Waters
On Mon, 18 Sep 2023 20:47:13 GMT, Daniel D. Daugherty wrote: > Change the default of LockingMode to LM_LIGHTWEIGHT from LM_LEGACY. > > This fix has been tested with 3 Mach5 Tier[1-8] runs and a 4th is in process. I think this may have broken JDK-8288293 😅 Is there any compiler specific implem

Re: RFR: 8315880: change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT

2023-10-05 Thread Roman Kennke
On Thu, 5 Oct 2023 10:09:33 GMT, Julian Waters wrote: > I think this may have broken JDK-8288293 😅 > > Is there any compiler specific implementation involved with the new > lightweight locking? Just a quick question, I can figure out the rest on my > own Not that I am aware of. AFAIK, it work

Re: RFR: JDK-8316691: Heap dump: separate stack traces for mounted virtual threads [v3]

2023-10-05 Thread Serguei Spitsyn
On Wed, 4 Oct 2023 01:21:02 GMT, Alex Menkov wrote: > used the same logic to split stack traces as > ThreadStackTrace::dump_stack_at_safepoint > (it was added with VT integration, it's used, for example by VM_ThreadDump). > My understanding that enterSpecial is considered as a special frame w

Re: RFR: 8316447: 8 sun/management/jmxremote tests ignore VM flags

2023-10-05 Thread Leonid Mesnik
On Thu, 5 Oct 2023 05:32:20 GMT, Leonid Mesnik wrote: > Updated test to use createTesJvm. > Removed internal timeout to not fail when Xcomp is used and also to get more > info if the test times out., > > Tested by running tier1, hs-tier5 and executing test with various VM flags. Thank you for

Re: RFR: 8316447: 8 sun/management/jmxremote tests ignore VM flags

2023-10-05 Thread Kevin Walls
On Thu, 5 Oct 2023 16:00:21 GMT, Leonid Mesnik wrote: > Thank you for your review and feedback. I removed private boolean > jmxAgentStarted = false; The changes invocations to createTestJvm are needed > because it added tested flags only. OK thanks. I was observing that we want to call Process

Re: RFR: 8316447: 8 sun/management/jmxremote tests ignore VM flags [v2]

2023-10-05 Thread Leonid Mesnik
> Updated test to use createTesJvm. > Removed internal timeout to not fail when Xcomp is used and also to get more > info if the test times out., > > Tested by running tier1, hs-tier5 and executing test with various VM flags. Leonid Mesnik has updated the pull request incrementally with one addi

Re: RFR: 8316447: 8 sun/management/jmxremote tests ignore VM flags [v2]

2023-10-05 Thread Leonid Mesnik
On Thu, 5 Oct 2023 18:21:06 GMT, Leonid Mesnik wrote: >> Updated test to use createTesJvm. >> Removed internal timeout to not fail when Xcomp is used and also to get more >> info if the test times out., >> >> Tested by running tier1, hs-tier5 and executing test with various VM flags. > > Leonid

Re: RFR: 8315880: change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT

2023-10-05 Thread Daniel D . Daugherty
On Mon, 18 Sep 2023 20:47:13 GMT, Daniel D. Daugherty wrote: > Change the default of LockingMode to LM_LIGHTWEIGHT from LM_LEGACY. > > This fix has been tested with 3 Mach5 Tier[1-8] runs and a 4th is in process. That would be unexpected breakage indeed... - PR Comment: https://g

Re: RFR: 8315880: change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT

2023-10-05 Thread Julian Waters
On Thu, 5 Oct 2023 19:56:00 GMT, Daniel D. Daugherty wrote: > That would be unexpected breakage indeed... Haha, indeed. Since this was just a default flag change, it's likely the entire thing was broken on my end to begin with, just that it never manifested since I never used the lightweight m