Re: RFR: 8314502: Change the comparator taking version of GrowableArray::find to be a template method [v3]

2023-09-07 Thread Afshin Zafari
On Tue, 29 Aug 2023 02:58:11 GMT, Quan Anh Mai wrote: > This is similar to `std::find_if` and should be just: > > ``` > template > int find_if(UnaryPredicate p) const { > for (int i = 0; i < _len; i++) { > if (p(_data[i])) { > return i; > } > } > return -1; >

Re: RFR: 8314502: Change the comparator taking version of GrowableArray::find to be a template method [v4]

2023-09-07 Thread Afshin Zafari
On Tue, 29 Aug 2023 07:04:15 GMT, Serguei Spitsyn wrote: >> Also, why isn't this change also being applied to `find_from_end` > > There can be a confusion related to selection of type names T and E: > T is intuitively treated as a table and E as an element. > No pressure but I wonder if using D

Re: RFR: 8314502: Change the comparator taking version of GrowableArray::find to be a template method [v4]

2023-09-07 Thread Afshin Zafari
On Thu, 7 Sep 2023 07:03:44 GMT, Afshin Zafari wrote: >> There can be a confusion related to selection of type names T and E: >> T is intuitively treated as a table and E as an element. >> No pressure but I wonder if using D instead of T would be better. > >> Also, why isn't this change also be

RFR: 8315702: jcmd Thread.dump_to_file slow with millions of virtual threads

2023-09-07 Thread Alan Bateman
`HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` are slow when there is a large number of threads. The thread dump can be sped up significantly with some small changes - Using println rather than format when print thread info and thread stacks - Create the print stream without

Re: RFR: 8315702: jcmd Thread.dump_to_file slow with millions of virtual threads

2023-09-07 Thread David Schlosnagle
On Wed, 6 Sep 2023 07:02:53 GMT, Alan Bateman wrote: > `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` are slow > when there is a large number of threads. > > The thread dump can be sped up significantly with some small changes > - Using println rather than format when prin

Re: Question on why sun.management MBeans are not exported?

2023-09-07 Thread mandy . chung
What we're referring to is to remove sun.management.Hotspot*, the internal MBeans which are never exposed and registered in the platform MBeanServer.   The internal metrics in HotSpot VM should be retained as they are exposed through other ways like jstat, GC logs, etc. Mandy On 9/6/23 11:27

RFR: 8313800: AArch64: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved

2023-09-07 Thread Andrew Haley
… frame when invoking LambdaForms is involved - Commit messages: - 8313800: AArch64: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved Changes: https://git.openjdk.org/jdk/pull/15624/files Webrev: https://webrevs.openjdk.org/?repo=jdk&

Re: RFR: 8315702: jcmd Thread.dump_to_file slow with millions of virtual threads

2023-09-07 Thread David Schlosnagle
On Wed, 6 Sep 2023 07:02:53 GMT, Alan Bateman wrote: > `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` are slow > when there is a large number of threads. > > The thread dump can be sped up significantly with some small changes: > - Using println rather than format when pri

Re: RFR: 8315702: jcmd Thread.dump_to_file slow with millions of virtual threads

2023-09-07 Thread Mandy Chung
On Wed, 6 Sep 2023 07:02:53 GMT, Alan Bateman wrote: > `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` are slow > when there is a large number of threads. > > The thread dump can be sped up significantly with some small changes: > - Using println rather than format when pri

Re: RFR: 8315702: jcmd Thread.dump_to_file slow with millions of virtual threads

2023-09-07 Thread Alex Menkov
On Wed, 6 Sep 2023 07:02:53 GMT, Alan Bateman wrote: > `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` are slow > when there is a large number of threads. > > The thread dump can be sped up significantly with some small changes: > - Using println rather than format when pri

RFR: 8315877: ProblemList vmTestbase/nsk/jvmti/InterruptThread/intrpthrd003/TestDescription.java on macosx-aarch64

2023-09-07 Thread Daniel D . Daugherty
Trivial fixes to ProblemList some tests: - [JDK-8315877](https://bugs.openjdk.org/browse/JDK-8315877) ProblemList vmTestbase/nsk/jvmti/InterruptThread/intrpthrd003/TestDescription.java on macosx-aarch64 - [JDK-8315879](https://bugs.openjdk.org/browse/JDK-8315879) ProblemList java/awt/PopupMenu/P

Re: RFR: 8315877: ProblemList vmTestbase/nsk/jvmti/InterruptThread/intrpthrd003/TestDescription.java on macosx-aarch64

2023-09-07 Thread Alexander Zvegintsev
On Thu, 7 Sep 2023 19:17:42 GMT, Daniel D. Daugherty wrote: > Trivial fixes to ProblemList some tests: > - [JDK-8315877](https://bugs.openjdk.org/browse/JDK-8315877) ProblemList > vmTestbase/nsk/jvmti/InterruptThread/intrpthrd003/TestDescription.java on > macosx-aarch64 > - [JDK-8315879](https:

Re: RFR: 8315877: ProblemList vmTestbase/nsk/jvmti/InterruptThread/intrpthrd003/TestDescription.java on macosx-aarch64

2023-09-07 Thread Roger Riggs
On Thu, 7 Sep 2023 19:17:42 GMT, Daniel D. Daugherty wrote: > Trivial fixes to ProblemList some tests: > - [JDK-8315877](https://bugs.openjdk.org/browse/JDK-8315877) ProblemList > vmTestbase/nsk/jvmti/InterruptThread/intrpthrd003/TestDescription.java on > macosx-aarch64 > - [JDK-8315879](https:

Re: RFR: 8315877: ProblemList vmTestbase/nsk/jvmti/InterruptThread/intrpthrd003/TestDescription.java on macosx-aarch64

2023-09-07 Thread Calvin Cheung
On Thu, 7 Sep 2023 19:17:42 GMT, Daniel D. Daugherty wrote: > Trivial fixes to ProblemList some tests: > - [JDK-8315877](https://bugs.openjdk.org/browse/JDK-8315877) ProblemList > vmTestbase/nsk/jvmti/InterruptThread/intrpthrd003/TestDescription.java on > macosx-aarch64 > - [JDK-8315879](https:

Integrated: 8315877: ProblemList vmTestbase/nsk/jvmti/InterruptThread/intrpthrd003/TestDescription.java on macosx-aarch64

2023-09-07 Thread Daniel D . Daugherty
On Thu, 7 Sep 2023 19:17:42 GMT, Daniel D. Daugherty wrote: > Trivial fixes to ProblemList some tests: > - [JDK-8315877](https://bugs.openjdk.org/browse/JDK-8315877) ProblemList > vmTestbase/nsk/jvmti/InterruptThread/intrpthrd003/TestDescription.java on > macosx-aarch64 > - [JDK-8315879](https:

Re: RFR: 8313800: AArch64: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved

2023-09-07 Thread Chris Plummer
On Thu, 7 Sep 2023 16:58:38 GMT, Andrew Haley wrote: > … frame when invoking LambdaForms is involved Overall the changes look good. Have you tested to see if this fixes [JDK-8276210](https://bugs.openjdk.org/browse/JDK-8276210) and [JDK-8248675](https://bugs.openjdk.org/browse/JDK-8248675)? Yo

Re: RFR: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests

2023-09-07 Thread Leonid Mesnik
On Thu, 31 Aug 2023 07:55:01 GMT, Aleksey Shipilev wrote: > Current vmTestbase/nsk/monitoring/stress/classload tests contains 24 tests, > each running exclusively. This drags the tier4 test times up. There seem to > be no reason to run these tests exclusively, though: they complete in > reason

Re: RFR: 8315702: jcmd Thread.dump_to_file slow with millions of virtual threads

2023-09-07 Thread Jaikiran Pai
On Wed, 6 Sep 2023 07:02:53 GMT, Alan Bateman wrote: > `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` are slow > when there is a large number of threads. > > The thread dump can be sped up significantly with some small changes: > - Using println rather than format when pri

Re: RFR: 8312174: missing JVMTI events from vthreads parked during JVMTI attach [v2]

2023-09-07 Thread Leonid Mesnik
On Thu, 7 Sep 2023 06:33:29 GMT, Serguei Spitsyn wrote: >> This update fixes two important issues: >> - Issue reported by a bug submitter about missing JVMTI events on virtual >> threads after an a JVMTI agent dynamic attach >> - Known scalability/performance issue: a need to lazily create >

Re: RFR: 8312174: missing JVMTI events from vthreads parked during JVMTI attach [v2]

2023-09-07 Thread Leonid Mesnik
On Wed, 6 Sep 2023 20:26:51 GMT, Alex Menkov wrote: >> Serguei Spitsyn has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commits

Re: RFR: 8315702: jcmd Thread.dump_to_file slow with millions of virtual threads

2023-09-07 Thread Alan Bateman
On Wed, 6 Sep 2023 07:02:53 GMT, Alan Bateman wrote: > `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` are slow > when there is a large number of threads. > > The thread dump can be sped up significantly with some small changes: > - Using println rather than format when pri

Integrated: 8315702: jcmd Thread.dump_to_file slow with millions of virtual threads

2023-09-07 Thread Alan Bateman
On Wed, 6 Sep 2023 07:02:53 GMT, Alan Bateman wrote: > `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` are slow > when there is a large number of threads. > > The thread dump can be sped up significantly with some small changes: > - Using println rather than format when pri