> The `find` method now is
> ```C++
> template
> int find(T* token, bool f(T*, E)) const {
> ...
>
> Any other functions which use this are also changed.
> Local linux-x64-debug hotspot:tier1 passed. Mach5 tier1 build on linux and
> Windows passed.
Afshin Zafari has updated the pull request inc
On Fri, 25 Aug 2023 10:04:28 GMT, Alan Bateman wrote:
>>> Something fishy here, is this working around a bug in GraaVM native image
>>> or why does this change need to be in JDK?
>>
>> I've now realized that the bug had an incorrect statement in the
>> description. The cycle happens due to the
On Thu, 24 Aug 2023 13:16:16 GMT, Severin Gehwolf wrote:
> Please review this rather trivial fix to not use `nio` in `CgroupUtil`, part
> of the
> JDK's Metrics API. The primary motivating factor is that it allows one to use
> the
> JDK's version of `Metrics` in GraalVM. See the bug for details
On Fri, 25 Aug 2023 10:04:28 GMT, Alan Bateman wrote:
>>> Something fishy here, is this working around a bug in GraaVM native image
>>> or why does this change need to be in JDK?
>>
>> I've now realized that the bug had an incorrect statement in the
>> description. The cycle happens due to the
Rename createJavaProcessBuilder so that it is not used by mistake instead of
createTestJvm.
I have used the following sed script: `find -name "*.java" | xargs -n 1 sed -i
-e "s/createJavaProcessBuilder(/createJavaProcessBuilderIgnoreTestJavaOpts(/g"`
Then I have manually modified ProcessTools.j
On Thu, 24 Aug 2023 13:16:16 GMT, Severin Gehwolf wrote:
> Please review this rather trivial fix to not use `nio` in `CgroupUtil`, part
> of the
> JDK's Metrics API. The primary motivating factor is that it allows one to use
> the
> JDK's version of `Metrics` in GraalVM. See the bug for details
On Mon, 28 Aug 2023 15:29:32 GMT, Alan Bateman wrote:
> > @AlanBateman Is there anything else you need me to do? If so, please let me
> > know. Thanks!
>
> I don't think the JDK is the right place to workaround this issue. Also, we
> really need to get back re-implementing FileInputStream and
On Mon, 28 Aug 2023 15:54:08 GMT, Leo Korinth wrote:
> Rename createJavaProcessBuilder so that it is not used by mistake instead of
> createTestJvm.
>
> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
> -i -e
> "s/createJavaProcessBuilder(/createJavaProcessBuilderI
Arguments were added to the launcher arguments.
-
Commit messages:
- 8314824: Fix serviceability/jvmti/803/GetObjectLockCount.java to use vm
flags
Changes: https://git.openjdk.org/jdk/pull/15454/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15454&range=00
Issue: htt
On Fri, 11 Aug 2023 02:46:36 GMT, Yi Yang wrote:
>> This is a follow-up patch of #13667. verifyHeapDump is duplicated in several
>> tests, this patch tries to consolidate them into one method.
>
> Yi Yang has updated the pull request incrementally with one additional commit
> since the last rev
The test is fixed to start debuggee with tested VM options.
Verified with tier1, running svc tests with different vm flags and virtual
thread.
-
Commit messages:
- 8314834: serviceability/jdwp/AllModulesCommandTest.java ignores VM flags
Changes: https://git.openjdk.org/jdk/pull/154
On Mon, 21 Aug 2023 05:03:06 GMT, David Holmes wrote:
> Infinite loops are not good to have so the test adjustment seems fine in that
> regard. But I can't see how using the virtual thread factory could trigger a
> problem with this code.
It's not clear to me as well.
Debugger sends 'quit' com
On Mon, 28 Aug 2023 11:03:51 GMT, Afshin Zafari wrote:
>> The `find` method now is
>> ```C++
>> template
>> int find(T* token, bool f(T*, E)) const {
>> ...
>>
>> Any other functions which use this are also changed.
>> Local linux-x64-debug hotspot:tier1 passed. Mach5 tier1 build on linux and
On Mon, 28 Aug 2023 15:54:08 GMT, Leo Korinth wrote:
> Rename createJavaProcessBuilder so that it is not used by mistake instead of
> createTestJvm.
>
> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
> -i -e
> "s/createJavaProcessBuilder(/createJavaProcessBuilderI
Hello Tham,
On 29/08/2023 12:19 pm, Tham To Thi Hong wrote:
Dear esteemed members of the jtreg-dev mailing list,
You actually sent this email to serviceability-dev.
Cheers,
David
I hope this message finds you well. My name is Tham To, and I'm excited to
introduce myself as a new contributo
On Mon, 28 Aug 2023 20:10:59 GMT, Leonid Mesnik wrote:
> The test is fixed to start debuggee with tested VM options.
> Verified with tier1, running svc tests with different vm flags and virtual
> thread.
Looks okay.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR
On Mon, 28 Aug 2023 19:12:04 GMT, Leonid Mesnik wrote:
> Arguments were added to the launcher arguments.
Looks good.
Copyright comment needs an update.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15454#pullrequestreview-
17 matches
Mail list logo
