On Tue, 11 Jul 2023 06:31:24 GMT, Thomas Stuefe wrote:
>> Please review this PR that enables ClassWriter to write annotations to the
>> class file being dumped.
>>
>> The fields annotations are stored in `Annotations::_fields_annotations`
>> which is of type `Array*>`. There is no class in SA
On Fri, 30 Jun 2023 14:32:03 GMT, Ashutosh Mehra wrote:
> Please review this PR that enables ClassWriter to write annotations to the
> class file being dumped.
>
> The fields annotations are stored in `Annotations::_fields_annotations` which
> is of type `Array*>`. There is no class in SA that
In preparation for some Lilliput-related changes, I'd like to get some purely
mechanical code moves out of the way. It would also improve separation of
concerns and reduces include header bloat.
In particular, this patch does:
1) Move `CompressedKlassPointers` from `compressedOops.(cpp|hpp|inli
On Tue, 11 Jul 2023 11:20:19 GMT, Thomas Stuefe wrote:
> In preparation for some Lilliput-related changes, I'd like to get some purely
> mechanical code moves out of the way. It would also improve separation of
> concerns and reduces include header bloat.
>
> In particular, this patch does:
>
On Fri, 23 Jun 2023 01:57:56 GMT, Alex Menkov wrote:
> This is follow-up JDK-8307153/JDK-8309612 (JVMTI GetThreadState on carrier
> should return STATE_WAITING)
> New test tests GetThreadState for different thread states.
> The test detected a bug in the implementation, new issue is created:
>
On Tue, 11 Jul 2023 07:41:01 GMT, Thomas Stuefe wrote:
> What would be needed to make the Annotations appear in the "printall"
> command? I was somehow expecting to see at least something like
> "Annotation@".
I am not sure what all details `printall` is expected to emit out. Looking at
t
> Please review this PR that enables ClassWriter to write annotations to the
> class file being dumped.
>
> The fields annotations are stored in `Annotations::_fields_annotations` which
> is of type `Array*>`. There is no class in SA that can represent
> it. I have added ArrayOfU1Array to corre
On Fri, 30 Jun 2023 17:59:15 GMT, Chris Plummer wrote:
>> Ashutosh Mehra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments
>>
>> Signed-off-by: Ashutosh Mehra
>
> src/hotspot/share/runtime/vmStructs.cpp line 972:
>
>
On Tue, 11 Jul 2023 06:39:09 GMT, Thomas Stuefe wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ConstMethod.java
>> line 470:
>>
>>> 468: if (hasParameterAnnotations()) {
>>> 469: offset += 1;
>>> 470: }
>>
>> Code here and in other places could be tighte
> Please review this PR that enables ClassWriter to write annotations to the
> class file being dumped.
>
> The fields annotations are stored in `Annotations::_fields_annotations` which
> is of type `Array*>`. There is no class in SA that can represent
> it. I have added ArrayOfU1Array to corre
On Tue, 11 Jul 2023 06:32:24 GMT, Thomas Stuefe wrote:
>> Ashutosh Mehra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Some code motion and factoring out common code
>>
>> Signed-off-by: Ashutosh Mehra
>
> src/jdk.hotspot.agent/s
On Tue, 11 Jul 2023 19:34:29 GMT, Ashutosh Mehra wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Annotations.java
>> line 74:
>>
>>> 72: public U1Array getFieldAnnotations(int fieldIndex) {
>>> 73: Address addr = fieldsAnnotations.getValue(getAddress());
>>> 74: Arr
On Tue, 11 Jul 2023 19:56:25 GMT, Ashutosh Mehra wrote:
>> Please review this PR that enables ClassWriter to write annotations to the
>> class file being dumped.
>>
>> The fields annotations are stored in `Annotations::_fields_annotations`
>> which is of type `Array*>`. There is no class in SA
> After [JDK-8308232](https://bugs.openjdk.org/browse/JDK-8308232), both the
> test and the debuggee shared the same waittime of 5 minutes. The test would
> wait up to 5 minutes for the expected prompt, but the debuggee would also in
> some cases wait 5 minutes before generating the prompt, whic
On Tue, 16 May 2023 18:41:26 GMT, Chris Plummer wrote:
>> Hi, can I have a review for this patch?
>
> @y1yang0 Sorry no one has been able to review this so far. The serviceability
> team is very busy for the next few weeks finishing up JDK 21 changes before
> RDP1. It's unlikely we'll find time
On Mon, 10 Jul 2023 06:13:17 GMT, Yi Yang wrote:
>> ### Motivation and proposal
>> Hi, heap dump brings about pauses for application's execution(STW), this is
>> a well-known pain. JDK-8252842 have added parallel support to heapdump in an
>> attempt to alleviate this issue. However, all concurr
On Tue, 11 Jul 2023 11:20:19 GMT, Thomas Stuefe wrote:
> In preparation for some Lilliput-related changes, I'd like to get some purely
> mechanical code moves out of the way. It would also improve separation of
> concerns and reduces include header bloat.
>
> In particular, this patch does:
>
On Tue, 11 Jul 2023 23:33:52 GMT, Ioi Lam wrote:
> Looks reasonable to me.
Thank you Ioi.
-
PR Comment: https://git.openjdk.org/jdk/pull/14826#issuecomment-1631862898
This is an issue with a dynamic load of a JVMTI agent into running VM.
The `VM_SetNotifyJvmtiEventsMode` enabling operation makes a call to the
function `count_transitions_and_correct_jvmti_thread_states()`. This function
in its turn make a call to the function `correct_jvmti_thread_state()`. But
On Wed, 12 Jul 2023 05:02:53 GMT, Serguei Spitsyn wrote:
> This is an issue with a dynamic load of a JVMTI agent into running VM.
> The `VM_SetNotifyJvmtiEventsMode` enabling operation makes a call to the
> function `count_transitions_and_correct_jvmti_thread_states()`. This function
> in its t
20 matches
Mail list logo
