Most G1 tests set -XX:+UseG1GC, but a few (e.g.
gc/g1/TestVerificationInConcurrentCycle.java) miss that.
This is usually just fine and no problem because G1 is the default anyway.
However in some cases, where a custom JVM changes the default GC, those tests
start to fail which is not really neces
On Fri, 30 Jun 2023 08:11:47 GMT, Matthias Baesken wrote:
> Most G1 tests set -XX:+UseG1GC, but a few (e.g.
> gc/g1/TestVerificationInConcurrentCycle.java) miss that.
> This is usually just fine and no problem because G1 is the default anyway.
> However in some cases, where a custom JVM changes
On Thu, 29 Jun 2023 16:08:15 GMT, Kevin Walls wrote:
> Simple doc tag addition.
>
> These are files which describe an interface that has been with us since 1.5.
> The files themselves were previously generated at build time, but have been
> in the repo since jdk15. But the API is since 1.5.
On Thu, 29 Jun 2023 16:08:15 GMT, Kevin Walls wrote:
> Simple doc tag addition.
>
> These are files which describe an interface that has been with us since 1.5.
> The files themselves were previously generated at build time, but have been
> in the repo since jdk15. But the API is since 1.5.
> Simple doc tag addition.
>
> These are files which describe an interface that has been with us since 1.5.
> The files themselves were previously generated at build time, but have been
> in the repo since jdk15. But the API is since 1.5.
>
> The other file mentioned in the bug is not a publi
On Thu, 29 Jun 2023 11:48:43 GMT, Kevin Walls wrote:
> Simple addition of a doc tag.
>
> src/share/classes/com/sun/management/GarbageCollectionNotificationInfo.java
> is introduced in jdk7 by
> 7036199: Adding a notification to the implementation of
> GarbageCollectorMXBeans
Thanks for the
> Simple addition of a doc tag.
>
> src/share/classes/com/sun/management/GarbageCollectionNotificationInfo.java
> is introduced in jdk7 by
> 7036199: Adding a notification to the implementation of
> GarbageCollectorMXBeans
Kevin Walls has updated the pull request incrementally with one additi
On Thu, 29 Jun 2023 11:48:43 GMT, Kevin Walls wrote:
> Simple addition of a doc tag.
>
> src/share/classes/com/sun/management/GarbageCollectionNotificationInfo.java
> is introduced in jdk7 by
> 7036199: Adding a notification to the implementation of
> GarbageCollectorMXBeans
This pull reque
Simple since tag addition in selected files.
-
Commit messages:
- 8310993: Missing @since tags in jdk.attach
Changes: https://git.openjdk.org/jdk/pull/14724/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14724&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8310993
On Fri, 30 Jun 2023 08:44:22 GMT, Kevin Walls wrote:
> Simple since tag addition in selected files.
Looks good.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14724#pullrequestreview-1506841290
On Wed, 28 Jun 2023 13:22:20 GMT, Matthias Baesken wrote:
>>> Hi Alan, regarding usage of class VM I get 'package jdk.internal.misc is
>>> declared in module java.base, which does not export it to module java.sql'
>>> Is there any concern to export it as well to module java.sql ? And btw did
>
> There are a few references to rt.jar in comments and in the codebase itself.
> Some of them might be removed or adjusted.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
Adjust comment in src/java.sql/share/classes/java/sql/Dri
On Fri, 30 Jun 2023 08:11:47 GMT, Matthias Baesken wrote:
> Most G1 tests set -XX:+UseG1GC, but a few (e.g.
> gc/g1/TestVerificationInConcurrentCycle.java) miss that.
> This is usually just fine and no problem because G1 is the default anyway.
> However in some cases, where a custom JVM changes
The JVMTI function `SetEventNotificationMode` can set notification mode
globally (`event_thread == nullptr`) for all threads or for a specific thread
(`event_thread != nullptr`). To get a stable mount/unmount vision of virtual
threads a JvmtiVTMSTransitionDisabler helper object is created :
> There are a few references to rt.jar in comments and in the codebase itself.
> Some of them might be removed or adjusted.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
remove import
-
Changes:
- all: https://g
On Fri, 30 Jun 2023 08:11:47 GMT, Matthias Baesken wrote:
> Most G1 tests set -XX:+UseG1GC, but a few (e.g.
> gc/g1/TestVerificationInConcurrentCycle.java) miss that.
> This is usually just fine and no problem because G1 is the default anyway.
> However in some cases, where a custom JVM changes
On Fri, 30 Jun 2023 08:11:47 GMT, Matthias Baesken wrote:
> Most G1 tests set -XX:+UseG1GC, but a few (e.g.
> gc/g1/TestVerificationInConcurrentCycle.java) miss that.
> This is usually just fine and no problem because G1 is the default anyway.
> However in some cases, where a custom JVM changes
8310380: Handle problems in core-related tests on macOS when codesign tool does
not work
-
Commit messages:
- Backport 39c104df44f17c1d65e35becd4272f73e2c6610c
Changes: https://git.openjdk.org/jdk21/pull/87/files
Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=87&range=00
Iss
> Please review change for mostly fixing return types in the constant pool and
> metadata to fix -Wconversion warnings in JVMTI code. The order of preference
> for changes are: 1. change the types to more distinct types (fields in the
> constant pool are u2 because that's their size in the clas
On Thu, 29 Jun 2023 17:29:50 GMT, Coleen Phillimore wrote:
>> Please review change for mostly fixing return types in the constant pool and
>> metadata to fix -Wconversion warnings in JVMTI code. The order of
>> preference for changes are: 1. change the types to more distinct types
>> (fields
On Fri, 30 Jun 2023 01:52:40 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add a comment about u1 cast to new_index for the ldc bytecode.
>
> src/hotspot/share/oops/constMethod.hpp line 327
On Fri, 30 Jun 2023 02:11:11 GMT, David Holmes wrote:
>> I had to change these two lines because BytecodeStream::get_index_u2 returns
>> an int, so got the warning and this didn't need to be declared with u2.
>> get_index_u2() could be fixed to return a u2 but I didn't want to go that
>> far
On Fri, 30 Jun 2023 02:18:14 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add a comment about u1 cast to new_index for the ldc bytecode.
>
> Sorry Coleen but this raises a lot of questions
On Tue, 27 Jun 2023 12:22:43 GMT, Daniel Jeliński wrote:
> Please review this attempt to fix ignored-qualifiers warning.
>
> Example warnings:
>
> src/hotspot/share/oops/method.hpp:413:19: warning: 'volatile' type qualifier
> on return type has no effect [-Wignored-qualifiers]
>CompiledMet
> The VMSupport class is required for translating an exception between the
> HotSpot and libgraal heaps.
> Loading it lazily can result in a loading exception, obscuring the exception
> being translated.
> To avoid this, VMSupport is loaded eagerly along with the other vmClasses.
Doug Simon has
On Thu, 29 Jun 2023 20:06:19 GMT, Doug Simon wrote:
>> The VMSupport class is required for translating an exception between the
>> HotSpot and libgraal heaps.
>> Loading it lazily can result in a loading exception, obscuring the exception
>> being translated.
>> To avoid this, VMSupport is load
Please review this PR that enables ClassWriter to write annotations to the
class file being dumped.
The fields annotations are stored in `Annotations::_fields_annotations` which
is of type `Array*>`. There is no class in SA that can represent it.
I have added ArrayOfU1Array to correspond to the
> The VMSupport class is required for translating an exception between the
> HotSpot and libgraal heaps.
> Loading it lazily can result in a loading exception, obscuring the exception
> being translated.
> To avoid this, VMSupport is loaded eagerly along with the other vmClasses.
Doug Simon has
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
On Fri, 30 Jun 2023 11:27:58 GMT, Serguei Spitsyn wrote:
> The JVMTI function `SetEventNotificationMode` can set notification mode
> globally (`event_thread == nullptr`) for all threads or for a specific thread
> (`event_thread != nullptr`). To get a stable mount/unmount vision of virtual
> th
On Fri, 30 Jun 2023 15:15:16 GMT, Doug Simon wrote:
>> The VMSupport class is required for translating an exception between the
>> HotSpot and libgraal heaps.
>> Loading it lazily can result in a loading exception, obscuring the exception
>> being translated.
>> To avoid this, VMSupport is load
On Fri, 30 Jun 2023 14:35:10 GMT, Doug Simon wrote:
> > But, please, activate GHA testing for this branch.
>
> Isn't GHA a strict subset of or equal to tier1 mach5 testing? If so, what's
> the point of doing redundant testing?
It builds and tests configurations (32-bit) we don't have in our te
On Fri, 30 Jun 2023 08:44:22 GMT, Kevin Walls wrote:
> Simple since tag addition in selected files.
Marked as reviewed by cjplummer (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14724#pullrequestreview-1507616881
On Fri, 30 Jun 2023 12:35:27 GMT, Matthias Baesken wrote:
> 8310380: Handle problems in core-related tests on macOS when codesign tool
> does not work
Marked as reviewed by cjplummer (Reviewer).
-
PR Review: https://git.openjdk.org/jdk21/pull/87#pullrequestreview-1507621309
On Fri, 30 Jun 2023 08:44:22 GMT, Kevin Walls wrote:
> Simple since tag addition in selected files.
Thanks for the reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/14724#issuecomment-1614982322
On Fri, 30 Jun 2023 08:44:22 GMT, Kevin Walls wrote:
> Simple since tag addition in selected files.
This pull request has now been integrated.
Changeset: 19601ebe
Author:Kevin Walls
URL:
https://git.openjdk.org/jdk/commit/19601ebe9192773a1a47ec3e003b9f1a6808d3de
Stats: 11 lines
On Fri, 30 Jun 2023 11:27:58 GMT, Serguei Spitsyn wrote:
> The JVMTI function `SetEventNotificationMode` can set notification mode
> globally (`event_thread == nullptr`) for all threads or for a specific thread
> (`event_thread != nullptr`). To get a stable mount/unmount vision of virtual
> th
On Fri, 30 Jun 2023 11:27:58 GMT, Serguei Spitsyn wrote:
> The JVMTI function `SetEventNotificationMode` can set notification mode
> globally (`event_thread == nullptr`) for all threads or for a specific thread
> (`event_thread != nullptr`). To get a stable mount/unmount vision of virtual
> th
On Fri, 30 Jun 2023 17:30:33 GMT, Vladimir Kozlov wrote:
> > > But, please, activate GHA testing for this branch.
> >
> >
> > Isn't GHA a strict subset of or equal to tier1 mach5 testing? If so, what's
> > the point of doing redundant testing?
>
> It builds and tests configurations (32-bit) w
On Fri, 30 Jun 2023 15:15:16 GMT, Doug Simon wrote:
>> The VMSupport class is required for translating an exception between the
>> HotSpot and libgraal heaps.
>> Loading it lazily can result in a loading exception, obscuring the exception
>> being translated.
>> To avoid this, VMSupport is load
On Sun, 25 Jun 2023 06:58:14 GMT, Doug Simon wrote:
> The VMSupport class is required for translating an exception between the
> HotSpot and libgraal heaps.
> Loading it lazily can result in a loading exception, obscuring the exception
> being translated.
> To avoid this, VMSupport is loaded ea
On Fri, 30 Jun 2023 05:54:12 GMT, Serguei Spitsyn wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> updated comment
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/GetThreadStateMountedTest/libGetThreadStateMounte
On Fri, 30 Jun 2023 11:27:58 GMT, Serguei Spitsyn wrote:
> The JVMTI function `SetEventNotificationMode` can set notification mode
> globally (`event_thread == nullptr`) for all threads or for a specific thread
> (`event_thread != nullptr`). To get a stable mount/unmount vision of virtual
> th
On Fri, 30 Jun 2023 11:27:58 GMT, Serguei Spitsyn wrote:
> The JVMTI function `SetEventNotificationMode` can set notification mode
> globally (`event_thread == nullptr`) for all threads or for a specific thread
> (`event_thread != nullptr`). To get a stable mount/unmount vision of virtual
> th
Trivial ProblemListing/disable changes:
- [JDK-8311186](https://bugs.openjdk.org/browse/JDK-8311186) ProblemList
javax/management/remote/mandatory/subjectDelegation/SubjectDelegation1Test.java
on linux-aarch64
- [JDK-8311189](https://bugs.openjdk.org/browse/JDK-8311189) disable
gc/z/TestHighUsag
On Fri, 30 Jun 2023 19:26:22 GMT, Daniel D. Daugherty
wrote:
> Trivial ProblemListing/disable changes:
> - [JDK-8311186](https://bugs.openjdk.org/browse/JDK-8311186) ProblemList
> javax/management/remote/mandatory/subjectDelegation/SubjectDelegation1Test.java
> on linux-aarch64
> - [JDK-831118
On Fri, 30 Jun 2023 19:26:22 GMT, Daniel D. Daugherty
wrote:
> Trivial ProblemListing/disable changes:
> - [JDK-8311186](https://bugs.openjdk.org/browse/JDK-8311186) ProblemList
> javax/management/remote/mandatory/subjectDelegation/SubjectDelegation1Test.java
> on linux-aarch64
> - [JDK-831118
On Fri, 30 Jun 2023 19:26:22 GMT, Daniel D. Daugherty
wrote:
> Trivial ProblemListing/disable changes:
> - [JDK-8311186](https://bugs.openjdk.org/browse/JDK-8311186) ProblemList
> javax/management/remote/mandatory/subjectDelegation/SubjectDelegation1Test.java
> on linux-aarch64
> - [JDK-831118
On Fri, 30 Jun 2023 19:26:22 GMT, Daniel D. Daugherty
wrote:
> Trivial ProblemListing/disable changes:
> - [JDK-8311186](https://bugs.openjdk.org/browse/JDK-8311186) ProblemList
> javax/management/remote/mandatory/subjectDelegation/SubjectDelegation1Test.java
> on linux-aarch64
> - [JDK-831118
On Fri, 30 Jun 2023 19:26:22 GMT, Daniel D. Daugherty
wrote:
> Trivial ProblemListing/disable changes:
> - [JDK-8311186](https://bugs.openjdk.org/browse/JDK-8311186) ProblemList
> javax/management/remote/mandatory/subjectDelegation/SubjectDelegation1Test.java
> on linux-aarch64
> - [JDK-831118
On Wed, 28 Jun 2023 08:04:21 GMT, Yi Yang wrote:
>> ### Motivation and proposal
>> Hi, heap dump brings about pauses for application's execution(STW), this is
>> a well-known pain. JDK-8252842 have added parallel support to heapdump in an
>> attempt to alleviate this issue. However, all concurr
Backport 140b70fb29e2b83e5d33765906ee76a36442a687
Trivial ProblemListing/disable changes:
[JDK-8311186](https://bugs.openjdk.org/browse/JDK-8311186) ProblemList
javax/management/remote/mandatory/subjectDelegation/SubjectDelegation1Test.java
on linux-aarch64
[JDK-8311189](https://bugs.openjdk.or
On Fri, 30 Jun 2023 22:17:40 GMT, Daniel D. Daugherty
wrote:
> Backport 140b70fb29e2b83e5d33765906ee76a36442a687
>
> Trivial ProblemListing/disable changes:
>
> [JDK-8311186](https://bugs.openjdk.org/browse/JDK-8311186) ProblemList
> javax/management/remote/mandatory/subjectDelegation/Subject
On Fri, 30 Jun 2023 22:28:34 GMT, Leonid Mesnik wrote:
>> Backport 140b70fb29e2b83e5d33765906ee76a36442a687
>>
>> Trivial ProblemListing/disable changes:
>>
>> [JDK-8311186](https://bugs.openjdk.org/browse/JDK-8311186) ProblemList
>> javax/management/remote/mandatory/subjectDelegation/SubjectD
On Fri, 30 Jun 2023 22:17:40 GMT, Daniel D. Daugherty
wrote:
> Backport 140b70fb29e2b83e5d33765906ee76a36442a687
>
> Trivial ProblemListing/disable changes:
>
> [JDK-8311186](https://bugs.openjdk.org/browse/JDK-8311186) ProblemList
> javax/management/remote/mandatory/subjectDelegation/Subject
55 matches
Mail list logo
