RFR: 8305590: Remove nothrow exception specifications from operator new

2023-04-18 Thread Afshin Zafari
- The `throw()` (i.e., no throw) specifications are removed from the instances of `operator new` where _do not_ return `nullptr`. - The `-fcheck-new` is removed from the gcc compile flags. - The `operator new` and `operator delete` are deleted from `StackObj`. - The `GrowableArrayCHeap::operato

RFR: 8306282: Build failure linux-arm32-open-cmp-baseline after JDK-8257967

2023-04-18 Thread Markus Grönlund
Greetings, With [JDK-8257967](https://bugs.openjdk.org/browse/JDK-8257967), much refactoring was done to the JVMTI code concerning agents. However, some platforms do not have JVMTI support, and tier5 of testing builds an embedded build, linux-arm32-open-cmp-baseline, which failed because the r

Re: RFR: 8306282: Build failure linux-arm32-open-cmp-baseline after JDK-8257967

2023-04-18 Thread Erik Gahlin
On Tue, 18 Apr 2023 14:22:21 GMT, Markus Grönlund wrote: > Greetings, > > With [JDK-8257967](https://bugs.openjdk.org/browse/JDK-8257967), much > refactoring was done to the JVMTI code concerning agents. However, some > platforms do not have JVMTI support, and tier5 of testing builds an embedd

Re: RFR: 8306282: Build failure linux-arm32-open-cmp-baseline after JDK-8257967 [v2]

2023-04-18 Thread Markus Grönlund
> Greetings, > > With [JDK-8257967](https://bugs.openjdk.org/browse/JDK-8257967), much > refactoring was done to the JVMTI code concerning agents. However, some > platforms do not have JVMTI support, and tier5 of testing builds an embedded > build, linux-arm32-open-cmp-baseline, which failed b

Re: RFR: 8306282: Build failure linux-arm32-open-cmp-baseline after JDK-8257967 [v3]

2023-04-18 Thread Markus Grönlund
> Greetings, > > With [JDK-8257967](https://bugs.openjdk.org/browse/JDK-8257967), much > refactoring was done to the JVMTI code concerning agents. However, some > platforms do not have JVMTI support, and tier5 of testing builds an embedded > build, linux-arm32-open-cmp-baseline, which failed b

Re: RFR: 8305590: Remove nothrow exception specifications from operator new

2023-04-18 Thread Coleen Phillimore
On Mon, 17 Apr 2023 17:09:44 GMT, Afshin Zafari wrote: > - The `throw()` (i.e., no throw) specifications are removed from the > instances of `operator new` where _do not_ return `nullptr`. > > - The `-fcheck-new` is removed from the gcc compile flags. > > - The `operator new` and `operator del

Re: RFR: 8306282: Build failure linux-arm32-open-cmp-baseline after JDK-8257967 [v3]

2023-04-18 Thread Ioi Lam
On Tue, 18 Apr 2023 15:22:02 GMT, Markus Grönlund wrote: >> Greetings, >> >> With [JDK-8257967](https://bugs.openjdk.org/browse/JDK-8257967), much >> refactoring was done to the JVMTI code concerning agents. However, some >> platforms do not have JVMTI support, and tier5 of testing builds an e

Integrated: 8306282: Build failure linux-arm32-open-cmp-baseline after JDK-8257967

2023-04-18 Thread Markus Grönlund
On Tue, 18 Apr 2023 14:22:21 GMT, Markus Grönlund wrote: > Greetings, > > With [JDK-8257967](https://bugs.openjdk.org/browse/JDK-8257967), much > refactoring was done to the JVMTI code concerning agents. However, some > platforms do not have JVMTI support, and tier5 of testing builds an embedd

RFR: 8306278: jvmtiAgentList.cpp:253 assert(offset >= 0) failed: invariant occurs on AIX after JDK-8257967

2023-04-18 Thread Markus Grönlund
Greetings, For most platforms, os::dll_address_to_library_name() only sets offset = -1 in case of errors. If there is an error, the function returns false. This is fine. On AIX, the offset, being optional, is invariantly set to -1, even in the case of non-errors. Easiest to remove the assertio

Re: RFR: 8306278: jvmtiAgentList.cpp:253 assert(offset >= 0) failed: invariant occurs on AIX after JDK-8257967

2023-04-18 Thread Serguei Spitsyn
On Tue, 18 Apr 2023 16:59:29 GMT, Markus Grönlund wrote: > Greetings, > > For most platforms, os::dll_address_to_library_name() only sets offset = -1 > in case of errors. If there is an error, the function returns false. This is > fine. > > On AIX, the offset, being optional, is invariantly s

RFR: 8306123: Move InstanceKlass writeable flags

2023-04-18 Thread Coleen Phillimore
Please review this patch to move the writeable Klass AccessFlags to InstanceKlassFlags. Tested with tier1-4. - Commit messages: - 8306123: Move InstanceKlass writeable flags Changes: https://git.openjdk.org/jdk/pull/13515/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=1351

Re: RFR: 8306033: Resolve multiple definition of 'throwIOException' and friends when statically linking with JDK native libraries

2023-04-18 Thread Jiangli Zhou
On Mon, 17 Apr 2023 16:56:31 GMT, Jiangli Zhou wrote: > - Make functions 'static' when feasible: > - throwByName() in > src/java.security.jgss/share/native/libj2gss/NativeUtil.c. > - throwByName(), throwIOException() and throwNullPointerException() in > src/java.smartcardio/unix/native/libj

Re: RFR: 8305590: Remove nothrow exception specifications from operator new

2023-04-18 Thread Kim Barrett
On Tue, 18 Apr 2023 15:18:34 GMT, Coleen Phillimore wrote: >> - The `throw()` (i.e., no throw) specifications are removed from the >> instances of `operator new` where _do not_ return `nullptr`. >> >> - The `-fcheck-new` is removed from the gcc compile flags. >> >> - The `operator new` and `op

Re: RFR: 8305590: Remove nothrow exception specifications from operator new

2023-04-18 Thread Kim Barrett
On Mon, 17 Apr 2023 17:09:44 GMT, Afshin Zafari wrote: > - The `throw()` (i.e., no throw) specifications are removed from the > instances of `operator new` where _do not_ return `nullptr`. > > - The `-fcheck-new` is removed from the gcc compile flags. > > - The `operator new` and `operator del

Re: RFR: 8298048: Combine CDS archive heap into a single block [v7]

2023-04-18 Thread Ioi Lam
> This PR combines the "open" and "closed" regions of the CDS archive heap into > a single region. This significantly simplifies the implementation, making it > more compatible with non-G1 collectors. There's a net removal of ~1000 lines > in src code and another ~1200 lines of tests. > > **Not

Re: RFR: 8306006: strace001.java fails due to unknown methods on stack

2023-04-18 Thread Daniel D . Daugherty
On Fri, 14 Apr 2023 13:27:37 GMT, Fredrik Bredberg wrote: > Added the missing java.lang.Thread.beforeSleep and java.lang.afterSleep to > expectedSystemTrace. > Tested on my local machine. We current have a total of 20 sightings of this failure in both CI and Adhoc jobs and it's happening in qui

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v15]

2023-04-18 Thread Roger Riggs
On Mon, 17 Apr 2023 20:59:06 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64, X

Re: RFR: 8306123: Move InstanceKlass writeable flags

2023-04-18 Thread Ioi Lam
On Tue, 18 Apr 2023 17:11:25 GMT, Coleen Phillimore wrote: > Please review this patch to move the writeable Klass AccessFlags to > InstanceKlassFlags. > Tested with tier1-4. LGTM. - Marked as reviewed by iklam (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13515#pullrequ

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v15]

2023-04-18 Thread Erik Joelsson
On Mon, 17 Apr 2023 20:59:06 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64, X

JEP draft: Disallow the Dynamic Loading of Agents by Default

2023-04-18 Thread Ron Pressler
Hi. Following last month’s email about changing the default of EnableDynamicAgentLoading [1], we’ve now published two JEP drafts. The first is an informational JEP describing what integrity is and why we need it, and motivates what changes are required to get it (which include the restriction of

Re: RFR: 8294977: Convert test/jdk/java tests from ASM library to Classfile API [v7]

2023-04-18 Thread Chen Liang
On Tue, 21 Mar 2023 21:39:48 GMT, Chen Liang wrote: >> Summaries: >> 1. A few recommendations about updating the constant API is made at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html >> and I may update this patch shall the API changes be integrated before >> 2.

Re: RFR: 8306278: jvmtiAgentList.cpp:253 assert(offset >= 0) failed: invariant occurs on AIX after JDK-8257967

2023-04-18 Thread David Holmes
On Tue, 18 Apr 2023 16:59:29 GMT, Markus Grönlund wrote: > Greetings, > > For most platforms, os::dll_address_to_library_name() only sets offset = -1 > in case of errors. If there is an error, the function returns false. This is > fine. > > On AIX, the offset, being optional, is invariantly s

Re: RFR: 8306282: Build failure linux-arm32-open-cmp-baseline after JDK-8257967 [v3]

2023-04-18 Thread David Holmes
On Tue, 18 Apr 2023 15:22:02 GMT, Markus Grönlund wrote: >> Greetings, >> >> With [JDK-8257967](https://bugs.openjdk.org/browse/JDK-8257967), much >> refactoring was done to the JVMTI code concerning agents. However, some >> platforms do not have JVMTI support, and tier5 of testing builds an e