Re: RFR: 8304543: Modernize debugging jvm args in test/hotspot/jtreg/vmTestbase/nsk/jdi/Argument/value/value004.java

2023-03-21 Thread Alan Bateman
On Mon, 20 Mar 2023 19:47:10 GMT, Eirik Bjorsnos wrote: > Please review this PR which replaces the use of outdated JVM flags for > setting up debugging in the test value004.java > > This is part of an ongoing effort to remove use of the outdated flag > '-Djava.compiler" such that the option it

Re: RFR: 8304547: Remove checking of -Djava.compiler in src/jdk.jdi/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java

2023-03-21 Thread Alan Bateman
On Mon, 20 Mar 2023 20:53:41 GMT, Eirik Bjorsnos wrote: > Please review this PR which removes the following outdated guard/check from > SunCommandLineLauncher: > > > if ((options.indexOf("-Djava.compiler=") != -1) && > (options.toLowerCase().indexOf("-djava.compiler=none") == -1)) { >

Re: RFR: 8304547: Remove checking of -Djava.compiler in src/jdk.jdi/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java

2023-03-21 Thread Eirik Bjorsnos
On Tue, 21 Mar 2023 02:49:15 GMT, Chris Plummer wrote: > Please make sure you run the jdk/com/sun/jdi tests and the jdb, jdwp, and jdi > test under hotspot/jtreg/vmTestbase/nsk Tests passed: == Test summary == TEST

Re: RFR: JDK-8300245: Replace NULL with nullptr in share/jfr/ [v4]

2023-03-21 Thread Johan Sjölen
On Tue, 24 Jan 2023 21:10:31 GMT, Johan Sjölen wrote: >> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory >> share/jfr/. Unfortunately the script that does the change isn't perfect, and >> so we >> need to comb through these manually to make sure nothing has gone wron

Re: RFR: 8301995: Move invokedynamic resolution information out of ConstantPoolCacheEntry [v9]

2023-03-21 Thread Andrew Haley
On Mon, 20 Mar 2023 14:29:35 GMT, Matias Saavedra Silva wrote: >> The current structure used to store the resolution information for >> invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its >> ambigious fields f1 and f2. This structure can hold information for fields, >>

Re: [External] : Re: Disallowing the dynamic loading of agents by default

2023-03-21 Thread Ron Pressler
Hi Volker. JEP 261 states: "The dynamic loading of JVM TI agents will be disabled by default in a future release. To prepare for that change we recommend that applications that allow dynamic agents start using the option -XX:+EnableDynamicAgentLoading to enable that loading explicitly." The pur

Re: RFR: 8301995: Move invokedynamic resolution information out of ConstantPoolCacheEntry [v9]

2023-03-21 Thread Matias Saavedra Silva
On Tue, 21 Mar 2023 10:51:08 GMT, Andrew Haley wrote: >> Matias Saavedra Silva has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix riscv interpreter mistake and acquire semantics > > src/hotspot/cpu/aarch64/templateTable_aarch64.cpp line

Re: RFR: 8301995: Move invokedynamic resolution information out of ConstantPoolCacheEntry [v9]

2023-03-21 Thread Richard Reingruber
On Tue, 21 Mar 2023 10:49:32 GMT, Andrew Haley wrote: >> Matias Saavedra Silva has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix riscv interpreter mistake and acquire semantics > > src/hotspot/cpu/aarch64/templateTable_aarch64.cpp line

Integrated: 8290200: com/sun/jdi/InvokeHangTest.java fails with "Debuggee appears to be hung"

2023-03-21 Thread Chris Plummer
On Thu, 16 Mar 2023 21:02:09 GMT, Chris Plummer wrote: > The debuggee main method creates two threads and then starts them: > > > public static void main(String[] args) { > System.out.println("Howdy!"); > Thread t1 = TestScaffold.newThread(new InvokeHangTarg(), name1); >

Re: RFR: 8301995: Move invokedynamic resolution information out of ConstantPoolCacheEntry [v10]

2023-03-21 Thread Matias Saavedra Silva
> The current structure used to store the resolution information for > invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its > ambigious fields f1 and f2. This structure can hold information for fields, > methods, and invokedynamics and each of its fields can hold different

Re: RFR: 8294977: Convert test/jdk/java tests from ASM library to Classfile API [v7]

2023-03-21 Thread Chen Liang
> Summaries: > 1. A few recommendations about updating the constant API is made at > https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html > and I may update this patch shall the API changes be integrated before > 2. One ASM library-specific test, `LambdaAsm` is removed. Oth

RFR: 8304436: com/sun/jdi/ThreadMemoryLeakTest.java fails with "OutOfMemoryError: Java heap space" with ZGC

2023-03-21 Thread Chris Plummer
There are two GC related issues with this test that are being addressed. The test was limiting the heap size to 6m so if there is still a leak, it will be detected quickly. This proved to be too small of a size when using ZGC. For the most part changing the size to 7m fixed this issue. However,

Re: RFR: 8301995: Move invokedynamic resolution information out of ConstantPoolCacheEntry [v9]

2023-03-21 Thread Andrew Haley
On Tue, 21 Mar 2023 17:40:46 GMT, Richard Reingruber wrote: >> src/hotspot/cpu/aarch64/templateTable_aarch64.cpp line 2337: >> >>> 2335: // Load-acquire the adapter method >>> 2336: __ lea(method, Address(cache, >>> in_bytes(ResolvedIndyEntry::method_offset(; >>> 2337: __ ldar(method,

Re: RFR: 8304436: com/sun/jdi/ThreadMemoryLeakTest.java fails with "OutOfMemoryError: Java heap space" with ZGC [v2]

2023-03-21 Thread Chris Plummer
> There are two GC related issues with this test that are being addressed. The > test was limiting the heap size to 6m so if there is still a leak, it will be > detected quickly. This proved to be too small of a size when using ZGC. For > the most part changing the size to 7m fixed this issue. H

Re: RFR: 8291555: Implement alternative fast-locking scheme [v29]

2023-03-21 Thread Vladimir Kozlov
On Thu, 16 Mar 2023 20:56:15 GMT, Roman Kennke wrote: >> This change adds a fast-locking scheme as an alternative to the current >> stack-locking implementation. It retains the advantages of stack-locking >> (namely fast locking in uncontended code-paths), while avoiding the overload >> of the

RFR: 8297286: runtime/vthread tests crashing after JDK-8296324

2023-03-21 Thread Serguei Spitsyn
The fix is to enable support for late binding JVMTI agents. The fix includes: - New function `JvmtiEnvBase::enable_virtual_threads_notify_jvmti()` which does enabling JVMTI VTMS transition notifications in case of agent loaded into running VM. This function executes a VM operation counting VTMS t

Re: RFR: 8297286: runtime/vthread tests crashing after JDK-8296324 [v2]

2023-03-21 Thread Serguei Spitsyn
> The fix is to enable support for late binding JVMTI agents. > The fix includes: > - New function `JvmtiEnvBase::enable_virtual_threads_notify_jvmti()` which > does enabling JVMTI VTMS transition notifications in case of agent loaded > into running VM. This function executes a VM operation count

Re: RFR: 8297286: runtime/vthread tests crashing after JDK-8296324 [v3]

2023-03-21 Thread Serguei Spitsyn
> The fix is to enable support for late binding JVMTI agents. > The fix includes: > - New function `JvmtiEnvBase::enable_virtual_threads_notify_jvmti()` which > does enabling JVMTI VTMS transition notifications in case of agent loaded > into running VM. This function executes a VM operation count