Re: [jdk20] RFR: 8299891: JMX ObjectInputFilter additional classes needed [v3]

On Tue, 31 Jan 2023 14:29:38 GMT, Kevin Walls wrote: >> The default setting for the ObjectInputFilter for JMX, introduced in jdk20, >> is too restrictive. >> javax.management.Attribute and AttributeList classes are also needed, and >> Query related classes. >> >> There are a number of Query-re

[jdk20] Integrated: 8299891: JMX ObjectInputFilter additional classes needed

On Wed, 11 Jan 2023 09:40:11 GMT, Kevin Walls wrote: > The default setting for the ObjectInputFilter for JMX, introduced in jdk20, > is too restrictive. > javax.management.Attribute and AttributeList classes are also needed, and > Query related classes. > > There are a number of Query-related

Integrated: JDK-8301447: [REDO] CodeHeap has virtual methods that are not overridden

On Tue, 31 Jan 2023 14:30:29 GMT, Justin King wrote: > Redo [JDK-8301378](https://bugs.openjdk.org/browse/JDK-8301378), this time > also fixing the serviceability code. This pull request has now been integrated. Changeset: 7c6a8db3 Author:Justin King Committer: Tobias Hartmann URL:

Re: RFR: JDK-8301447: [REDO] CodeHeap has virtual methods that are not overridden

On Tue, 31 Jan 2023 14:30:29 GMT, Justin King wrote: > Redo [JDK-8301378](https://bugs.openjdk.org/browse/JDK-8301378), this time > also fixing the serviceability code. Looks good to me and Vladimir's testing all passed. - Marked as reviewed by thartmann (Reviewer). PR: https://g

Integrated: 8300811: jdb ThreadStartRequest and ThreadDeathRequest should use SUSPEND_NONE instead of SUSPEND_ALL

On Mon, 23 Jan 2023 21:02:51 GMT, Chris Plummer wrote: > jdb creates a ThreadStartRequest and ThreadDeathRequest so it can track all > created threads. It creates them with the SUSPEND_ALL policy. This is > unnecessary since jdb always immediately resumes all threads after doing the > thread b

RFR: Merge jdk20

Forwardport JDK 20 -> JDK 21 - Commit messages: - Merge remote-tracking branch 'jdk20/master' into Merge_jdk20 - 8298377: JfrVframeStream causes deadlocks in ZGC - 8299891: JMX ObjectInputFilter additional classes needed The merge commit only contains trivial merges, so no merge-s

Re: RFR: 8228604: StackMapFrames are missing from redefined class bytes of retransformed classes [v2]

> classFileParser drops stack map frames for JDK classes (when verification is > not required). > As a result JvmtiClassFileReconstituter cannot restore the attribute for > class redefinition. > Note that if the class is in CDS archive, the frames are restored from CDS, > so this issue affects o

Integrated: Merge jdk20

On Wed, 1 Feb 2023 19:43:51 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 20 -> JDK 21 This pull request has now been integrated. Changeset: d6832121 Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/d6832121b718d40df263da6e2f9261dee2c4c508 Stats: 158 lines i

RFR: 8301644: com/sun/jdi/JdbStopThreadTest.java fails after JDK-8300811

This test started failing after [JDK-8300811](https://bugs.openjdk.org/browse/JDK-8300811), which made the jdb ThreadStartRequest and ThreadDeathRequest use SUSPEND_NONE instead of SUSPEND_ALL. This sped up the handling of these events a lot, which has impacted the timing of this test and expos

Re: RFR: 8228604: StackMapFrames are missing from redefined class bytes of retransformed classes [v3]

> classFileParser drops stack map frames for JDK classes (when verification is > not required). > As a result JvmtiClassFileReconstituter cannot restore the attribute for > class redefinition. > Note that if the class is in CDS archive, the frames are restored from CDS, > so this issue affects o

Re: RFR: 8228604: StackMapFrames are missing from redefined class bytes of retransformed classes [v3]

On Wed, 1 Feb 2023 04:22:48 GMT, Serguei Spitsyn wrote: > "retransform" fixed - PR: https://git.openjdk.org/jdk/pull/12155

Re: RFR: 8228604: StackMapFrames are missing from redefined class bytes of retransformed classes [v3]

On Thu, 2 Feb 2023 00:20:06 GMT, Alex Menkov wrote: >> I'd also suggest a couple of name changes to increase readability: >> loadBytes => loadedBytes >> retransformBytes => retransformedBytes > >> "retransform" > > fixed > I'd also suggest a couple of name changes to increase readability: l

Re: RFR: 8228604: StackMapFrames are missing from redefined class bytes of retransformed classes [v3]

On Tue, 24 Jan 2023 03:58:02 GMT, Chris Plummer wrote: > > Copyright needs updating. It was updated by other fix in master branch - PR: https://git.openjdk.org/jdk/pull/12155

Re: RFR: 8301644: com/sun/jdi/JdbStopThreadTest.java fails after JDK-8300811

On Wed, 1 Feb 2023 23:51:02 GMT, Chris Plummer wrote: > This test started failing after > [JDK-8300811](https://bugs.openjdk.org/browse/JDK-8300811), which made the > jdb ThreadStartRequest and ThreadDeathRequest use SUSPEND_NONE instead of > SUSPEND_ALL. This sped up the handling of these eve

RFR: 8301659: Resolve initialization reordering issues on Windows for libawt and libsaproc

Small, trivial change to resolve initialization order reordering in constructors, required for [JDK-8301659](https://bugs.openjdk.org/browse/JDK-8301659) - Commit messages: - Resolve reordering issues in libawt and libsaproc Changes: https://git.openjdk.org/jdk/pull/12382/files W

Re: RFR: 8301659: Resolve initialization reordering issues on Windows for libawt and libsaproc

On Thu, 2 Feb 2023 06:12:20 GMT, Julian Waters wrote: > Small, trivial change to resolve initialization order reordering in > constructors, required for > [JDK-8301659](https://bugs.openjdk.org/browse/JDK-8301659) Bundling unrelated changes like this together is rarely a good idea, but these