Integrated: 8299795: Relativize locals in interpreter frames

2023-01-23 Thread Fredrik Bredberg
On Mon, 9 Jan 2023 10:30:06 GMT, Fredrik Bredberg wrote: > Implementation of relativized locals in interpreter frames for x86. x64, arm, > aarch64, ppc64le and riscv. > Not relativized locals on zero and s390 but done some changes to cope with > the changed generic code. > Tested tier1-tier8 on

Re: RFR: 8299234: JMX Repository.query performance [v3]

2023-01-23 Thread Daniel Fuchs
On Wed, 11 Jan 2023 14:09:21 GMT, Alexey Bakhtin wrote: >> Please find a patch to improve JMX Repository.query performance >> >> Using ObjectName.apply() allows significantly decrease memory usage and the >> number of GC cycles: >> Before: >> >> $ java test 100 100 >> Test PASSED in 89

Re: RFR: 8297638: Memory leak in case of many started-dead threads [v2]

2023-01-23 Thread Egor Ushakov
On Thu, 19 Jan 2023 21:59:22 GMT, Chris Plummer wrote: >> Fix JDI leak when the debuggee creates a lot of threads, while at the same >> the debugger is not sending any commands. The lack of commands being sent >> results in code not being triggered that normally would clear out >> unreachable

Re: RFR: 8299234: JMX Repository.query performance [v4]

2023-01-23 Thread Alexey Bakhtin
> Please find a patch to improve JMX Repository.query performance > > Using ObjectName.apply() allows significantly decrease memory usage and the > number of GC cycles: > Before: > > $ java test 100 100 > Test PASSED in 8943169791 ns. > GC: G1 Young Generation getCollectionCount()=177 ge

RFR: Merge jdk20

2023-01-23 Thread Jesper Wilhelmsson
Forwardport JDK 20 -> JDK 21 - Commit messages: - Merge - 8290919: Update nroff pages in JDK 20 before RC The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=jdk&pr=12150&range=00.0 - jdk20: https

Re: RFR: 8299234: JMX Repository.query performance [v3]

2023-01-23 Thread Alexey Bakhtin
On Wed, 11 Jan 2023 14:09:21 GMT, Alexey Bakhtin wrote: >> Please find a patch to improve JMX Repository.query performance >> >> Using ObjectName.apply() allows significantly decrease memory usage and the >> number of GC cycles: >> Before: >> >> $ java test 100 100 >> Test PASSED in 89

Integrated: Merge jdk20

2023-01-23 Thread Jesper Wilhelmsson
On Mon, 23 Jan 2023 19:52:49 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 20 -> JDK 21 This pull request has now been integrated. Changeset: 56dc3b08 Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/56dc3b08a62f651835c5bccca987d93ba2bb8961 Stats: 28 lines i

RFR: 8300810: Get rid of unused JDI removeListener() methods

2023-01-23 Thread Chris Plummer
Remove removeListener() methods. They are not called. - Commit messages: - Remove removeListener() method. Changes: https://git.openjdk.org/jdk/pull/12151/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12151&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8300810 St

RFR: 8300811: jdb ThreadStartRequest and ThreadDeathRequest should use SUSPEND_NONE instead of SUSPEND_ALL

2023-01-23 Thread Chris Plummer
jdb creates a ThreadStartRequest and ThreadDeathRequest so it can track all created threads. It creates them with the SUSPEND_ALL policy. This is unnecessary since jdb always immediately resumes all threads after doing the thread bookkeeping. There is no interaction with the jdb user like there

RFR: 8290918: Initial nroff manpage generation for JDK 21

2023-01-23 Thread David Holmes
Please review this simple update to the manpage to set the version to 21-ea. This change also corrects a typo in javac.1 that was manually introduced by JDK-8300591 Thanks. - Commit messages: - 8290918: Initial nroff manpage generation for JDK 21 Changes: https://git.openjdk.org/

Re: RFR: 8290918: Initial nroff manpage generation for JDK 21

2023-01-23 Thread Lance Andersen
On Mon, 23 Jan 2023 22:59:22 GMT, David Holmes wrote: > Please review this simple update to the manpage to set the version to 21-ea. > > This change also corrects a typo in javac.1 that was manually introduced by > JDK-8300591 > > Thanks. Marked as reviewed by lancea (Reviewer).

RFR: 8228604: StackMapFrames are missing from redefined class bytes of retransformed classes

2023-01-23 Thread Alex Menkov
classFileParser drops stack map frames for JDK classes (when verification is not required). As a result JvmtiClassFileReconstituter cannot restore the attribute for class redefinition. Note that if the class is in CDS archive, the frames are restored from CDS, so this issue affects only JDK clas

Re: RFR: 8290918: Initial nroff manpage generation for JDK 21

2023-01-23 Thread David Holmes
On Mon, 23 Jan 2023 23:24:06 GMT, Lance Andersen wrote: >> Please review this simple update to the manpage to set the version to 21-ea. >> >> This change also corrects a typo in javac.1 that was manually introduced by >> JDK-8300591 >> >> Thanks. > > Marked as reviewed by lancea (Reviewer). T

Re: RFR: 8290918: Initial nroff manpage generation for JDK 21

2023-01-23 Thread Iris Clark
On Mon, 23 Jan 2023 22:59:22 GMT, David Holmes wrote: > Please review this simple update to the manpage to set the version to 21-ea. > > This change also corrects a typo in javac.1 that was manually introduced by > JDK-8300591 > > Thanks. Marked as reviewed by iris (Reviewer). -

Re: RFR: 8228604: StackMapFrames are missing from redefined class bytes of retransformed classes

2023-01-23 Thread Chris Plummer
On Tue, 24 Jan 2023 00:16:10 GMT, Alex Menkov wrote: > This code is old (from "initial load") and I don't understand the reason it > was implemented this way. My guess is footprint reduction. The assumption was probably that the stackmaps are not needed if the method does not need verification

Re: RFR: 8228604: StackMapFrames are missing from redefined class bytes of retransformed classes

2023-01-23 Thread Chris Plummer
On Tue, 24 Jan 2023 00:16:10 GMT, Alex Menkov wrote: > classFileParser drops stack map frames for JDK classes (when verification is > not required). > As a result JvmtiClassFileReconstituter cannot restore the attribute for > class redefinition. > Note that if the class is in CDS archive, the f

Re: RFR: 8290918: Initial nroff manpage generation for JDK 21

2023-01-23 Thread David Holmes
On Tue, 24 Jan 2023 01:28:53 GMT, Iris Clark wrote: >> Please review this simple update to the manpage to set the version to 21-ea. >> >> This change also corrects a typo in javac.1 that was manually introduced by >> JDK-8300591 >> >> Thanks. > > Marked as reviewed by iris (Reviewer). Thanks

Re: RFR: 8290918: Initial nroff manpage generation for JDK 21

2023-01-23 Thread Joe Darcy
On Mon, 23 Jan 2023 22:59:22 GMT, David Holmes wrote: > Please review this simple update to the manpage to set the version to 21-ea. > > This change also corrects a typo in javac.1 that was manually introduced by > JDK-8300591 > > Thanks. Marked as reviewed by darcy (Reviewer). -

Re: RFR: 8228604: StackMapFrames are missing from redefined class bytes of retransformed classes

2023-01-23 Thread David Holmes
On Tue, 24 Jan 2023 00:16:10 GMT, Alex Menkov wrote: > classFileParser drops stack map frames for JDK classes (when verification is > not required). > As a result JvmtiClassFileReconstituter cannot restore the attribute for > class redefinition. > Note that if the class is in CDS archive, the f

Re: RFR: 8228604: StackMapFrames are missing from redefined class bytes of retransformed classes

2023-01-23 Thread David Holmes
On Tue, 24 Jan 2023 00:16:10 GMT, Alex Menkov wrote: > classFileParser drops stack map frames for JDK classes (when verification is > not required). > As a result JvmtiClassFileReconstituter cannot restore the attribute for > class redefinition. > Note that if the class is in CDS archive, the f

Re: RFR: 8290918: Initial nroff manpage generation for JDK 21

2023-01-23 Thread David Holmes
On Tue, 24 Jan 2023 05:54:44 GMT, Joe Darcy wrote: >> Please review this simple update to the manpage to set the version to 21-ea. >> >> This change also corrects a typo in javac.1 that was manually introduced by >> JDK-8300591 >> >> Thanks. > > Marked as reviewed by darcy (Reviewer). Thanks

Integrated: 8290918: Initial nroff manpage generation for JDK 21

2023-01-23 Thread David Holmes
On Mon, 23 Jan 2023 22:59:22 GMT, David Holmes wrote: > Please review this simple update to the manpage to set the version to 21-ea. > > This change also corrects a typo in javac.1 that was manually introduced by > JDK-8300591 > > Thanks. This pull request has now been integrated. Changeset: