Integrated: JDK-8299470: sun/jvm/hotspot/SALauncher.java handling of negative rmiport args

2023-01-05 Thread Matthias Baesken
On Mon, 2 Jan 2023 14:31:14 GMT, Matthias Baesken wrote: > The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some > circumstances a negative rmiport (--rmiport -1) to SALauncher.java. > This leads to a somewhat misleading message > `[debugd] Argument is expected for 'rmiport'

RFR: JDK-8299657: sun/tools/jhsdb/SAGetoptTest.java fails after 8299470

2023-01-05 Thread Matthias Baesken
Some exception/error message changed with 8299470 so we have to adjust the test. Current error is Unexpected error 'Successor argument without leading - is expected for 'd' but we got '-c'' java.lang.RuntimeException: Bad option test 4 failed at SAGetoptTest.badOptionsTest(SAGetoptTest.java:124)

Re: RFR: JDK-8299657: sun/tools/jhsdb/SAGetoptTest.java fails after 8299470

2023-01-05 Thread Christoph Langer
On Thu, 5 Jan 2023 08:55:32 GMT, Matthias Baesken wrote: > Some exception/error message changed with 8299470 so we have to adjust the > test. > Current error is > > Unexpected error 'Successor argument without leading - is expected for 'd' > but we got '-c'' > java.lang.RuntimeException: Bad

Re: RFR: JDK-8299657: sun/tools/jhsdb/SAGetoptTest.java fails after 8299470

2023-01-05 Thread Matthias Baesken
On Thu, 5 Jan 2023 08:55:32 GMT, Matthias Baesken wrote: > Some exception/error message changed with 8299470 so we have to adjust the > test. > Current error is > > Unexpected error 'Successor argument without leading - is expected for 'd' > but we got '-c'' > java.lang.RuntimeException: Bad

Integrated: JDK-8299657: sun/tools/jhsdb/SAGetoptTest.java fails after 8299470

2023-01-05 Thread Matthias Baesken
On Thu, 5 Jan 2023 08:55:32 GMT, Matthias Baesken wrote: > Some exception/error message changed with 8299470 so we have to adjust the > test. > Current error is > > Unexpected error 'Successor argument without leading - is expected for 'd' > but we got '-c'' > java.lang.RuntimeException: Bad

Re: RFR: 8299518: HotSpotVirtualMachine shared code across different platforms [v3]

2023-01-05 Thread Yi Yang
On Thu, 5 Jan 2023 05:44:23 GMT, David Holmes wrote: >> Good suggestion. >> However, I wonder why the `fd` is casted from `long` to `int` on Unix. The >> Unix versions of SocketInputStream had `int fd`. >> So, the following code also needs to cast `fd` to `int`: >> >> +public synchroniz

Re: RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v7]

2023-01-05 Thread Robbin Ehn
On Thu, 8 Dec 2022 16:56:40 GMT, Afshin Zafari wrote: >> test of tier1-5 passed. > > Afshin Zafari has updated the pull request incrementally with one additional > commit since the last revision: > > 8292741: Convert JvmtiTagMapTable to ResourceHashtable Looks fine, thanks. (+- DavidH commen

Re: RFR: JDK-8299470: sun/jvm/hotspot/SALauncher.java handling of negative rmiport args [v5]

2023-01-05 Thread David Holmes
On Wed, 4 Jan 2023 15:30:10 GMT, Matthias Baesken wrote: >> The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some >> circumstances a negative rmiport (--rmiport -1) to SALauncher.java. >> This leads to a somewhat misleading message >> `[debugd] Argument is expected for 'rmip

RFR: 8015831: Add lint check for calling overridable methods from a constructor

2023-01-05 Thread Archie L . Cobbs
This PR adds a new lint warning category `this-escape`. It also adds `@SuppressWarnings` annotations as needed to the JDK itself to allow the JDK to continue to compile with `-Xlint:all`. A 'this' escape warning is generated for a constructor `A()` in a class `A` when the compiler detects that

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor

2023-01-05 Thread David Holmes
On Fri, 6 Jan 2023 02:20:53 GMT, Archie L. Cobbs wrote: > This PR adds a new lint warning category `this-escape`. > > It also adds `@SuppressWarnings` annotations as needed to the JDK itself to > allow the JDK to continue to compile with `-Xlint:all`. > > A 'this' escape warning is generated f

Re: RFR: 8299518: HotSpotVirtualMachine shared code across different platforms [v3]

2023-01-05 Thread David Holmes
On Thu, 5 Jan 2023 11:47:56 GMT, Yi Yang wrote: >> Looks like Windows needs a long fd so the shared API takes long and we then >> cast to int for the Unix native methods. A little messy but fixable. > >> If you add read/close methods for Windows that then call readPipe/closePipe, >> then we don

Re: RFR: 8299518: HotSpotVirtualMachine shared code across different platforms [v3]

2023-01-05 Thread Yi Yang
On Fri, 6 Jan 2023 05:50:05 GMT, David Holmes wrote: > As long as all the platform-specific `VirtualMachineImpl` classes define a > `read` and `close` method then we can simply have the shared socket stream > class call those methods. Windows will need an extra level of indirection > because i

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor

2023-01-05 Thread Alan Bateman
On Fri, 6 Jan 2023 02:20:53 GMT, Archie L. Cobbs wrote: > This PR adds a new lint warning category `this-escape`. > > It also adds `@SuppressWarnings` annotations as needed to the JDK itself to > allow the JDK to continue to compile with `-Xlint:all`. > > A 'this' escape warning is generated f