On Mon, 2 Jan 2023 14:31:14 GMT, Matthias Baesken wrote:
> The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some
> circumstances a negative rmiport (--rmiport -1) to SALauncher.java.
> This leads to a somewhat misleading message
> `[debugd] Argument is expected for 'rmiport'
Some exception/error message changed with 8299470 so we have to adjust the test.
Current error is
Unexpected error 'Successor argument without leading - is expected for 'd' but
we got '-c''
java.lang.RuntimeException: Bad option test 4 failed
at SAGetoptTest.badOptionsTest(SAGetoptTest.java:124)
On Thu, 5 Jan 2023 08:55:32 GMT, Matthias Baesken wrote:
> Some exception/error message changed with 8299470 so we have to adjust the
> test.
> Current error is
>
> Unexpected error 'Successor argument without leading - is expected for 'd'
> but we got '-c''
> java.lang.RuntimeException: Bad
On Thu, 5 Jan 2023 08:55:32 GMT, Matthias Baesken wrote:
> Some exception/error message changed with 8299470 so we have to adjust the
> test.
> Current error is
>
> Unexpected error 'Successor argument without leading - is expected for 'd'
> but we got '-c''
> java.lang.RuntimeException: Bad
On Thu, 5 Jan 2023 08:55:32 GMT, Matthias Baesken wrote:
> Some exception/error message changed with 8299470 so we have to adjust the
> test.
> Current error is
>
> Unexpected error 'Successor argument without leading - is expected for 'd'
> but we got '-c''
> java.lang.RuntimeException: Bad
On Thu, 5 Jan 2023 05:44:23 GMT, David Holmes wrote:
>> Good suggestion.
>> However, I wonder why the `fd` is casted from `long` to `int` on Unix. The
>> Unix versions of SocketInputStream had `int fd`.
>> So, the following code also needs to cast `fd` to `int`:
>>
>> +public synchroniz
On Thu, 8 Dec 2022 16:56:40 GMT, Afshin Zafari wrote:
>> test of tier1-5 passed.
>
> Afshin Zafari has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8292741: Convert JvmtiTagMapTable to ResourceHashtable
Looks fine, thanks. (+- DavidH commen
On Wed, 4 Jan 2023 15:30:10 GMT, Matthias Baesken wrote:
>> The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some
>> circumstances a negative rmiport (--rmiport -1) to SALauncher.java.
>> This leads to a somewhat misleading message
>> `[debugd] Argument is expected for 'rmip
This PR adds a new lint warning category `this-escape`.
It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
allow the JDK to continue to compile with `-Xlint:all`.
A 'this' escape warning is generated for a constructor `A()` in a class `A`
when the compiler detects that
On Fri, 6 Jan 2023 02:20:53 GMT, Archie L. Cobbs wrote:
> This PR adds a new lint warning category `this-escape`.
>
> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
> allow the JDK to continue to compile with `-Xlint:all`.
>
> A 'this' escape warning is generated f
On Thu, 5 Jan 2023 11:47:56 GMT, Yi Yang wrote:
>> Looks like Windows needs a long fd so the shared API takes long and we then
>> cast to int for the Unix native methods. A little messy but fixable.
>
>> If you add read/close methods for Windows that then call readPipe/closePipe,
>> then we don
On Fri, 6 Jan 2023 05:50:05 GMT, David Holmes wrote:
> As long as all the platform-specific `VirtualMachineImpl` classes define a
> `read` and `close` method then we can simply have the shared socket stream
> class call those methods. Windows will need an extra level of indirection
> because i
On Fri, 6 Jan 2023 02:20:53 GMT, Archie L. Cobbs wrote:
> This PR adds a new lint warning category `this-escape`.
>
> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
> allow the JDK to continue to compile with `-Xlint:all`.
>
> A 'this' escape warning is generated f
13 matches
Mail list logo