Re: RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v7]

2022-12-11 Thread David Holmes
On Thu, 8 Dec 2022 16:56:40 GMT, Afshin Zafari wrote: >> test of tier1-5 passed. > > Afshin Zafari has updated the pull request incrementally with one additional > commit since the last revision: > > 8292741: Convert JvmtiTagMapTable to ResourceHashtable I'm still seeing a few oddities in th

Re: RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v7]

2022-12-11 Thread David Holmes
On Mon, 28 Nov 2022 22:17:14 GMT, David Holmes wrote: >> ResourceHashTable::put() returns true if the Key,Value is added, false if >> the Value is updated. > > But this doesn't do that, so ?? This issue is not resolved. - PR: https://git.openjdk.org/jdk/pull/11288

Re: RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v7]

2022-12-11 Thread David Holmes
On Mon, 28 Nov 2022 01:23:10 GMT, David Holmes wrote: >> Afshin Zafari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8292741: Convert JvmtiTagMapTable to ResourceHashtable > > src/hotspot/share/prims/jvmtiTagMapTable.cpp line 88: > >>

Re: RFR: 8287812: Cleanup JDWP agent GetEnv initialization [v2]

2022-12-11 Thread Chris Plummer
On Sat, 10 Dec 2022 10:29:43 GMT, Alan Bateman wrote: >> I have a memory of the following concerning JVM/TI versions: >> >> - if you asked for JVMTI_VERSION, then you got the highest version supported >> by the JVM. >> - if you asked for JVMTI_VERSION_1, then you got the highest compatible >>

Re: RFR: 8298513: vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy009/TestDescription.java fails with usage tracker

2022-12-11 Thread Chris Plummer
On Fri, 9 Dec 2022 23:18:23 GMT, Alex Menkov wrote: > The fix updates the test to ignore ThreadDeathEvent event from non-test > threads waiting for breakpoint Marked as reviewed by cjplummer (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11620

Re: RFR: 8298514: vmTestbase/nsk/jdi/EventRequestManager/threadDeathRequests/thrdeathreq002/TestDescription.java fails with usage tracker

2022-12-11 Thread Chris Plummer
On Fri, 9 Dec 2022 23:21:04 GMT, Alex Menkov wrote: > One more test fix to ignore ThreadDeathEvent event from non-test threads > waiting for breakpoint Marked as reviewed by cjplummer (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11621

Integrated: 8298090: Use String.join() instead of manual loop in DescriptorSupport.toString

2022-12-11 Thread Andrey Turbanov
On Wed, 2 Nov 2022 21:30:51 GMT, Andrey Turbanov wrote: > There is opportunity to use String.join in DescriptorSupport.toString > implementation. Result code is much shorter and clearer. This pull request has now been integrated. Changeset: d646e32b Author:Andrey Turbanov URL: http